[Qemu-devel] [PATCH v3 0/4] softfloat: Fix division

Richard Henderson posted 4 patches 5 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181004175700.20847-1-richard.henderson@linaro.org
Test docker-clang@ubuntu failed
Test checkpatch passed
include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----
fpu/softfloat.c                | 35 ++++++++++++++-----
2 files changed, 80 insertions(+), 17 deletions(-)
[Qemu-devel] [PATCH v3 0/4] softfloat: Fix division
Posted by Richard Henderson 5 years, 5 months ago
Changes from v2:
  * Add shift128Left.  I had been using shortShift128Left,
    with a shift of 64, which lead to undefined behaviour.
    Which I suspect is exactly the Heisenbug Alex saw.

    I did keep the R-b tags I had already applied.


r~


Richard Henderson (4):
  softfloat: Fix division
  softfloat: Specialize udiv_qrnnd for x86_64
  softfloat: Specialize udiv_qrnnd for s390x
  softfloat: Specialize udiv_qrnnd for ppc64

 include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----
 fpu/softfloat.c                | 35 ++++++++++++++-----
 2 files changed, 80 insertions(+), 17 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PATCH v3 0/4] softfloat: Fix division
Posted by Alex Bennée 5 years, 5 months ago
Richard Henderson <richard.henderson@linaro.org> writes:

> Changes from v2:
>   * Add shift128Left.  I had been using shortShift128Left,
>     with a shift of 64, which lead to undefined behaviour.
>     Which I suspect is exactly the Heisenbug Alex saw.

No weirdness this time around

>
>     I did keep the R-b tags I had already applied.

You already have mine but this version also:

Tested-by: Alex Bennée <alex.bennee@linaro.org>

>
>
> r~
>
>
> Richard Henderson (4):
>   softfloat: Fix division
>   softfloat: Specialize udiv_qrnnd for x86_64
>   softfloat: Specialize udiv_qrnnd for s390x
>   softfloat: Specialize udiv_qrnnd for ppc64
>
>  include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----
>  fpu/softfloat.c                | 35 ++++++++++++++-----
>  2 files changed, 80 insertions(+), 17 deletions(-)


--
Alex Bennée