From nobody Mon Feb 9 15:46:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538653931503143.17373330125247; Thu, 4 Oct 2018 04:52:11 -0700 (PDT) Received: from localhost ([::1]:55216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g82Ak-0002CT-6f for importer@patchew.org; Thu, 04 Oct 2018 07:52:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g822Y-0004WY-02 for qemu-devel@nongnu.org; Thu, 04 Oct 2018 07:43:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g822T-0005wN-DV for qemu-devel@nongnu.org; Thu, 04 Oct 2018 07:43:33 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:55945) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g822T-0005SM-21 for qemu-devel@nongnu.org; Thu, 04 Oct 2018 07:43:29 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0FFC64428D; Thu, 4 Oct 2018 13:43:13 +0200 (CEST) From: Dominik Csapak To: qemu-devel@nongnu.org Date: Thu, 4 Oct 2018 13:43:10 +0200 Message-Id: <20181004114312.27346-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181004114312.27346-1-d.csapak@proxmox.com> References: <20181004114312.27346-1-d.csapak@proxmox.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 Subject: [Qemu-devel] [PATCH v2 1/3] osdep: add qemu_launch_script for executing scripts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, jasowang@redhat.com, philmd@redhat.com, thuth@redhat.com, sw@weilnetz.de Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" this adds a small function for launching an external script via fork/exec (not available for windows) and is intended for replacing 'launch_script' in net/tap.c and to provide a general way to launch scripts Signed-off-by: Dominik Csapak --- i modeled the windows error after the qemu_fork implementation, since it does not exist for the same reason changes since v1: * new in v2 include/qemu/osdep.h | 12 ++++++++++++ util/oslib-posix.c | 34 ++++++++++++++++++++++++++++++++++ util/oslib-win32.c | 8 ++++++++ 3 files changed, 54 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 4f8559e550..26c1f01d55 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -564,6 +564,18 @@ char *qemu_get_pid_name(pid_t pid); */ pid_t qemu_fork(Error **errp); =20 +/** + * qemu_launch_script: + * @script: the path to the script + * @args: the arguments for the script + * @fd: a file descriptor that should not be closed + * + * fork and exec a script with the given arguments + * closes all file descriptors > 2 except the one given with fd + */ +void qemu_launch_script(const char *script, char *const args[], int fd, + Error **errp); + /* Using intptr_t ensures that qemu_*_page_mask is sign-extended even * when intptr_t is 32-bit and we are aligning a long long. */ diff --git a/util/oslib-posix.c b/util/oslib-posix.c index fbd0dc8c57..123b142591 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -698,3 +698,37 @@ void sigaction_invoke(struct sigaction *action, } action->sa_sigaction(info->ssi_signo, &si, NULL); } + +void qemu_launch_script(const char *script, char *const args[], int fd, + Error **errp) +{ + int pid, status; + + pid =3D fork(); + if (pid < 0) { + error_setg_errno(errp, errno, "could not launch script %s", + script); + return; + } + if (pid =3D=3D 0) { + int open_max =3D sysconf(_SC_OPEN_MAX), i; + + for (i =3D 3; i < open_max; i++) { + if (i !=3D fd) { + close(i); + } + } + execv(script, args); + _exit(1); + } else { + while (waitpid(pid, &status, 0) !=3D pid) { + /* loop */ + } + + if (WIFEXITED(status) && WEXITSTATUS(status) =3D=3D 0) { + return; + } + error_setg(errp, "script %s failed with status %d", + script, status); + } +} diff --git a/util/oslib-win32.c b/util/oslib-win32.c index b4c17f5dfa..5e14c89dc7 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -803,3 +803,11 @@ bool qemu_write_pidfile(const char *filename, Error **= errp) } return true; } + +void qemu_launch_script(const char *script, char *const args[], int fd, + Error **errp) +{ + errno =3D ENOSYS; + error_setg_errno(errp, errno, + "cannot fork child process"); +} --=20 2.11.0