From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515673312362.4454617994644; Tue, 2 Oct 2018 14:27:53 -0700 (PDT) Received: from localhost ([::1]:45736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SCu-0004cT-7c for importer@patchew.org; Tue, 02 Oct 2018 17:27:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAm-0003O0-Jr for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAi-0007Ih-Q5 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:40 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:41067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAi-0007IF-Hz for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:36 -0400 Received: by mail-wr1-x42d.google.com with SMTP id x12-v6so3808198wru.8 for ; Tue, 02 Oct 2018 14:25:36 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MWSPlXbbn2CkNPA6mdTbU1cRAtkRu68MYe9pxnj15Jk=; b=tOJMh7EZ8P7G3fDT9RwUlzmJt7tPSiEvUZW3ObPlx/rVnqlQSZHYp4ipbozwHOMhpj AO/vraife8eRey22gLR3JbTVodXvgyiqUVpYtczJdpYdLXop3WU0Fsf4kwhA3zB4hx7d nam+EksFZPUDqcyplI97q/dqmQTPMNzz21DO/B6obgP8WOJ+Tvo/4VDBfGdCQDA50DGM 6xLIWD7RZYFXF3ARlpYD+W4b2TeSykTyWzQ3OcNRH1cbzq4V/lfCCuH6SyT8bpYN8bLh P1W5M9xkKpaowCPv72piOoMxsGKSjjUpd6ZmjDNSYlvBdElAwRAR2Gwg+MFKrI0/VojJ /Z6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MWSPlXbbn2CkNPA6mdTbU1cRAtkRu68MYe9pxnj15Jk=; b=oMlq3Q8D2h2Fm0ffuiGJy3f3JVwLvby2/KUeBTjsOgFyRuQHXEKtTAGG2nHMeGLypt gfDMVsoE7nvK3CKVC8NXDdcK7Ha4c1ahIMqIbbij6NpTD4Awal/ef5fQLrx/GEFdsgCo g49/oW9BtQ+wSFVQQ/EYB3Wz1QXyB5GXpjlkRXoVa+u2bBdxnAJbRVJWjvvr0/KrGqsc mQP7J2JE+Au6Amm1+Ju43G6dJU8uz/l7esOT53nuKlhhpvoV3gKOsoxNx5B7xzFxZquI tUL72hUdjoqaeggD8fsIryyK//Lw92EtsTP8BttbDSqgocTO7+/MWu43btsJarSigDpr gf+A== X-Gm-Message-State: ABuFfog/C3jS+fCRJThJ9GNOeJvWXBbChEYJmV+xZGlihk+H9Lkrz1lo QPPIXktabk0/ePgmMazq8wo= X-Google-Smtp-Source: ACcGV61EyoTnQJ7Bff+avJuOeByShiry4vOjBThTf9KSYWe0CVCxYD7wCeskfGLz1KDqhMvF3ahjag== X-Received: by 2002:a5d:4d4b:: with SMTP id a11-v6mr12535727wru.40.1538515535609; Tue, 02 Oct 2018 14:25:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:10 +0200 Message-Id: <20181002212522.23303-2-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42d Subject: [Qemu-devel] [PATCH v2 01/12] trace-events: Fix copy/paste typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Missed while reviewing 5dd85b4b486. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: C=C3=A9dric Le Goater --- hw/timer/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/trace-events b/hw/timer/trace-events index fa4213df5b..ca9ad6321a 100644 --- a/hw/timer/trace-events +++ b/hw/timer/trace-events @@ -56,7 +56,7 @@ systick_timer_tick(void) "systick reload" systick_read(uint64_t addr, uint32_t value, unsigned size) "systick read a= ddr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" systick_write(uint64_t addr, uint32_t value, unsigned size) "systick write= addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" =20 -# hw/char/cmsdk_apb_timer.c +# hw/timer/cmsdk_apb_timer.c cmsdk_apb_timer_read(uint64_t offset, uint64_t data, unsigned size) "CMSDK= APB timer read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" cmsdk_apb_timer_write(uint64_t offset, uint64_t data, unsigned size) "CMSD= K APB timer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" cmsdk_apb_timer_reset(void) "CMSDK APB timer: reset" --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 153851585401933.65742504526122; Tue, 2 Oct 2018 14:30:54 -0700 (PDT) Received: from localhost ([::1]:45751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SFf-0007vs-Ag for importer@patchew.org; Tue, 02 Oct 2018 17:30:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAm-0003Nz-J3 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAj-0007JE-VO for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:40 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:45464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAj-0007Is-N5 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:37 -0400 Received: by mail-wr1-x432.google.com with SMTP id q5-v6so3791927wrw.12 for ; Tue, 02 Oct 2018 14:25:37 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BGPO7EUAJ801Z52a0vdoijHHE2qfMEBVBq91xzW9wro=; b=Hb+5CIOTLZd7z73Pa2wlTFLgn5Ud1RaG0RRfo8FgH6bFFd560AB8yawk2nq+oacS3+ US1avHzUZSyS5VIslAg8xtwReL2vDP7Giq12nW7j728ZmGCyJG8KrsDmbo2S0QdT1Etg h39KMt/qK0DswX1RrEFF9mULtsHEGG4CsO0nCU3ElwIkV1XsKnHGXy/dkfa7PdShfZpf PBfD4dIgvQQ5fYyyo3G+OJDExz1gawkfwH8YtsNdOH/rWQLxAOsdbk/IKSkT7B4EcS1z oaojK9PVhAmmQ4WcbfMJGhIb6hQ7P0BbFEuehR3r4fDhe9BAAtuD7s/5tzAxHS3nSt53 FOLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BGPO7EUAJ801Z52a0vdoijHHE2qfMEBVBq91xzW9wro=; b=fnCCmwiajqi7jHtIBh88WBmax72IKrs8zae3ZN+KbLAEabH8AZxfS8MG5tuCYRCXZX AeWGecr2sSQ+I7M+xc2VWcSbFRMaVuNiqe0vN1IjJowxFUkRvDfZq4zYI/ED3UDttIVd nQ5uKRgbornRROsf0yaudZmEO4DfqB54hrx8GHZThBYVF1ehdtrXmAbcVrWZ8B2yagte mG8wvtBaaovVYWbH1mAHYS/b1+7a+tFN1zWwVLwCx9fzuQhkWmsack9GiTHzvKGqH2xf UPSH5kjU1j4rTaouYgF+H5VEM5ibX2vB5cMATcaVbDlUkqwB50NSe+zu2en/5c7YPLDW bJ0w== X-Gm-Message-State: ABuFfojknY8ORpDVfO9eVDLISRiLLq5hf/zqp1Qpj43l9yd9aAZyFFRF 1O6xZJ6ruXxbfK5jMjyYGztAO2/8 X-Google-Smtp-Source: ACcGV609Wyv4cujLbEWV3X1XV6hZQF9UOxxSOxsRFdV53lop4qqhjG116T0ITUW9UpCUcufi0y13nQ== X-Received: by 2002:adf:fd4a:: with SMTP id h10-v6mr12342027wrs.280.1538515536687; Tue, 02 Oct 2018 14:25:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:11 +0200 Message-Id: <20181002212522.23303-3-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 Subject: [Qemu-devel] [PATCH v2 02/12] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Artyom Tarasenko Reviewed-by: C=C3=A9dric Le Goater --- hw/timer/sun4v-rtc.c | 13 +++---------- hw/timer/trace-events | 4 ++++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/timer/sun4v-rtc.c b/hw/timer/sun4v-rtc.c index 310523225f..13be94f8da 100644 --- a/hw/timer/sun4v-rtc.c +++ b/hw/timer/sun4v-rtc.c @@ -14,15 +14,8 @@ #include "hw/sysbus.h" #include "qemu/timer.h" #include "hw/timer/sun4v-rtc.h" +#include "trace.h" =20 -//#define DEBUG_SUN4V_RTC - -#ifdef DEBUG_SUN4V_RTC -#define DPRINTF(fmt, ...) \ - do { printf("sun4v_rtc: " fmt , ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) do {} while (0) -#endif =20 #define TYPE_SUN4V_RTC "sun4v_rtc" #define SUN4V_RTC(obj) OBJECT_CHECK(Sun4vRtc, (obj), TYPE_SUN4V_RTC) @@ -41,14 +34,14 @@ static uint64_t sun4v_rtc_read(void *opaque, hwaddr add= r, /* accessing the high 32 bits */ val >>=3D 32; } - DPRINTF("read from " TARGET_FMT_plx " val %lx\n", addr, val); + trace_sun4v_rtc_read(addr, val); return val; } =20 static void sun4v_rtc_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - DPRINTF("write 0x%x to " TARGET_FMT_plx "\n", (unsigned)val, addr); + trace_sun4v_rtc_read(addr, val); } =20 static const MemoryRegionOps sun4v_rtc_ops =3D { diff --git a/hw/timer/trace-events b/hw/timer/trace-events index ca9ad6321a..75bd3b1042 100644 --- a/hw/timer/trace-events +++ b/hw/timer/trace-events @@ -66,5 +66,9 @@ cmsdk_apb_dualtimer_read(uint64_t offset, uint64_t data, = unsigned size) "CMSDK A cmsdk_apb_dualtimer_write(uint64_t offset, uint64_t data, unsigned size) "= CMSDK APB dualtimer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" =20 +# hw/timer/sun4v-rtc.c +sun4v_rtc_read(uint64_t addr, uint64_t value) "read: addr 0x%" PRIx64 " va= lue 0x%" PRIx64 +sun4v_rtc_write(uint64_t addr, uint64_t value) "write: addr 0x%" PRIx64 " = value 0x%" PRIx64 + # hw/timer/xlnx-zynqmp-rtc.c xlnx_zynqmp_rtc_gettime(int year, int month, int day, int hour, int min, i= nt sec) "Get time from host: %d-%d-%d %2d:%02d:%02d" --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515674692435.2231345400487; Tue, 2 Oct 2018 14:27:54 -0700 (PDT) Received: from localhost ([::1]:45738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SCv-0004dg-EQ for importer@patchew.org; Tue, 02 Oct 2018 17:27:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAm-0003O3-KA for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAl-0007Jf-8D for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:40 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAl-0007JP-0H for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:39 -0400 Received: by mail-wr1-x434.google.com with SMTP id q5-v6so3791970wrw.12 for ; Tue, 02 Oct 2018 14:25:38 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UXUst7d7hIUTZO/j2jrn4nHT4Nr+N/ejf7PUI+xDe2E=; b=r+QMMyD+FMQ3hIRE1ZAt//CIpLG6MVv+efMuFoXDEm5gbc8DH0KF+ZxMr3h4qQ3wVL BvfAH45S2nTh6Z0ltTpIsfmyJPTS1hFF45g8s2UNFSTbNRX9o++iKrBEygn2TevFqXLI edaK9EJ5TKlw8Y7UGlQam153DJ07hFLKHSLgFz5ZUepJxa8nFI2iREY/sKtCNJINMD/t LTQ8UIoWqFmCFP5go88wStw2ed2WZ22Cs7ihU6lAlKh4/17ptzwKwKCeeCPHMFbPu9oS UPN96ra1g1Fm3yYtHP+vNPn1bk8ufREa7hCwJEyXCQpmkpLlR2zOyiUUXEeVpEcx60A3 6CYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UXUst7d7hIUTZO/j2jrn4nHT4Nr+N/ejf7PUI+xDe2E=; b=CgjpRR8vDTyvjgiwXB8HrkEFt6QIAYYGX0oD4b8cwdVxuRr1mYQ0An2nUxCyFfuatE RehKTQYPeOB86rLxpd5y7EKHUIfaw6fE3aCLSDkmUn26YyAbFFqRHtVigYc1T1GR54ZX Zva3VOQ8YGUVW1ljhvBh0TDzGO65AbMC51Gh1xOc9VLPToAnuYiYP+4Ly0IQBVo91OcL HLLtW5JqKoPSPrtaTcyeWMCR0ai/UgHRGRnRPPda+mH8BgDPg4YScLKV+zk8daKIgiQ9 Uv1TdIm4gZYZMrQDnBCklE1b5h7ThfNhN3q9rcmbiZ+UViuUPEPgadVrFqfZz+EfYMal ZGnA== X-Gm-Message-State: ABuFfogHUEKdHhsp0IasaV3N9N3OV9YrsMXsETVRSR5v7uOxyqQmTAf3 LRNDI54hVvxdfsw0eqsoqvA= X-Google-Smtp-Source: ACcGV60YREUaO1CY7/e7/YvpUBMnxTFPyIVQzniNXufLii5dOP731aAeG/Vbpv+Kunb4Sgynr4OFhQ== X-Received: by 2002:a5d:50cf:: with SMTP id f15-v6mr11196820wrt.128.1538515537987; Tue, 02 Oct 2018 14:25:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:12 +0200 Message-Id: <20181002212522.23303-4-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 Subject: [Qemu-devel] [PATCH v2 03/12] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Move from the legacy SysBusDevice::init method to using DeviceState::realiz= e. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: C=C3=A9dric Le Goater --- hw/timer/sun4v-rtc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/timer/sun4v-rtc.c b/hw/timer/sun4v-rtc.c index 13be94f8da..4e7f6a1eff 100644 --- a/hw/timer/sun4v-rtc.c +++ b/hw/timer/sun4v-rtc.c @@ -63,21 +63,21 @@ void sun4v_rtc_init(hwaddr addr) sysbus_mmio_map(s, 0, addr); } =20 -static int sun4v_rtc_init1(SysBusDevice *dev) +static void sun4v_rtc_realize(DeviceState *dev, Error **errp) { + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); Sun4vRtc *s =3D SUN4V_RTC(dev); =20 memory_region_init_io(&s->iomem, OBJECT(s), &sun4v_rtc_ops, s, "sun4v-rtc", 0x08ULL); - sysbus_init_mmio(dev, &s->iomem); - return 0; + sysbus_init_mmio(sbd, &s->iomem); } =20 static void sun4v_rtc_class_init(ObjectClass *klass, void *data) { - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); + DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - k->init =3D sun4v_rtc_init1; + dc->realize =3D sun4v_rtc_realize; } =20 static const TypeInfo sun4v_rtc_info =3D { --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515672459415.84317201971726; Tue, 2 Oct 2018 14:27:52 -0700 (PDT) Received: from localhost ([::1]:45737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SCt-0004dY-5g for importer@patchew.org; Tue, 02 Oct 2018 17:27:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAn-0003Og-Fr for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAm-0007KO-Ji for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:41 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:33686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAm-0007Jn-AX for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:40 -0400 Received: by mail-wr1-x432.google.com with SMTP id e4-v6so3839506wrs.0 for ; Tue, 02 Oct 2018 14:25:40 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i1wsv4z/D63Im8V1DO2rPV2/SBFrRH2FLSR5Eqk5QSM=; b=eYdhIq5S0G+D7L8OQumZtpXan1LtuzfqG4Dp6DJTtEuwS0n/Ql/iqVtrg7yy8wQ4Ea gdmzRmmBRF9HnB5NeosY9mgCHeDVfk47BezBw8Km8tb5iuzTyZOlKC7Lk+dtnKwuN+Wq AK0G7hBEQDNV4DXyGRFrcQtHromJaTfo3mqJFo2KPlEWGZLzQumKZZ9UKbJVQ5KjyUV9 Ll3s8ejFglZeIUyHN9pY/xThGNeDjdjI5hjPYpIlM5I+Qmyd91O36XbR/162Q67WNlji UOlrBdkXbYK9vi1NyPAR05ZXLbV5tj+5BZzU+nye5NuMzc93Cepgc/uavhdnfWhH9zBx pBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=i1wsv4z/D63Im8V1DO2rPV2/SBFrRH2FLSR5Eqk5QSM=; b=rNPlK5Sh6bg3fm/TDkrli2sojrJj5qg02GtxwF7xxiwrzx+3Il9acRxz67w14MFKLx WABkwBs4a4hMn7TjklM4WHoPNUprmVDnFUMnrf2047Z/4Yfy9S+jdELUy6vxjMCPZOHN QBs8JycdSKy1zGDGHQvTSv73qOTOJwD/En9/3H2Y91urolToQx5th63B89UDpdjxY5bE b1z5Qb9TRL1vz/mR7YLH3ynBWXz7DMVTWdCLyU7H5nS8hEVpx6QTooFh7bP0PYxq03HI aLe/zVih3pzcaPvTxAMIpPrqcjXCvlkDWDofvdEO5rWY8QPLDHOMfL35vdhNOVDGZmi6 CSjw== X-Gm-Message-State: ABuFfogM7K4+kDWZ2L7SZ1pKC6n49FkBcY0BsA6rs3n5eK3r+UXy1v7A pNGvENjjZA1s3eHoiKe68zE= X-Google-Smtp-Source: ACcGV63pDSmoMmQ/P0iZiElbQO3BtxtisGsAqLHDbxQsG0t7R2klcSee22Zjzddi3tmDfd0Z+1gN6g== X-Received: by 2002:a5d:6551:: with SMTP id z17-v6mr11429551wrv.194.1538515539366; Tue, 02 Oct 2018 14:25:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:13 +0200 Message-Id: <20181002212522.23303-5-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 Subject: [Qemu-devel] [PATCH v2 04/12] hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Move from the legacy SysBusDevice::init method to using DeviceState::realiz= e. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: C=C3=A9dric Le Goater --- hw/ssi/xilinx_spi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c index 83585bc8b2..3dae303d5b 100644 --- a/hw/ssi/xilinx_spi.c +++ b/hw/ssi/xilinx_spi.c @@ -319,9 +319,9 @@ static const MemoryRegionOps spi_ops =3D { } }; =20 -static int xilinx_spi_init(SysBusDevice *sbd) +static void xilinx_spi_realize(DeviceState *dev, Error **errp) { - DeviceState *dev =3D DEVICE(sbd); + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); XilinxSPI *s =3D XILINX_SPI(dev); int i; =20 @@ -344,8 +344,6 @@ static int xilinx_spi_init(SysBusDevice *sbd) =20 fifo8_create(&s->tx_fifo, FIFO_CAPACITY); fifo8_create(&s->rx_fifo, FIFO_CAPACITY); - - return 0; } =20 static const VMStateDescription vmstate_xilinx_spi =3D { @@ -368,9 +366,8 @@ static Property xilinx_spi_properties[] =3D { static void xilinx_spi_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); =20 - k->init =3D xilinx_spi_init; + dc->realize =3D xilinx_spi_realize; dc->reset =3D xlx_spi_reset; dc->props =3D xilinx_spi_properties; dc->vmsd =3D &vmstate_xilinx_spi; --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515854604388.07134114678695; Tue, 2 Oct 2018 14:30:54 -0700 (PDT) Received: from localhost ([::1]:45753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SFl-0007xB-Nd for importer@patchew.org; Tue, 02 Oct 2018 17:30:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAo-0003Pa-Jz for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAn-0007LT-Sj for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:42 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:36602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAn-0007Kn-It for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:41 -0400 Received: by mail-wr1-x441.google.com with SMTP id y16so3820699wrw.3 for ; Tue, 02 Oct 2018 14:25:41 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XallOcscdPrTNQ3jGyzEOuK1NV0npjiR5+p4e1jVi4w=; b=GvVSybQXqnH0yKYpmzRl18xzzTjmDeXYldrCTbpp9IO1is8k/hWN7VNwqVaZHrmO82 KMe+XKTuYICxK3KmF4JETN2+oKNwVBW/+HerI+rA8M4V/W0CGqsqIbiRdB2KilB6wM3J J6utxPE9UlPV4iHWUXODlXDYyFOMbJ2bkX5b3PSr4/ck4TPjOWAXjtKpE949IxVVVDbu JuaFnfgLaFO1PN25R6MIPvYUeJovmX47l4W2C0Xm2ANoeDFOfNPiW3NIJXtsYc4+pT00 OzH8xGu6lqMAbkxTqeaf8lb1QQ/3WdUJW43FbX/i4kEy1tXHdBQaZFO+20y6Wn72nYwG 5cew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XallOcscdPrTNQ3jGyzEOuK1NV0npjiR5+p4e1jVi4w=; b=hARsaB1kO0sreN9GWSufmGTOxdrfj6Kz6SOxBeo9a++11jjN4sFxKU0Qoj7yOH4k0Q ESAkG3yBjYuxCvb81BenfzvD5oWk3H8F1WV/MSFJRqKZIjMaj/ZB3i/2rC3+H7dtDSXg 9m/kWhC0CeQ+RDHoGBoDsRx5DlmonB7ApwxMwtpJWpzeM69/sGyx/XcsKEpk7pX0KKS9 X3GJEOYOBns8GR5utgmwIWHpZmK0lCtHqqwhhcOYPB0niMEIq5gqMo5IVpWotXxr+Qxn 3rtuvBY1W+539nE6SyJu42E54A1b6+mGXyhvIl1i8l4TB+IfJIKRAaLO25FcW8Ojtw/n FjMw== X-Gm-Message-State: ABuFfoi9XOZHH+/VC2EQybMM9fEQEDssROU/p3ypqrAxflclNlm62N7u rxylx7W89tkoJnlt50JGjCmbq8ol X-Google-Smtp-Source: ACcGV60S4P9cuGaAE2YTj4xKAQI6cS7UqLmzUZq+3Io7kuG9ti0loBnKUnSo/nXNr767IDTAaMb9Xw== X-Received: by 2002:adf:aa90:: with SMTP id h16-v6mr11371831wrc.216.1538515540526; Tue, 02 Oct 2018 14:25:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:14 +0200 Message-Id: <20181002212522.23303-6-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v2 05/12] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Move from the legacy SysBusDevice::init method to using DeviceState::realiz= e. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/sh4/sh_pci.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index 4ec2e35500..379d0685ed 100644 --- a/hw/sh4/sh_pci.c +++ b/hw/sh4/sh_pci.c @@ -120,16 +120,15 @@ static void sh_pci_set_irq(void *opaque, int irq_num,= int level) qemu_set_irq(pic[irq_num], level); } =20 -static int sh_pci_device_init(SysBusDevice *dev) +static void sh_pci_device_realize(DeviceState *dev, Error **errp) { - PCIHostState *phb; - SHPCIState *s; + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + SHPCIState *s =3D SH_PCI_HOST_BRIDGE(dev); + PCIHostState *phb =3D PCI_HOST_BRIDGE(s); int i; =20 - s =3D SH_PCI_HOST_BRIDGE(dev); - phb =3D PCI_HOST_BRIDGE(s); for (i =3D 0; i < 4; i++) { - sysbus_init_irq(dev, &s->irq[i]); + sysbus_init_irq(sbd, &s->irq[i]); } phb->bus =3D pci_register_root_bus(DEVICE(dev), "pci", sh_pci_set_irq, sh_pci_map_irq, @@ -143,13 +142,12 @@ static int sh_pci_device_init(SysBusDevice *dev) &s->memconfig_p4, 0, 0x224); memory_region_init_alias(&s->isa, OBJECT(s), "sh_pci.isa", get_system_io(), 0, 0x40000); - sysbus_init_mmio(dev, &s->memconfig_p4); - sysbus_init_mmio(dev, &s->memconfig_a7); + sysbus_init_mmio(sbd, &s->memconfig_p4); + sysbus_init_mmio(sbd, &s->memconfig_a7); s->iobr =3D 0xfe240000; memory_region_add_subregion(get_system_memory(), s->iobr, &s->isa); =20 s->dev =3D pci_create_simple(phb->bus, PCI_DEVFN(0, 0), "sh_pci_host"); - return 0; } =20 static void sh_pci_host_realize(PCIDevice *d, Error **errp) @@ -187,9 +185,9 @@ static const TypeInfo sh_pci_host_info =3D { =20 static void sh_pci_device_class_init(ObjectClass *klass, void *data) { - SysBusDeviceClass *sdc =3D SYS_BUS_DEVICE_CLASS(klass); + DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - sdc->init =3D sh_pci_device_init; + dc->realize =3D sh_pci_device_realize; } =20 static const TypeInfo sh_pci_device_info =3D { --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515858438248.9225346041644; Tue, 2 Oct 2018 14:30:58 -0700 (PDT) Received: from localhost ([::1]:45752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SFk-0007vu-7J for importer@patchew.org; Tue, 02 Oct 2018 17:30:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAp-0003Qx-QJ for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAp-0007MD-2p for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:43 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:46780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAo-0007Lm-RS for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:43 -0400 Received: by mail-wr1-x442.google.com with SMTP id z3-v6so3783878wrr.13 for ; Tue, 02 Oct 2018 14:25:42 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KfwV5kY5U4jKpnJYxMh1tnfkf2FWhzr21nNue8x74xo=; b=FGC+dX6u+Y8euasFXCNpkCPufj7jlrC4BqAoeCnBuxZXzdykPZOqLdSGqAPIM8CoaV XneShftDvB5J1zAKgKL9Iflk3SrYbpGrvMr3Uhk6ZJQ+NGGNbDa2t16qC7i+7BKwhotn eh5wCDPzHnmyIUbIZn45JA/YszQtIIwnksZZ0rS0A5QQ2pnJivpC/31nSVUFWSmt62mk CSgBOuO7dlPXCU6WYfRVEhSvaeVEg9rkOnJm6bx7d0QPuA4K9/F36C4YhrcAI/zoeU6v IDn0j6ONk/AVltaiC3OxHv0lKpc9+eRtpFzNgs9y62HJ8309EdwTrZl4CzjI4X0FdNuv BxmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KfwV5kY5U4jKpnJYxMh1tnfkf2FWhzr21nNue8x74xo=; b=ZnwMPcwlJC5HK+uvDBFo7VWUo2lmdA2MZmY0E7v/4uKDw5om/tLUCtdRMVkjoqjmmm wZqH1bmUcfcpNpGnCdY57s1JD1JVB08wOehVAMvM9gUfLoLnwLpV5eYwyXBC9/XkBRLL qvWR7F8fj0V99ZqGzRHkxLp4wtvsedPpjfxM1k4SaWXQgpQ/A4zzR/Kvx+W9JYCkIl4v sTRGzF6tfjTPvvHbbxqX/9BKOuODVPjCYMUDy5sMJ6MomjRMKRptijniOsPn6DSfZwny gDTSbP94mVJmDD4gtj2pqmxAvo0Cq9tRY+jjX0PNc2P+G/0MrzD59TOpX99YGj6CGgBi gxLw== X-Gm-Message-State: ABuFfojwnrN4AoCCF0GyjYpysJQwK0am2WjPNIjjsgAkQcun+l4b9lhN FVYHnYVb9b/bGV3uo709t5o= X-Google-Smtp-Source: ACcGV60gNEohc50OtHebi862kqTbXMhjXaLUBNpdUUzehC1r5Xku+oSsA7iOxhgzJYLN8SfiDMqDLQ== X-Received: by 2002:a05:6000:100f:: with SMTP id a15mr12021009wrx.271.1538515541763; Tue, 02 Oct 2018 14:25:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:15 +0200 Message-Id: <20181002212522.23303-7-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v2 06/12] hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Move from the legacy SysBusDevice::init method to using DeviceState::realiz= e. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/pci-host/bonito.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 9868e2eccc..9f33582706 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -595,7 +595,7 @@ static const VMStateDescription vmstate_bonito =3D { } }; =20 -static int bonito_pcihost_initfn(SysBusDevice *dev) +static void bonito_pcihost_realize(DeviceState *dev, Error **errp) { PCIHostState *phb =3D PCI_HOST_BRIDGE(dev); =20 @@ -603,8 +603,6 @@ static int bonito_pcihost_initfn(SysBusDevice *dev) pci_bonito_set_irq, pci_bonito_map_ir= q, dev, get_system_memory(), get_system_= io(), 0x28, 32, TYPE_PCI_BUS); - - return 0; } =20 static void bonito_realize(PCIDevice *dev, Error **errp) @@ -684,7 +682,6 @@ PCIBus *bonito_init(qemu_irq *pic) pcihost->pic =3D pic; qdev_init_nofail(dev); =20 - /* set the pcihost pointer before bonito_initfn is called */ d =3D pci_create(phb->bus, PCI_DEVFN(0, 0), TYPE_PCI_BONITO); s =3D PCI_BONITO(d); s->pcihost =3D pcihost; @@ -726,9 +723,9 @@ static const TypeInfo bonito_info =3D { =20 static void bonito_pcihost_class_init(ObjectClass *klass, void *data) { - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); + DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - k->init =3D bonito_pcihost_initfn; + dc->realize =3D bonito_pcihost_realize; } =20 static const TypeInfo bonito_pcihost_info =3D { --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538516066874306.45126462903306; Tue, 2 Oct 2018 14:34:26 -0700 (PDT) Received: from localhost ([::1]:45767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SJF-0002uU-Lw for importer@patchew.org; Tue, 02 Oct 2018 17:34:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAq-0003S9-VD for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAq-0007Mp-84 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:44 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:42211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAq-0007MP-15 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:44 -0400 Received: by mail-wr1-x435.google.com with SMTP id g15-v6so1189757wru.9 for ; Tue, 02 Oct 2018 14:25:43 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gbXPgyjmss7NWQb7etZsAtB7A4DkP3daG7TEKc0J5WQ=; b=toXPivUj6KbjMI7Rf+xvoBKl2Ne6OizKDfnTTBkQvSlzQSWdUKXxQ4cY9/ZA22NnIf e/+eL/552WPLWs7EmA6SC/o9Q/LdMJhWanLST0uX8KnH/Ejj5xonNETKsGqTBFlT7txc UW1Re2iYRoGxucaLur6Il6AjgFhm0XGmz05HyTsqLSGG/l6lA/A8ElMXc+QE2EF0jxpA TVNfSVAOVuV87bQfQi99qT+HWzVIHrfNYfUC+095J2/xs6UO7iDfNS5oblkLdK+ti+/D NYHy33E3EtYQkIbWyPyO26BBXFtgj89pZawsXzlAhbicWeKOc9g4o1EMOHCCbcVGLZvY KMhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gbXPgyjmss7NWQb7etZsAtB7A4DkP3daG7TEKc0J5WQ=; b=fXXkvolpqJYBeDNbRUdAGhKgBnTOce9I/JCe2rBYXPojw3/e3XupXTk6+6CO3DTIE7 3CpgHene7ROc21GZA7AlnC4ITccBa3idSjlcV6Hg9E7wVmZGPEWseZPxaigiT7zCDKBL 86F4njXFK378KHTxRIevnFw6d6FdAClJlgV2pGrWP6lHsLrk1rgDGVjpSEre3VZhy1Am 6jephAQqCroi67HAIDxufsOwDyzm+lT7CBKuDN3MrxTEHM8hyl5R7yh328SEGKoISsop GZ1qPtOAFf18LAzHQayvFJ8ilUyEBWLC67f25Tyyx2N47YpOpwnQ5kxdWgnQJh1o1otK TqmA== X-Gm-Message-State: ABuFfohN8lP02ob/X3fdgRpq6FWHd2XMKq0QI9BfVSpuTi9iUSDAEEJg 6qFXXqiFnU0UPeb8NlEbi+4= X-Google-Smtp-Source: ACcGV62MwF4EsXNzifcj0Aa6T27ey7eovZldIrW1IjBqpUh7uc/M1VOwJKkMb7v//VMdwzw4bJ1HQw== X-Received: by 2002:adf:ecc9:: with SMTP id s9-v6mr9079021wro.142.1538515542992; Tue, 02 Oct 2018 14:25:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:16 +0200 Message-Id: <20181002212522.23303-8-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 Subject: [Qemu-devel] [PATCH v2 07/12] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Convert the gt64120_reset() function into a proper Device reset method. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: C=C3=A9dric Le Goater --- hw/mips/gt64xxx_pci.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 24ad0ad024..dcd1a66329 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -992,9 +992,9 @@ static void gt64120_pci_set_irq(void *opaque, int irq_n= um, int level) } =20 =20 -static void gt64120_reset(void *opaque) +static void gt64120_reset(DeviceState *dev) { - GT64120State *s =3D opaque; + GT64120State *s =3D GT64120_PCI_HOST_BRIDGE(dev); =20 /* FIXME: Malta specific hw assumptions ahead */ =20 @@ -1184,16 +1184,6 @@ PCIBus *gt64120_register(qemu_irq *pic) return phb->bus; } =20 -static int gt64120_init(SysBusDevice *dev) -{ - GT64120State *s; - - s =3D GT64120_PCI_HOST_BRIDGE(dev); - - qemu_register_reset(gt64120_reset, s); - return 0; -} - static void gt64120_pci_realize(PCIDevice *d, Error **errp) { /* FIXME: Malta specific hw assumptions ahead */ @@ -1241,9 +1231,8 @@ static const TypeInfo gt64120_pci_info =3D { static void gt64120_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); - SysBusDeviceClass *sdc =3D SYS_BUS_DEVICE_CLASS(klass); =20 - sdc->init =3D gt64120_init; + dc->reset =3D gt64120_reset; dc->vmsd =3D &vmstate_gt64120; } =20 --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538515930378313.70684190532154; Tue, 2 Oct 2018 14:32:10 -0700 (PDT) Received: from localhost ([::1]:45757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SH3-0000R3-4K for importer@patchew.org; Tue, 02 Oct 2018 17:32:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAs-0003Ts-EH for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAr-0007NM-Ot for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:46 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:50878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAr-0007Mw-Gx for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:45 -0400 Received: by mail-wm1-x329.google.com with SMTP id s12-v6so3684621wmc.0 for ; Tue, 02 Oct 2018 14:25:45 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/VpIDpsOMI7GhvSGq2MwLnEVtCaBE+hzO3HT13hlwTg=; b=W0tLWSH08sp1SZgDfHmMlg8m8FZTLv65JIqcoMAXIYx0S5zDajq0UpXQ9Pejd+4cW5 azba4t3QZOD7bgpmZdtwFIBSWNpqPekHrBi/Sv7LrnavvyVXiE8rMfHY2gEyZHQ0v19s iCAfD+taXFu4t7dU9l+JQZ47RPiabgiwTQqZ/+CAbCyhuHjWaS4fhJVmiuoZvGpgPIOo rF5+CqGwPY4kcCiTjXAdkRh6l9oxHPB6mjQH0XD+6gdRH/+Tzg77DnKw4YbPgounTMFa fAJg6dhin1Nd4KyhNCkj3h6WantiKxPPRRHf/2Sehp07psdID/HHu7rwWaRlBK/9fqho 3N9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/VpIDpsOMI7GhvSGq2MwLnEVtCaBE+hzO3HT13hlwTg=; b=ZtRHfwB0t0wV+e6NHDITnQTB8BjQFMh0hrKULnudi1wzVSdWYiS5ZFe4fKJChXc096 B2gk93/wk/1HCdbR6gNBgMA8I3M3SfoIpj3uuGZWVwZz5z7gwV5D7+XXRh4H5uX+s8im unNPFQqib04H1QAXfnkgOASjnUk7oD6CaI+8kAW2fujP50lxKe1YgysLB4d3ILNm4OdR UIFDh7EjsTXWfQmnpJGxxfD26Tc1AFCjGFQCHiiXU2PjTxeCyp1HbKOtajFcqqbN2BEz 7xNKG82G7SzsqV+KGWwndsjXZQtKoSV8w/lbpR7G36YMSpvrOHfCA6AF8h3G3z0B/SHb NfzQ== X-Gm-Message-State: ABuFfoih18t+G9kj7iZqOSiQx0jElSmsnbScyayISogarYN5TcJRE48e m0B3YyycBVFe7H0C5N5eowmPPyQZ X-Google-Smtp-Source: ACcGV63gNtu69qn3x3hEThRt+ITKO/n5tuKGX6DO7GKp7+Wx8/unmx3PAPquVJcHa/oAiy/r0KQ8pw== X-Received: by 2002:a1c:c4f:: with SMTP id 76-v6mr3030725wmm.6.1538515544523; Tue, 02 Oct 2018 14:25:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:17 +0200 Message-Id: <20181002212522.23303-9-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 Subject: [Qemu-devel] [PATCH v2 08/12] hw/mips/gt64xxx_pci: Mark as bridge device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 The gt64120 is currently listed as uncategorized device. Mark it as bridge device. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: C=C3=A9dric Le Goater --- hw/mips/gt64xxx_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index dcd1a66329..1cd8aac658 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -1232,6 +1232,7 @@ static void gt64120_class_init(ObjectClass *klass, vo= id *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); =20 + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->reset =3D gt64120_reset; dc->vmsd =3D &vmstate_gt64120; } --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538516135645412.27704391722625; Tue, 2 Oct 2018 14:35:35 -0700 (PDT) Received: from localhost ([::1]:45769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SKM-0003md-F8 for importer@patchew.org; Tue, 02 Oct 2018 17:35:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAx-0003Yf-H8 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAt-0007Nt-2H for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:51 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAs-0007NU-R3 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:46 -0400 Received: by mail-wm1-x329.google.com with SMTP id r63-v6so3674716wma.4 for ; Tue, 02 Oct 2018 14:25:46 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LPcEZCVgVGv7wnY7fV/HihgkucYstUS0i4zFZoBHJwY=; b=eGWHE09tnBiKnhxz+2o83Ne781IONORq3mgDWMyLsU8xoJBZM9TEE2jExjiNREZNq/ hyVSqUu7Znod37CLzLihnNR9rOJLSpLcdjwX+1yfQO6Q6Ux8XYAvZhHvHo6DAuIBW9Km MUUWkvjpOBD0h4PhiqW0sO4Muo/gkVCFYLmQjGIMm2r0TazwPnx5fZ4GNyJ2aZALe3ow yQV7tJB2sNNa6dopf/+KTs3cHyOkPe2N9Uf1QVDTTaG0N4eF/xCClD3zmFoOaMBJRglc cTZfuT+FUUjhiav1GlVoKKqx7nb/JZPMhQZ0a64rGzNml7YIGRKrNLHpc9UF5ZboTfmc +w5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LPcEZCVgVGv7wnY7fV/HihgkucYstUS0i4zFZoBHJwY=; b=LzoalaUGSUbwLNGllV4WHBNSl1eKioSdXXTG3GBWWYzsT+bexyJWm77bV2EIUESdMh O7wLaePiovYt4GK8gLgfs6i+p46Ch78ea9vEsaZ5KiuGYoLjLyJkosMqAWT0pjXMPlF/ xTOs4bQGi7/dDdkrnIIrBwvPA2uBHaesUvALtb9Se23PI1F6dBs17JTkpc+b/asw0zfG RyEoiWvHWCKGu+uOknGy/ixdMi2Ycl6mWGrdYPjYPH9YC6wwXxMCf7f8aEDVy/fxGK7z Wlj1T6G2suH7mSZKtppt4b08db2Sclowl9LU9dbNAHLqfQJ+7rFpe6N7dAIrAX3nmsb/ 2iwQ== X-Gm-Message-State: ABuFfohJa3p8OIyWEBi77N8rorLJ7AMXEBPLLIn5y6I27ZcL26x+ZZDU omAj04L/5KObOYnMuO3ypjQ= X-Google-Smtp-Source: ACcGV61B1PDxEv1JNHULkJAtxrm/uHqPLRBl/Se1sy+NsKf9tO0zBR2zN1eHcn3A7OEO0q0GtWFJog== X-Received: by 2002:a1c:5e08:: with SMTP id s8-v6mr3201157wmb.88.1538515545853; Tue, 02 Oct 2018 14:25:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:18 +0200 Message-Id: <20181002212522.23303-10-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 Subject: [Qemu-devel] [PATCH v2 09/12] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Artyom Tarasenko , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Since the I/O Bridge device is not implemented, Use the TYPE_UNIMPLEMENTED_DEVICE which suits better: if the user asks for 'unimp' warnings via the -d option then all accesses will generate logging. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Artyom Tarasenko --- default-configs/sparc64-softmmu.mak | 1 - hw/sparc64/niagara.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/default-configs/sparc64-softmmu.mak b/default-configs/sparc64-= softmmu.mak index 52edafe547..ce63d47046 100644 --- a/default-configs/sparc64-softmmu.mak +++ b/default-configs/sparc64-softmmu.mak @@ -16,5 +16,4 @@ CONFIG_SIMBA=3Dy CONFIG_SUNHME=3Dy CONFIG_MC146818RTC=3Dy CONFIG_ISA_TESTDEV=3Dy -CONFIG_EMPTY_SLOT=3Dy CONFIG_SUN4V_RTC=3Dy diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c index 4fa8cb2904..f8a856f611 100644 --- a/hw/sparc64/niagara.c +++ b/hw/sparc64/niagara.c @@ -29,7 +29,7 @@ #include "hw/hw.h" #include "hw/boards.h" #include "hw/char/serial.h" -#include "hw/empty_slot.h" +#include "hw/misc/unimp.h" #include "hw/loader.h" #include "hw/sparc/sparc64.h" #include "hw/timer/sun4v-rtc.h" @@ -161,7 +161,7 @@ static void niagara_init(MachineState *machine) serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200, serial_hd(0), DEVICE_BIG_ENDIAN); } - empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE); + create_unimplemented_device("sun4v-iob", NIAGARA_IOBBASE, NIAGARA_IOBS= IZE); sun4v_rtc_init(NIAGARA_RTC_BASE); } =20 --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538516067552103.08008621100385; Tue, 2 Oct 2018 14:34:27 -0700 (PDT) Received: from localhost ([::1]:45768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SJG-0002v5-67 for importer@patchew.org; Tue, 02 Oct 2018 17:34:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAx-0003Ya-GQ for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAv-0007OH-5h for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:51 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:34358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAu-0007O0-E4 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:48 -0400 Received: by mail-wm1-x343.google.com with SMTP id z25-v6so6242889wmf.1 for ; Tue, 02 Oct 2018 14:25:48 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=of1E+/Yh5KoQ6/HRKr187CKSc3lMWtv7HYhrXAY+6rE=; b=SQebIzxV7O2QueZkh55VVOncgcQByy0I2IW6+cTmEC1s5CS/7bmXwnJjuCodoCXZzI Ep1ppT9SaP8WIQhZAnDud565Cf2+BRSjiutcXXf07stVmtnr2xgj8icrA+mcyZo5duM8 6NH3THfizUfbuHUrRQu/W1oVNi6UzF3CIhwJ2TlJMQ3pNRf/LCNSIR76O3WSjESPoRxN qxh6XfQ68auEuTqS6h3GPdWzbYYl1ghXntlUsqkFB0zt9ICAF1fYoy2uGx2uw4RYAOpq 4rngd4LXAhPVRlgXSN1342aLjV9br3VTAkzRRZoXexg37QpMEHk6lXX1UozBVMhyIVLe 80hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=of1E+/Yh5KoQ6/HRKr187CKSc3lMWtv7HYhrXAY+6rE=; b=c2AV58sZhzqrXTpRJQTyqZ3j9IQHiYA/LyD78dS7xXCLAxHYYbiEutqDY0UqG7B8Ix v2oV7cAgrNmeoAVBI63LWKleMidUJlEsNm7nH8ZgfdpjYr8sQTqViOe9XJTo6T93XGBc T9n1vgf1yxRoelEWim9pSBRh3MXvj8vui8omo3kO9hehmo82s79cP9FQuwzxa15tc4BS cqgJcY5w30LtBk/dFjxgnC8KC/4twfrV0VgMD54FwuI/fTJnBXyeGqr5f0NoyRdzIbFO ZniDuJWhJYRbVxSBNw4Ik2pLUmBT3GO1YutWGX6PYUnXsRaRuOmbFNNPDDtY5AQfXboV q8FA== X-Gm-Message-State: ABuFfoiPM9nlUDG7zTmSic2cGsdH+YDJPVInbFD5+dgC1Al3hFblT1Is /xPkhN37+ep2Ll5b7H6zgVY= X-Google-Smtp-Source: ACcGV619kJy/jCuBlk0DJkWkKSasP2Uo0ZVi6YSRq0TLOrtUmcPkjQgdoLEH4JS4dyyZCxUVIFwW4w== X-Received: by 2002:a1c:7816:: with SMTP id t22-v6mr1867016wmc.46.1538515547392; Tue, 02 Oct 2018 14:25:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:19 +0200 Message-Id: <20181002212522.23303-11-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v2 10/12] hw/alpha/typhoon: Remove unuseful code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/alpha/typhoon.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index d74b5b55e1..8004afe45b 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -932,23 +932,10 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **is= a_bus, return b; } =20 -static int typhoon_pcihost_init(SysBusDevice *dev) -{ - return 0; -} - -static void typhoon_pcihost_class_init(ObjectClass *klass, void *data) -{ - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); - - k->init =3D typhoon_pcihost_init; -} - static const TypeInfo typhoon_pcihost_info =3D { .name =3D TYPE_TYPHOON_PCI_HOST_BRIDGE, .parent =3D TYPE_PCI_HOST_BRIDGE, .instance_size =3D sizeof(TyphoonState), - .class_init =3D typhoon_pcihost_class_init, }; =20 static void typhoon_iommu_memory_region_class_init(ObjectClass *klass, --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538516066187733.3666301761632; Tue, 2 Oct 2018 14:34:26 -0700 (PDT) Received: from localhost ([::1]:45766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SJE-0002tT-Uq for importer@patchew.org; Tue, 02 Oct 2018 17:34:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAx-0003Ye-H3 for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAv-0007OW-Sz for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:51 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAv-0007OC-MF for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:49 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 189-v6so3688568wmw.2 for ; Tue, 02 Oct 2018 14:25:49 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D8DPJGwHTi1OIatdTDaMGRovETCKfGT3ZxW38shO8LM=; b=ejG0hl9Hm85Lf8FFN6a3YfhcEGLNm2UpAAgS8u2dyItOxuNKJcopU41aQZHluIiDvZ I5NhA92QbC8jf+38gYdRGAP27bk9of0gj15GjvDDK9i0KP9IBZQdLQHuCK+KMT0JkU9Z SdcOwCUUl6Twlak/f8gohvnfSDqJ64kMeMXGvVO6FbYbrkOQigqYcTbTbk1tXB0iXx6f Rsal4EQm3OConQggsjfvwHrKEI1q6DziuxhsynLGrbgYREYHTickVC64opDGHgVPMoDd DzXM9wZkUZryZ1k1BawKnQtJgcxndvTmyvwsJ0nIQ8e4pyWHDHkhOsin+Xt8aQlumD2W nKXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=D8DPJGwHTi1OIatdTDaMGRovETCKfGT3ZxW38shO8LM=; b=qV15shBC1gdpRbn+XAPdqtlFUzBDi4CD7Z8zhDNlIdEyls2/pX/ZfuGyls7OJOgnu9 u51PTbdiHw4Rfw1etLDC5pKLqyAR0CNMTKaJ2mjSyLqDWEzU5pu04EBVM2xI6R+0zqIW NmmE12RJNkyutWR0zioPq3J/30IQqddaRGAjdQvipaDPwZWeR/UT3cLNOIHKFlQ1+7gk yKaWFb7VYo60rJTv+TcamqYUHSUjAcMP977b3KolbZIXAUIkbKySAzWT/WxsfuOZ6PTo ETPVYPYogIxZT396s+pYvYqjwEUjWhdTt6JSwsk/P5kzA5tDwdXpjGmIy/xhUAvLSk4j wrXA== X-Gm-Message-State: ABuFfogthm8VgmxAd3hjHTzFCPFgpyeaqZPn4/hTMZOcwUJRGCySS1fv DQu15xoD+JLl4YYHgWyg1r0= X-Google-Smtp-Source: ACcGV63SQiCyeAvAj8UNc80b+RQJA3oEIrlImwd09xSVgidLIiouCXIIDPqN7NwJEXOTSGcRW0+59g== X-Received: by 2002:a1c:32ca:: with SMTP id y193-v6mr2984255wmy.29.1538515548630; Tue, 02 Oct 2018 14:25:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:20 +0200 Message-Id: <20181002212522.23303-12-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PATCH v2 11/12] hw/hppa/dino: Remove unuseful code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/hppa/dino.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 564b938e3a..31e09942b5 100644 --- a/hw/hppa/dino.c +++ b/hw/hppa/dino.c @@ -488,17 +488,10 @@ PCIBus *dino_init(MemoryRegion *addr_space, return b; } =20 -static int dino_pcihost_init(SysBusDevice *dev) -{ - return 0; -} - static void dino_pcihost_class_init(ObjectClass *klass, void *data) { - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - k->init =3D dino_pcihost_init; dc->vmsd =3D &vmstate_dino; } =20 --=20 2.19.0 From nobody Sun Apr 28 23:58:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538516319464201.66549180432855; Tue, 2 Oct 2018 14:38:39 -0700 (PDT) Received: from localhost ([::1]:45793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SNK-0006Od-B3 for importer@patchew.org; Tue, 02 Oct 2018 17:38:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7SAz-0003aF-0z for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7SAx-0007Ou-2g for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:52 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:53865) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7SAw-0007Oh-QT for qemu-devel@nongnu.org; Tue, 02 Oct 2018 17:25:51 -0400 Received: by mail-wm1-x334.google.com with SMTP id b19-v6so3678050wme.3 for ; Tue, 02 Oct 2018 14:25:50 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id g15-v6sm7567516wrp.56.2018.10.02.14.25.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 14:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SU2PcsHMgZ5J8xXw8yEj5u+LSSk5D7Bps0jYWPcakho=; b=Z/Hd7fUo8X+jSTHt3hXwHh73T9BKAD8lDjySeoofILzx1/1VGT1sWc8TPme6bQ3r1J 2qc3w3xQpIiYpJY4gp1I2zizvFYqnHbHTu01HqfvZyfnGQF2cVVK7GCj9CRJ2jb49dW9 L6La1QBGdpSjaiSvBGDpjUk6rC0xfaaOh7NXHS6BjtxRhC1EnOHxwTQgg7WNOk/K3xLg 3TkAOEMQfd/An0ZifS1L8vjhp+9KbJ8jh/Q+jfyH3rVYAssZS5w3rM5MA2sXQxi6/yDn yvBbF0fqkZ3mgV/HTFPfGd+ufb1ZI8qf6X3wZwYV/DqCsmYtLGpW3iwnRK3GTdVBYsDL WcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SU2PcsHMgZ5J8xXw8yEj5u+LSSk5D7Bps0jYWPcakho=; b=X8yqLNuGIj7zA7QCCEgFMPAjHXia7B3mI3lO7hdydhqv9k/zik7iliIvIg+WBZZRDp qpm8WZVTUQCPNCAm+yg/ZFJA5y6AJ4JTMfNXJxmEhrb1/UBIgApKmVwyN9Uuxz2zghJf QF67kWde3lOI7Fsnx37mFkAPAdowsSw8bVL5CwlEvFGpLq2011F8kQa5ltYnxzKZXzFK /eAyIgLOiMpIUCCQT3Lh2oIaKABToVkwOLaDAkmM3xhscKJ5TUDaps+rouuoiot3TupC oSQxa/fpi80nGMDEV2Jrb7uFEDrFg/Kfwz+AL9SU+kPOdvAEn6jEUjNT4d7O/Km5Il4D 73bQ== X-Gm-Message-State: ABuFfogOL8A6uGOO8IcVEr0fd6+8KYkXvfwewKxCvzF9KMdMV81mv1yS SwN0YfA5HoRYPPGmbln6XMA= X-Google-Smtp-Source: ACcGV617TQiN47yEQiNR591WEkAtH1woaNBuMjEFpHjariIVeqPpp8RY1sNvUB2TlpRUP3WIQ/Ldjw== X-Received: by 2002:a1c:ed4:: with SMTP id 203-v6mr2835656wmo.96.1538515549875; Tue, 02 Oct 2018 14:25:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 2 Oct 2018 23:25:21 +0200 Message-Id: <20181002212522.23303-13-f4bug@amsat.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002212522.23303-1-f4bug@amsat.org> References: <20181002212522.23303-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::334 Subject: [Qemu-devel] [PATCH v2 12/12] hw/mips/malta: Remove unuseful code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/mips/mips_malta.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 40041d5ec0..89ca6db94b 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -1422,23 +1422,10 @@ void mips_malta_init(MachineState *machine) pci_vga_init(pci_bus); } =20 -static int mips_malta_sysbus_device_init(SysBusDevice *sysbusdev) -{ - return 0; -} - -static void mips_malta_class_init(ObjectClass *klass, void *data) -{ - SysBusDeviceClass *k =3D SYS_BUS_DEVICE_CLASS(klass); - - k->init =3D mips_malta_sysbus_device_init; -} - static const TypeInfo mips_malta_device =3D { .name =3D TYPE_MIPS_MALTA, .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(MaltaState), - .class_init =3D mips_malta_class_init, }; =20 static void mips_malta_machine_init(MachineClass *mc) --=20 2.19.0