From nobody Mon May 6 18:41:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153849267501789.83097021187325; Tue, 2 Oct 2018 08:04:35 -0700 (PDT) Received: from localhost ([::1]:44184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7MDx-0000PC-U4 for importer@patchew.org; Tue, 02 Oct 2018 11:04:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7MCq-0008HF-Uv for qemu-devel@nongnu.org; Tue, 02 Oct 2018 11:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7MCq-0004AW-3E for qemu-devel@nongnu.org; Tue, 02 Oct 2018 11:03:24 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:51540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g7MCc-00043P-Ve; Tue, 02 Oct 2018 11:03:11 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1g7MCZ-0007DG-Dh; Tue, 02 Oct 2018 16:03:07 +0100 From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 2 Oct 2018 16:03:04 +0100 Message-Id: <20181002150304.2287-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH] target/arm: Don't read r4 from v8M exception stackframe twice X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" A cut-and-paste error meant we were reading r4 from the v8M callee-saves exception stack frame twice. This is harmless since it just meant we did two memory accesses to the same location, but it's unnecessary. Delete it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 073fb3c5cb0..5e721a65272 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -7303,7 +7303,6 @@ static void do_v7m_exception_exit(ARMCPU *cpu) } =20 pop_ok =3D pop_ok && - v7m_stack_read(cpu, &env->regs[4], frameptr + 0x8, mmu_idx= ) && v7m_stack_read(cpu, &env->regs[4], frameptr + 0x8, mmu_idx= ) && v7m_stack_read(cpu, &env->regs[5], frameptr + 0xc, mmu_idx= ) && v7m_stack_read(cpu, &env->regs[6], frameptr + 0x10, mmu_id= x) && --=20 2.19.0