From nobody Wed Feb 11 04:06:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538491310450794.1001134083152; Tue, 2 Oct 2018 07:41:50 -0700 (PDT) Received: from localhost ([::1]:44038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7Lrx-0001Sp-3x for importer@patchew.org; Tue, 02 Oct 2018 10:41:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7Lmp-0005IS-Ia for qemu-devel@nongnu.org; Tue, 02 Oct 2018 10:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7LdD-0004RB-JA for qemu-devel@nongnu.org; Tue, 02 Oct 2018 10:26:36 -0400 Received: from greensocs.com ([193.104.36.180]:53928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7LdA-0004OM-Hf; Tue, 02 Oct 2018 10:26:32 -0400 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id 4F664442AFB; Tue, 2 Oct 2018 16:26:11 +0200 (CEST) Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6g9tA1GfWSVf; Tue, 2 Oct 2018 16:26:09 +0200 (CEST) Received: by greensocs.com (Postfix, from userid 998) id D21A5442AF5; Tue, 2 Oct 2018 16:26:07 +0200 (CEST) Received: from kouign-amann.hive.antfield.fr (antfield.tima.u-ga.fr [147.171.129.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: damien.hedde@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 6AB47442AFD; Tue, 2 Oct 2018 16:26:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538490371; bh=jFdDOTrCjBSX31V7YSODO0nvlL+B8KjEWaH7DIakyp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fCcDoJWC3xZgdAPLCyboaeApG2IrTDP5qqaJ6CebqxjjU7NsAoE1hSCXwWxpqlqeb nE2suU7CTP/pzpmNysp3kO/JncmoodrRw2fTW0r1hAcJ7oHVJgxk9qA2h2PXMUMjA3 e2L4VbfRDQOHm7SJNZoRHZhun+Mijohz1czdwSyw= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=QomYVnlv; dkim=pass (1024-bit key) header.d=greensocs.com header.b=QomYVnlv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538490367; bh=jFdDOTrCjBSX31V7YSODO0nvlL+B8KjEWaH7DIakyp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QomYVnlvv1AAJMtDNzt2gfFG00gfnM8/kNaCCEvuIUuL593kN9i6OJz1AWWiJJwN5 kHuFRIZ9qb4K5sgvEQLRja08HFk8l+eTXMwBqiptI4XwrIHBY3xdnHfY/93HFBwE1i dkjbK3cpW1OOxXDAt7MyKMEjkNociHON3AR4zrzk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538490367; bh=jFdDOTrCjBSX31V7YSODO0nvlL+B8KjEWaH7DIakyp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QomYVnlvv1AAJMtDNzt2gfFG00gfnM8/kNaCCEvuIUuL593kN9i6OJz1AWWiJJwN5 kHuFRIZ9qb4K5sgvEQLRja08HFk8l+eTXMwBqiptI4XwrIHBY3xdnHfY/93HFBwE1i dkjbK3cpW1OOxXDAt7MyKMEjkNociHON3AR4zrzk= From: Damien Hedde To: qemu-devel@nongnu.org Date: Tue, 2 Oct 2018 16:24:43 +0200 Message-Id: <20181002142443.30976-10-damien.hedde@greensocs.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002142443.30976-1-damien.hedde@greensocs.com> References: <20181002142443.30976-1-damien.hedde@greensocs.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v5 9/9] hw/arm/xilinx_zynq: connect uart clocks to slcr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, mark.burton@greensocs.com, saipava@xilinx.com, qemu-arm@nongnu.org, Damien Hedde , pbonzini@redhat.com, konrad@adacore.com, luc.michel@greensocs.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add the connection between the slcr's output clocks and the uarts inputs. Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/xilinx_zynq.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index f1496d2927..88f61c6a18 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -166,7 +166,7 @@ static void zynq_init(MachineState *machine) MemoryRegion *address_space_mem =3D get_system_memory(); MemoryRegion *ext_ram =3D g_new(MemoryRegion, 1); MemoryRegion *ocm_ram =3D g_new(MemoryRegion, 1); - DeviceState *dev; + DeviceState *dev, *slcr; SysBusDevice *busdev; qemu_irq pic[64]; int n; @@ -212,9 +212,10 @@ static void zynq_init(MachineState *machine) 1, 0x0066, 0x0022, 0x0000, 0x0000, 0x0555, 0x2aa, 0); =20 - dev =3D qdev_create(NULL, "xilinx,zynq_slcr"); - qdev_init_nofail(dev); - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xF8000000); + /* Create slcr, keep a pointer to connect clocks */ + slcr =3D qdev_create(NULL, "xilinx,zynq_slcr"); + qdev_init_nofail(slcr); + sysbus_mmio_map(SYS_BUS_DEVICE(slcr), 0, 0xF8000000); =20 dev =3D qdev_create(NULL, TYPE_A9MPCORE_PRIV); qdev_prop_set_uint32(dev, "num-cpu", 1); @@ -235,8 +236,12 @@ static void zynq_init(MachineState *machine) sysbus_create_simple("xlnx,ps7-usb", 0xE0002000, pic[53-IRQ_OFFSET]); sysbus_create_simple("xlnx,ps7-usb", 0xE0003000, pic[76-IRQ_OFFSET]); =20 - cadence_uart_create(0xE0000000, pic[59 - IRQ_OFFSET], serial_hd(0)); - cadence_uart_create(0xE0001000, pic[82 - IRQ_OFFSET], serial_hd(1)); + dev =3D cadence_uart_create(0xE0000000, pic[59 - IRQ_OFFSET], serial_h= d(0)); + qdev_connect_clock(dev, "busclk", slcr, "uart0_amba_clk", &error_abort= ); + qdev_connect_clock(dev, "refclk", slcr, "uart0_ref_clk", &error_abort); + dev =3D cadence_uart_create(0xE0001000, pic[82 - IRQ_OFFSET], serial_h= d(1)); + qdev_connect_clock(dev, "busclk", slcr, "uart1_amba_clk", &error_abort= ); + qdev_connect_clock(dev, "refclk", slcr, "uart1_ref_clk", &error_abort); =20 sysbus_create_varargs("cadence_ttc", 0xF8001000, pic[42-IRQ_OFFSET], pic[43-IRQ_OFFSET], pic[44-IRQ_OFFSET], NU= LL); --=20 2.19.0