From nobody Wed Nov 5 22:39:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538483798278305.45225075209385; Tue, 2 Oct 2018 05:36:38 -0700 (PDT) Received: from localhost ([::1]:43477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7Juj-0002vx-Ev for importer@patchew.org; Tue, 02 Oct 2018 08:36:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7Jsl-0001Ej-1z for qemu-devel@nongnu.org; Tue, 02 Oct 2018 08:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7JeP-0001ht-Tw for qemu-devel@nongnu.org; Tue, 02 Oct 2018 08:19:45 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:53937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7JeP-0001hb-NT for qemu-devel@nongnu.org; Tue, 02 Oct 2018 08:19:41 -0400 Received: by mail-wm1-x343.google.com with SMTP id b19-v6so2027007wme.3 for ; Tue, 02 Oct 2018 05:19:41 -0700 (PDT) Received: from mocramis-ultrabook.localdomain ([178.208.16.32]) by smtp.gmail.com with ESMTPSA id z141-v6sm11563656wmc.3.2018.10.02.05.19.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 05:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blade-group.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZA3QDGhzXZc/HMXka+NXXz5xHxQ8ENslSB1bx4wJ3U0=; b=C+Rdr6GwQs1let63B286WWVw1oWxpa7uOatw8bgyJPr1+nLEWL8bvv6WuU/eQ0Y40g PlHSshrG/Aqjj5G8MtcHMXHIuEqN1bMbjmLIIsiQ2LrbCTuNTUZUIlLtzuETdUnkBSJ6 f2whwfnyGUaPEEPeMOkDvSt7okGur6a0qOhQw11I1ltn6v0v4JnwVVFBjg2Dk6ilyC+/ Sl63aoNDKfcEYiWM/di9Py6fSG0Y4la2vHkCL3EV+/egnfGvf1QwaiPBUbHWT2As2RTZ PcxWwfnosVh7Q+nVYh1W9U+yUYEhfhiZdC9/RcIV1dtKwHr7xzACfRQtskZIcijSrCtf dzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZA3QDGhzXZc/HMXka+NXXz5xHxQ8ENslSB1bx4wJ3U0=; b=RATsuOy3+RzzdxROxvxOCd9IOZW+LPDaelGI0noUZHLDFtEmQ8iOH4y+1M4PSynSRW 17makbe32xaHrdGWp7gIJmfdSLx3tdG21zw5KIUDcVsgPBdTdxJAixkD3064AA8/6ZdW QC+NVknb+spn8eVdtIRquwl+vJW4sgvw0re34pV1jWkCYPmakR9QT360Smtdp/P7pm5m O3NqwmFEHtFCLNvteXbU+1DUuvKPhADJbb82e7zjC6ELK77bHT6jFBlcvVm/hHvztjEI 5+aMGNamc3rQBnXuY0XDhnvOO/b414PtxG6YWfkehZnDH4aMlpVyRBqJLHjZCqKyFpbR 4IYg== X-Gm-Message-State: ABuFfoggS13JGZJpi/rSUMniOccL42w4cge8r3v9STQwsVDx2JAI2t/O 7NXnKbpTs+/XnGnMnNedgUYqaCmsyEk= X-Google-Smtp-Source: ACcGV63BvCx1ODxgpx8rW21QM/yo73BHFzwJQeXdhwatXAfY4/Hl/3N7TWV7ROFkdOqkkLjIezDEUw== X-Received: by 2002:a1c:1a88:: with SMTP id a130-v6mr1733915wma.142.1538482780080; Tue, 02 Oct 2018 05:19:40 -0700 (PDT) From: remy.noel@blade-group.com To: qemu-devel@nongnu.org Date: Tue, 2 Oct 2018 14:19:35 +0200 Message-Id: <20181002121935.23706-1-remy.noel@blade-group.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v2] secondary-vga: delete mmio subregions upon exit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "remy.noel" , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: "remy.noel" 93abfc88bd649de1933588bfc7175605331b3ea9 introduced a reference cycle in the vga-pci devices, preventing cleanup of the object upon hotblug. This patch allows to break the cycle. Signed-off-by: remy.noel --- hw/display/vga-pci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 24ca1b3e1f..a68f014c9f 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -309,6 +309,11 @@ static void pci_secondary_vga_exit(PCIDevice *dev) VGACommonState *s =3D &d->vga; =20 graphic_console_close(s->con); + memory_region_del_subregion(&d->mmio, &d->mrs[0]); + memory_region_del_subregion(&d->mmio, &d->mrs[1]); + if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_QEXT)) { + memory_region_del_subregion(&d->mmio, &d->mrs[2]); + } } =20 static void pci_secondary_vga_init(Object *obj) --=20 2.19.0