From nobody Thu Nov 6 00:38:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538395888247367.1089081810135; Mon, 1 Oct 2018 05:11:28 -0700 (PDT) Received: from localhost ([::1]:37985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6x2p-000088-1C for importer@patchew.org; Mon, 01 Oct 2018 08:11:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6wpT-0002R8-Aa for qemu-devel@nongnu.org; Mon, 01 Oct 2018 07:57:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6wpQ-0005oN-NK for qemu-devel@nongnu.org; Mon, 01 Oct 2018 07:57:35 -0400 Received: from greensocs.com ([193.104.36.180]:40045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6wpK-0005SU-9z; Mon, 01 Oct 2018 07:57:28 -0400 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id A1CEF511C77; Mon, 1 Oct 2018 13:57:10 +0200 (CEST) Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pKa9U5-h-JZl; Mon, 1 Oct 2018 13:57:09 +0200 (CEST) Received: by greensocs.com (Postfix, from userid 998) id CA5CD511C6F; Mon, 1 Oct 2018 13:57:07 +0200 (CEST) Received: from michell-laptop.home.lmichel.fr (LFbn-1-8165-82.w90-112.abo.wanadoo.fr [90.112.74.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 64B7E511C6E; Mon, 1 Oct 2018 13:57:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538395030; bh=meV9yOzJ7Ab2hCvUI3L602DaBOj/Pe+XBQYESc/Rovw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MXrj+6cc9+e8jIhXs5t/KS93l51xghRMT+VoJ6INLBvoYaDWVKrgX/tK4TI2iJ0dg QntnjbPML6EOLwLQVZveTmGW77UMgXq8Ggw+GN8tJ43/JiOc1CqAZuAv9hEARZnMUG 8lfURGyKaKpxfmivTMyayGhoZBtF0GMod1aXrE/k= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=02g0XcS/; dkim=pass (1024-bit key) header.d=greensocs.com header.b=02g0XcS/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538395027; bh=meV9yOzJ7Ab2hCvUI3L602DaBOj/Pe+XBQYESc/Rovw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=02g0XcS/FZ5dvGHBElmyqWGdagym2ANJJlNuqv3MyIxywZjjy23qLVpreCJ/tBVRv g4zPzcyLZYnFYrWW1qLuevawrzodENNAOmHCD/sFwvY5vGmgjR5uHmPrOdSObwOnnI hXIOXam9kTr1K5X3QdJvrIQvHMwuucHMCFeXWxJw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1538395027; bh=meV9yOzJ7Ab2hCvUI3L602DaBOj/Pe+XBQYESc/Rovw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=02g0XcS/FZ5dvGHBElmyqWGdagym2ANJJlNuqv3MyIxywZjjy23qLVpreCJ/tBVRv g4zPzcyLZYnFYrWW1qLuevawrzodENNAOmHCD/sFwvY5vGmgjR5uHmPrOdSObwOnnI hXIOXam9kTr1K5X3QdJvrIQvHMwuucHMCFeXWxJw= From: Luc Michel To: qemu-devel@nongnu.org Date: Mon, 1 Oct 2018 13:56:53 +0200 Message-Id: <20181001115704.701-5-luc.michel@greensocs.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181001115704.701-1-luc.michel@greensocs.com> References: <20181001115704.701-1-luc.michel@greensocs.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v2 04/15] gdbstub: add multiprocess support to vCont packets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , alistair@alistair23.me, mark.burton@greensocs.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add the gdb_first_cpu() and gdb_next_cpu() to iterate over all the CPUs in currently attached processes. Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to iterate over CPUs of a given process. Use them to add multiprocess extension support to vCont packets. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 102 insertions(+), 15 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a21ce3ca18..779cc8b241 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -704,10 +704,40 @@ static CPUState *find_cpu(uint32_t thread_id) } =20 return NULL; } =20 +static CPUState *get_first_cpu_in_process(const GDBState *s, + GDBProcess *process) +{ + CPUState *cpu; + + CPU_FOREACH(cpu) { + if (gdb_get_cpu_pid(s, cpu) =3D=3D process->pid) { + return cpu; + } + } + + return NULL; +} + +static CPUState *gdb_next_cpu_in_process(const GDBState *s, CPUState *cpu) +{ + uint32_t pid =3D gdb_get_cpu_pid(s, cpu); + cpu =3D CPU_NEXT(cpu); + + while (cpu) { + if (gdb_get_cpu_pid(s, cpu) =3D=3D pid) { + break; + } + + cpu =3D CPU_NEXT(cpu); + } + + return cpu; +} + static CPUState *gdb_get_cpu(const GDBState *s, uint32_t pid, uint32_t tid) { GDBProcess *process; CPUState *cpu =3D find_cpu(tid); =20 @@ -731,10 +761,41 @@ static CPUState *gdb_get_cpu(const GDBState *s, uint3= 2_t pid, uint32_t tid) } =20 return cpu; } =20 +/* Return the cpu following @cpu, while ignoring + * unattached processes. + */ +static CPUState *gdb_next_cpu(const GDBState *s, CPUState *cpu) +{ + cpu =3D CPU_NEXT(cpu); + + while (cpu) { + if (gdb_get_cpu_process(s, cpu)->attached) { + break; + } + + cpu =3D CPU_NEXT(cpu); + } + + return cpu; +} + +/* Return the first attached cpu */ +static CPUState *gdb_first_cpu(const GDBState *s) +{ + CPUState *cpu =3D first_cpu; + GDBProcess *process =3D gdb_get_cpu_process(s, cpu); + + if (!process->attached) { + return gdb_next_cpu(s, cpu); + } + + return cpu; +} + static const char *get_feature_xml(const char *p, const char **newp, CPUClass *cc) { size_t len; int i; @@ -1069,14 +1130,16 @@ static int is_query_packet(const char *p, const cha= r *query, char separator) * returns -ENOTSUP if a command is unsupported, -EINVAL or -ERANGE if the= re is * a format error, 0 on success. */ static int gdb_handle_vcont(GDBState *s, const char *p) { - int res, idx, signal =3D 0; + int res, signal =3D 0; char cur_action; char *newstates; unsigned long tmp; + uint32_t pid, tid; + GDBProcess *process; CPUState *cpu; #ifdef CONFIG_USER_ONLY int max_cpus =3D 1; /* global variable max_cpus exists only in system = mode */ =20 CPU_FOREACH(cpu) { @@ -1115,29 +1178,52 @@ static int gdb_handle_vcont(GDBState *s, const char= *p) } else if (cur_action !=3D 'c' && cur_action !=3D 's') { /* unknown/invalid/unsupported command */ res =3D -ENOTSUP; goto out; } - /* thread specification. special values: (none), -1 =3D all; 0 =3D= any */ - if ((p[0] =3D=3D ':' && p[1] =3D=3D '-' && p[2] =3D=3D '1') || (p[= 0] !=3D ':')) { - if (*p =3D=3D ':') { - p +=3D 3; - } - for (idx =3D 0; idx < max_cpus; idx++) { - if (newstates[idx] =3D=3D 1) { - newstates[idx] =3D cur_action; + + if (*p++ !=3D ':') { + res =3D -ENOTSUP; + goto out; + } + + switch (read_thread_id(p, &p, &pid, &tid)) { + case GDB_READ_THREAD_ERR: + res =3D -EINVAL; + goto out; + + case GDB_ALL_PROCESSES: + cpu =3D gdb_first_cpu(s); + while (cpu) { + if (newstates[cpu->cpu_index] =3D=3D 1) { + newstates[cpu->cpu_index] =3D cur_action; } + + cpu =3D gdb_next_cpu(s, cpu); } - } else if (*p =3D=3D ':') { - p++; - res =3D qemu_strtoul(p, &p, 16, &tmp); - if (res) { + break; + + case GDB_ALL_THREADS: + process =3D gdb_get_process(s, pid); + + if (!process->attached) { + res =3D -EINVAL; goto out; } =20 - /* 0 means any thread, so we pick the first valid CPU */ - cpu =3D tmp ? find_cpu(tmp) : first_cpu; + cpu =3D get_first_cpu_in_process(s, process); + while (cpu) { + if (newstates[cpu->cpu_index] =3D=3D 1) { + newstates[cpu->cpu_index] =3D cur_action; + } + + cpu =3D gdb_next_cpu_in_process(s, cpu); + } + break; + + case GDB_ONE_THREAD: + cpu =3D gdb_get_cpu(s, pid, tid); =20 /* invalid CPU/thread specified */ if (!cpu) { res =3D -EINVAL; goto out; @@ -1145,10 +1231,11 @@ static int gdb_handle_vcont(GDBState *s, const char= *p) =20 /* only use if no previous match occourred */ if (newstates[cpu->cpu_index] =3D=3D 1) { newstates[cpu->cpu_index] =3D cur_action; } + break; } } s->signal =3D signal; gdb_continue_partial(s, newstates); =20 --=20 2.19.0