From nobody Mon Feb 9 14:33:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538017018881728.3960705261353; Wed, 26 Sep 2018 19:56:58 -0700 (PDT) Received: from localhost ([::1]:33504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5MU5-0007q4-Pr for importer@patchew.org; Wed, 26 Sep 2018 22:56:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5MRx-0006a7-Mm for qemu-devel@nongnu.org; Wed, 26 Sep 2018 22:54:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5MRw-00087j-Cd for qemu-devel@nongnu.org; Wed, 26 Sep 2018 22:54:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48840) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5MRw-000872-7D for qemu-devel@nongnu.org; Wed, 26 Sep 2018 22:54:44 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80778308AA0E for ; Thu, 27 Sep 2018 02:54:43 +0000 (UTC) Received: from red.redhat.com (ovpn-126-36.rdu2.redhat.com [10.10.126.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 406EA6148C; Thu, 27 Sep 2018 02:54:33 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Date: Wed, 26 Sep 2018 21:54:26 -0500 Message-Id: <20180927025427.101853-3-eblake@redhat.com> In-Reply-To: <20180927025427.101853-1-eblake@redhat.com> References: <20180927025427.101853-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 27 Sep 2018 02:54:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/3] qapi: bitmap-merge: document name change X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: John Snow We named these using underscores instead of the preferred dash, document this nearby so we cannot possibly forget to rectify this when we remove the 'x-' prefixes when the feature becomes stable. We do not implement the change ahead of time to avoid more work for libvirt to do in order to figure out how to use the beta version of the API needlessly. Reported-by: Eric Blake Signed-off-by: John Snow Message-Id: <20180919190934.16284-1-jsnow@redhat.com> Reviewed-by: Eric Blake [eblake: typo fix] Signed-off-by: Eric Blake --- qapi/block-core.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index ac3b48ee54e..58ec9931c7f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1935,6 +1935,8 @@ ## # @x-block-dirty-bitmap-merge: # +# FIXME: Rename @src_name and @dst_name to src-name and dst-name. +# # Merge @src_name dirty bitmap to @dst_name dirty bitmap. @src_name dirty # bitmap is unchanged. On error, @dst_name is unchanged. # --=20 2.17.1