From nobody Mon Feb 9 10:28:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1537978344463975.0668197464162; Wed, 26 Sep 2018 09:12:24 -0700 (PDT) Received: from localhost ([::1]:59633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5CQF-0007j0-IC for importer@patchew.org; Wed, 26 Sep 2018 12:12:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5CJu-00023K-1X for qemu-devel@nongnu.org; Wed, 26 Sep 2018 12:05:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5CJq-0005rS-T0 for qemu-devel@nongnu.org; Wed, 26 Sep 2018 12:05:46 -0400 Received: from mail-eopbgr730106.outbound.protection.outlook.com ([40.107.73.106]:54899 helo=NAM05-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5CJq-0005r8-M2; Wed, 26 Sep 2018 12:05:42 -0400 Received: from Jupiter.local (141.226.29.227) by CY1PR07MB2619.namprd07.prod.outlook.com (2a01:111:e400:c637::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.25; Wed, 26 Sep 2018 16:05:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mund+t7aW5KyOHuTsDm5fH8C97MERJjcdm9+cMnHvuE=; b=UZq5+Zi5D2GZ2p8dKWdQr9SocV1nxy3kSUOm5jkDx9HbCazCQixS7Nlgm4bqZFdrKDNB66+knFLyeNDmE+fue2z1qfo1wKf97brm5VUTowtJ7bCFDcjwbv04fxHbaYQcINV0WJKzfgZO9hCtyi6wiR+XNjsDQjYnEXZChtmfljA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; From: Leonid Bloch To: qemu-devel@nongnu.org Date: Wed, 26 Sep 2018 19:04:46 +0300 Message-Id: <20180926160447.5149-9-lbloch@janustech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180926160447.5149-1-lbloch@janustech.com> References: <20180926160447.5149-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: HE1PR02CA0116.eurprd02.prod.outlook.com (2603:10a6:7:29::45) To CY1PR07MB2619.namprd07.prod.outlook.com (2a01:111:e400:c637::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d2af236-8079-49a7-a7ca-08d623c9e860 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989299)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2619; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2619; 3:xtCuy7VweBBRwRN1Y8I65/pc0w2lG2uONCJfkLCG5dchUOg1P/GFHffTgOFxbbVrTFO4LWJWgreKGbL2mI1GDj+qVAQjTFcKFtyYCAxFHCRsJ9O2zSPgR9IPRC+XKi55SXzdL33Y4gHL9PueMl+uxoYrFiK/RDSXQ2+bQwXuY25tKv6CpHCYNtieRVeC/e9+sT+DlCBHAz/Wk0SCwVDgzFfgd1dWQOCmXDZZ4irF8O2lYHEB5BqF+zDR8zmDB1rW; 25:F7pyvae6Y3+jnvY7rpPYsFqzu1fsGr3e5nEbWruj6yOYwBnPUpLJW1ufckmrDYvU6UYth3fg4aq5fTCv5R8ntFPgQwcXuxOIjpFnGvgnAsraToU8I5AVrbzWmOfB1lXapoFSFZZHbRqs2GdBW6a5CjKK1qYa6PXaPWC6EN2J81aSrFlcQRiR2qouBC/MJkGrClJ57hotpy/ag71lveTlvdLPI98ZEwcNpoGozXn+4MpchkuAlmvx0o2d+Zyo7DvQTc4GYxq/26CYRh7+TAPbsXDdIR6oWiUu9uBwajcMidkR3D1Hts61Cb8QPblk4Kv351kOCBvFF92q6itKedjSkQ==; 31:Q11J1Ros6rsMy0YxOhoQAiMzo1pitsxYJIHCGQhTM9Y7CrX0ougXmzzvMuSCCzeYsSv3jiEldbOIs1+K2yni6uq5kuZiwSnoxFgjGzfCwnaPY4w6CgOi0vWxUzUmWvHHNWb6yzWAhOs/gWPDXW9h+dXMmE9nKaJaJpirlHTBzFHLEr5GWrgRM2zwjw7rZR65z+JhKm86Wf6D+XNPNTaPHJN+irHftaJggT8pQYDrx9U= X-MS-TrafficTypeDiagnostic: CY1PR07MB2619: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123560045)(2016111802025)(20161123558120)(6043046)(201708071742011)(7699051); SRVR:CY1PR07MB2619; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2619; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2619; 4:ZcfcCbHY0ubkGUrEVTDSQbVpCXOWbXDAIFPyhMGZ3opZBBbbMIWg4z9uc2j8iEkyPSmZ2mk7CjuAq4wDKQ0L2HsNVIGxMYn810S1u44uOXFlb9Z1RIkrNAfwf8XCN8NzB+/FXvfld77VJCpB5pZWVSzvjvPEiw3bG+LqnTx0cNqyeMK3WDvxyIb5jw9/dqeaXc1J4d7lE21oCnJbAfhDdVYikgi1AwLfs8Dt/S9zxWl0hWyVoOlWz9eAGJFPsw+VNT4CASuBP32CqPgNIcSzeg== X-Forefront-PRVS: 08076ABC99 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(136003)(396003)(39830400003)(376002)(346002)(199004)(189003)(106356001)(508600001)(66066001)(6512007)(47776003)(4326008)(48376002)(2616005)(107886003)(446003)(50466002)(956004)(11346002)(36756003)(486006)(6486002)(476003)(2351001)(105586002)(34290500001)(316002)(16586007)(14444005)(54906003)(2361001)(3846002)(6116002)(6506007)(386003)(1076002)(51416003)(52116002)(76176011)(26005)(2906002)(305945005)(8936002)(81166006)(186003)(16526019)(7736002)(8676002)(81156014)(6916009)(5660300001)(6666003)(50226002)(97736004)(25786009)(86362001)(68736007)(575784001)(53936002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR07MB2619; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2619; 23:pqNMWXXzMURJa0+Rp/XUvQ1bd+NWZ75excyytzKPf?= =?us-ascii?Q?TxZAKMMPzTUDOUSc9GAfdaZYqj9lBvgxqmxfoMzm8IL2+gGq+pxiHwZgXH4y?= =?us-ascii?Q?4myxJd43MhzgRRKbR1tdG0jURmmku8nWaP1sgq9QLuMK23UXeh/vJXiqFPc1?= =?us-ascii?Q?hAI88iMMtkHqy5+pNdEQEUTZ7LcSgV4rUFTXx/0aZkTytOV6LkzmzH9W4ZHr?= =?us-ascii?Q?KduoXHDv4WvRJ2VcUEFvvFpUR7JRQPrThVyZSN26hQbwkJlU8u38BCBgSkAu?= =?us-ascii?Q?7x3jboT2KYm/eKv6zJ06WmG3zBfo9la9g1GfIJjmLj48fxpoqs5smqXN1g65?= =?us-ascii?Q?md0p/Q4vs8khLV4V5V5z60gcKbdvXpMOCY5UDOUrPQC1RPtv38+qyKm94EHR?= =?us-ascii?Q?KRyios+UocI7jE0xkbpTttiJJJUgw/xPXXsd0cA4YIOOr2FS6twbmejS/Q6k?= =?us-ascii?Q?e55VYAYRihTv5Ljv6RHAarum2BOJZVvy5o6iOOISrAXGYjuAJ/F4l+Lu/ivB?= =?us-ascii?Q?Nh8rAhS1SCzK7VDp1lfSZ5klI7SEiGPeikro+jAXJ6Rpp8lIqS0ynsOJao09?= =?us-ascii?Q?RCaPY45+RvRqmg8phNvSyB93k5q4kyCnBmff5EqVDCvNxPc1FhQtcICysj1p?= =?us-ascii?Q?jJOp/C4HZpoEzMftZ281OF3mgtvW/yh5o28wsUhiAzw+1iY/EvpP7TVB58nc?= =?us-ascii?Q?ylApcIjCbLu52MNlG+BJXYpF++k8uG6w1IkJL2OFaSAu4H9zM/ZRYzhRT1Sp?= =?us-ascii?Q?8e5R2T+fSbPSmu9ePCIlhBGgGpnwWboj3NNd34YSYqKtzogQZUJ28B/3kn0Z?= =?us-ascii?Q?VvUM7Umh9RsANtM5jPGgt1qtNS2DOnlMhJ9kIINTPeImKN9EbqIi3d0wjVMC?= =?us-ascii?Q?hO+3CWxcEdlk4VDSq5De6UEMuEFcW5BdGayGrlfb9XbWyuw4BqUgkzTEIZfy?= =?us-ascii?Q?i3c21SQzxAzh/7MkhHsglXoF8NbsQ2ixQv5z53fynY6CWTAvr4fIqkFF1yk9?= =?us-ascii?Q?6oRwjFtfJwoKTcD9tatcoQGluUN7B1/HBZ5xlWWHcTJWbJ69vVyrXf1pHmcU?= =?us-ascii?Q?L1pFhQafzU27JODRcefxAPpfAG5dozDfy78t2JdRqgFnXabKiYqSabMZNOWI?= =?us-ascii?Q?Q+mvY6qd7lwWxw4k0As1fqKBrz4gvr/SI0rcAbamE8zOyzffOecXE2mghLyh?= =?us-ascii?Q?nq/xulexovrURudi3Q5KIXtEAX1nEFKD+QGojGeTW0Aor76htjUUzXj4MMCs?= =?us-ascii?Q?efdRrBbn1dVBADJPAA4fzD6UF6vKQIgth5t5C1fFhHQwrv6A3d8H4l6ANGqS?= =?us-ascii?Q?WahkWpyMLiA8J4WVKUlHQWat3qIq44YBJX8HhYIJAws?= X-Microsoft-Antispam-Message-Info: W8QYaCNAS2wE7MnAJLkKRzr+Bmhlk5Xrlu89elc6xebzKCamDW14Ryxq/xRqGsvoQ2bPgmVWj5iC8C3F/yPlI+d99rArDa1LwaXwyuyNEttCYmGNy/mWQJ1kzAPWg+quu40IsosY1f0zBcAhnAwp19MomCaQXUu8jgVDUuF6HdD8tFaEz7e+cdJH/HwuSGJNvhFjeAS+5r2tBal5Fe1H/jcvYf0fH3O2xPvljiybwO9MohHUMjuYFQ/1YWDds4EDVN8XOM2Y8IJcDtT9IJwqUv7BgeAJ4pL84SwCmsnQvOFy4vGvUV7Np9kU5ThZ26wSe1ZwNMSsD12evsM8h0ON8ae7YEyCU6eqwbiHXpZZXyY= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2619; 6:kjjqbggXvJYA0Sb4zJ9P1/DH00bIm049xzWXBz3qnpDghKi3W92RnxHlZ0HdJTCX+2KGJW+q6MonCtSeWPIvQTMHpXkWriwl1wm5OEIcqC6kh1KSsY6SvVMY+dA5cg2uulHrnS5aFzJKRdaZ80o2U8Up+htieNxWCiY9qtgluOWAdVeuu9M3ekQ0I9HFFRyfOfPptUTdGHBZEI9yLEsarp+taBCGiNAM8vc/N+sMWqivqoWQQFck6qxnHPjpCNrfIxRTCtvFUVeBZkKNYetTlgABOmMiozE6WqM2CqnEYPVEua+k6KhKsFWd977F+3pzfScvM+kI+xqC5HsVht2+DVUK8/DHgSSJmKvg7ECkXfN0v0JxbAhw+3UdZBoNzhCvymac1/47eHVRB5LSig+3h3nDkDPHWpWWaI/n8UVzXMGFn5t/btybO5oje/CSA26pLs72TbTcCtlcJqOkU1210w==; 5:fA7sOq4AkaPTtL81WOKbpSPp4LO7vDrhPajnvvRMv4YcMTY58FhmDdl2Nnwy4KOgJQNz6CsGaxS4kTDldtxRi5LQT0Q3pjLYr+aFU/EmIPcin6wy/hYBpuPH6ZCoBoh8AP2wfvj625v/kLWaP2D+srdZQc9DtF1MpedUyDxcnfs=; 7:vy7fiosYiaTTB60g0BTJQ18gjdEw/x+j9WuOzsWO6yc/plvHTCROi68QC6E9PSAGS7ptZf8/erf5WgSJSDllE3tcZCVpphSTT8kh4/KnYTYxUMHiB0M1KwXjunUvRyAFX6tXrLwIoXMe/okpVFbbIa8yaAWcUXMh9vlAOIFPukRWzl49mnmc+UWO8JhZRgMriay/I95adVbAst7uAoPwOtlJ5FxXP2MW8fsB5PZGONogVpFTo50a6df91ZQm5OLs SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2018 16:05:39.1212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2af236-8079-49a7-a7ca-08d623c9e860 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2619 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.73.106 Subject: [Qemu-devel] [PATCH v12 8/9] qcow2: Set the default cache-clean-interval to 10 minutes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Leonid Bloch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). * For non-Linux platforms the default is kept at 0, because cache-clean-interval is not supported there yet. Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia Reviewed-by: Kevin Wolf --- block/qcow2.c | 2 +- block/qcow2.h | 4 +++- docs/qcow2-cache.txt | 4 ++-- qapi/block-core.json | 3 ++- qemu-options.hx | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 20b5093269..95e1c98daa 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -944,7 +944,7 @@ static int qcow2_update_options_prepare(BlockDriverStat= e *bs, /* New interval for cache cleanup timer */ r->cache_clean_interval =3D qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, - s->cache_clean_interval); + DEFAULT_CACHE_CLEAN_INTERVAL); #ifndef CONFIG_LINUX if (r->cache_clean_interval !=3D 0) { error_setg(errp, QCOW2_OPT_CACHE_CLEAN_INTERVAL diff --git a/block/qcow2.h b/block/qcow2.h index 0f0e3534bf..ba430316b9 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -76,13 +76,15 @@ =20 #ifdef CONFIG_LINUX #define DEFAULT_L2_CACHE_MAX_SIZE S_32MiB +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */ #else #define DEFAULT_L2_CACHE_MAX_SIZE S_8MiB +/* Cache clean interval is currently available only on Linux, so must be 0= */ +#define DEFAULT_CACHE_CLEAN_INTERVAL 0 #endif =20 #define DEFAULT_CLUSTER_SIZE S_64KiB =20 - #define QCOW2_OPT_LAZY_REFCOUNTS "lazy-refcounts" #define QCOW2_OPT_DISCARD_REQUEST "pass-discard-request" #define QCOW2_OPT_DISCARD_SNAPSHOT "pass-discard-snapshot" diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 1fcc0658b2..59358b816f 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -210,8 +210,8 @@ This example removes all unused cache entries every 15 = minutes: =20 -drive file=3Dhd.qcow2,cache-clean-interval=3D900 =20 -If unset, the default value for this parameter is 0 and it disables -this feature. +If unset, the default value for this parameter is 600. Setting it to 0 +disables this feature. =20 Note that this functionality currently relies on the MADV_DONTNEED argument for madvise() to actually free the memory. This is a diff --git a/qapi/block-core.json b/qapi/block-core.json index ac3b48ee54..46dac23d2f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2895,7 +2895,8 @@ # # @cache-clean-interval: clean unused entries in the L2 and refcount # caches. The interval is in seconds. The default = value -# is 0 and it disables this feature (since 2.5) +# is 600, and 0 disables this feature. (since 2.5) +# # @encrypt: Image decryption options. Mandatory for # encrypted images, except when doing a metadata-o= nly # probe of the image. (since 2.10) diff --git a/qemu-options.hx b/qemu-options.hx index 14aee78c6c..52d9d9f06d 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -747,7 +747,7 @@ it which is not used for the L2 cache) =20 @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in sec= onds. -The default value is 0 and it disables this feature. +The default value is 600. Setting it to 0 disables this feature. =20 @item pass-discard-request Whether discard requests to the qcow2 device should be forwarded to the da= ta --=20 2.17.1