From nobody Thu Nov 6 08:35:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1537550776103496.6464281793393; Fri, 21 Sep 2018 10:26:16 -0700 (PDT) Received: from localhost ([::1]:56712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3PC2-0000uv-S9 for importer@patchew.org; Fri, 21 Sep 2018 13:26:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3PA1-00083y-Ui for qemu-devel@nongnu.org; Fri, 21 Sep 2018 13:24:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3P9y-0004HM-Kq for qemu-devel@nongnu.org; Fri, 21 Sep 2018 13:24:09 -0400 Received: from mail-eopbgr730118.outbound.protection.outlook.com ([40.107.73.118]:28896 helo=NAM05-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3P9y-0004GO-Bw; Fri, 21 Sep 2018 13:24:06 -0400 Received: from Jupiter.local (141.226.29.227) by CY1PR07MB2618.namprd07.prod.outlook.com (2a01:111:e400:c637::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Fri, 21 Sep 2018 17:24:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qkvqMl9Ufkd6JNzfUhiYAQZqfe7XtbpeEH01j0MnkPY=; b=CmC8vbFFjpAZQNFvsXQ3Bmk+GxCQRkwpbFeOpfSx9vOnu+1uqJjqr7EkvyGLfsbEMe4+reK5eMA/DNjiGseLJ33hSDH3xQNv1COqQY5HZARxCA8InbRO0a4OfKpixy+zoiOQl98bYTUmpvuwfxXAThvfxTVrUEKVvMoV53x0yDE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; From: Leonid Bloch To: qemu-devel@nongnu.org Date: Fri, 21 Sep 2018 20:23:09 +0300 Message-Id: <20180921172310.10068-9-lbloch@janustech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180921172310.10068-1-lbloch@janustech.com> References: <20180921172310.10068-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: HE1PR08CA0065.eurprd08.prod.outlook.com (2603:10a6:7:2a::36) To CY1PR07MB2618.namprd07.prod.outlook.com (2a01:111:e400:c637::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84ae9a9d-819b-4b9b-5e4c-08d61fe7074e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989299)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2618; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 3:vUoT9Wt0uW70AlF/PTM6f5mM1IVGaMc2KCC4KMExLm91vdIoa4R0sn+IrHhSXNbdlPzKYr8GwRv6JeP93dYFd5l3OtZjFme0srGzGN7/sAgvfoGLF/Zd97J+ikXC8zo9VFMKAuarNgvURII49o+UbjgVQ7XPWUWru9Rk4Qe8I/167VfqLWzhoclFMXkMd1rhds09XBfDN1FkeJpJzrGIrvnzoB3RtaY0+j0GV5DqWpUfkrkbsfMky71toGjhLMt9; 25:bPEaqHOZ12ueYQJ14NEWb5RxGijGyA9vuYKwT8CliqQkSofNWyeqta6wqcO2VTvKRMlI4rDDD7r6KGJp51VEnb0n8741ufQAM6/QYgskZYcImZqrgI83s6SEAL7+k7Ja0QHNR/cD3QeVn73IWlhFYlLvm4SV4O3UvfPs2pVPimQQmHuKqzo8wFGbd7pWTccBa/eD59rRvVOWhXSPRpPwU23KpYcQ7cx2hcXbD88xlfRVREd8aBbRv7KK7YoLBpTjsDIE/rmjp857bt0Me4XxcFPOTCQx52V/7JTpD3zSLHar4ZhuCTzJva3GxQsNSICjFocCKXhaHNUxkuqzXnQXxg==; 31:aBauXHtG9jA7kVliVt9gutGgswb3xTJxuRZwxB8tD+f9yol7jhI/lOCD79zonDFxoRx7rtcKmOeojrQxXFyUEsGVRVCKfMh8JgyeYSLcS5zzThs5Qr0AIkI9DyUDE6QJDaTz5FeMGvKo782C7yMm4ALi9KFwWQ9eofr6g15qRxewLTUO55TnYST5wEhGA1Oqr4Q4khje3sfr6ZLtRZeYOd13h3srYw7mGosR77TMqWw= X-MS-TrafficTypeDiagnostic: CY1PR07MB2618: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231355)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(2016111802025)(6043046)(201708071742011)(7699051); SRVR:CY1PR07MB2618; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2618; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 4:e3UMuK7ugi81am1muvZkfBliscA5gwWUf+8+Z4sR+csEQKNgTytCI+1yw9PVftkGJrs4LM3Z+kHoNdJPH32ricU+syIfSuhWgURw6Eospsv0Eu78AhDxHWMt+/2NzpkLZu98n11xB/L6VxwJh7/pybKQkle0Fzi9y9hgWehCqwG22BqgGUVogqfZPTyTYo9BTRMWqiC45R+9nsnlPOzex90BaWRQoWsIA2a//zn9ckKqY8o4gFUbbWB8eLy1LjvXVzRjIZHqVQzGxeH6OWkDRQ== X-Forefront-PRVS: 0802ADD973 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(136003)(366004)(39830400003)(346002)(376002)(199004)(189003)(86362001)(68736007)(50226002)(106356001)(8936002)(1076002)(2906002)(6116002)(4326008)(53936002)(305945005)(8676002)(7736002)(5660300001)(81156014)(25786009)(3846002)(6486002)(36756003)(107886003)(6512007)(14444005)(11346002)(81166006)(97736004)(508600001)(47776003)(105586002)(2361001)(186003)(51416003)(48376002)(6916009)(50466002)(486006)(54906003)(476003)(956004)(66066001)(6506007)(2351001)(16526019)(2616005)(386003)(575784001)(316002)(16586007)(76176011)(52116002)(446003)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR07MB2618; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2618; 23:uVFI+Xl8n7PoUmKpLx+vPfLrCSOcb2PjWlWWoV6YD?= =?us-ascii?Q?QnsHAeCcrVLz6Flf0XVz2xZMT7K+ROcIy9iqvfEtqv+U0K/hpQo8WUZwpqqa?= =?us-ascii?Q?YkAPHPKB3dvNJ7nJkV7nSkxsQKjKn9DfxCVcP2cFzh/2kAQRfZHO61ctyEGg?= =?us-ascii?Q?X9Qlv9vWLWcsrs9ccEmIqcBazvcomhAsWgj6K+ZIWBzlkJP63vK+edIcmnO+?= =?us-ascii?Q?qeKyMcMAaPxmCkghpnB07EIOe5zTHkFd2UdQ7RnVoblp315PJpjMROQ3uosH?= =?us-ascii?Q?dermlRlO8ljvDpsszi2XtDMytUOFaVoKMyMPuUxlY+vkQPPlUh8n+58Cv+Pz?= =?us-ascii?Q?TgZEROtt3d79Lr4jKyXHnR8ABroV2V9R1zIh9Gnn0rT0CEBMmuva/2udjM6W?= =?us-ascii?Q?zoDAnwM23faIoC8DGZsLF96kVpxlPbomwUPotweUsRoqbOecxD+sO2qmiM9h?= =?us-ascii?Q?1EtA9WXF+vUaq5zz2QatUPBbQHMVyYuU5mw/hE4mCJvSutRdfLrno6Ctk6o+?= =?us-ascii?Q?uk/NV/u0H9Cy22CuJITqu68+61S+/BkpiHYsMhja4UehNa/Kh0ncWkurIInH?= =?us-ascii?Q?wdWE+1ft/z9oofA8+Rwdg+XLBBjkcfp+z53yAt3qc4F9VGfGx9ylu80md2sm?= =?us-ascii?Q?feiVD+cLTr4k4UV4Z/hIIRZ3bZjgjLi2m7Hxm2eU6QduqsRsOfmjQpYAIq9f?= =?us-ascii?Q?WtXvriVHUdODeol8Ti3CO7Je7+n23KXNRAiZOR2gw0oT9hrEbBzJ3MLU/0X6?= =?us-ascii?Q?btIxDIMJY3Rc8KPfk5+EjxcB3pa4xIXvvMSSt10FdPQwAA3XIGfn+MBQ67uW?= =?us-ascii?Q?GMUeCWb8njs1MyK6YOkxA47+wyKpRzTLWqetZiE5C+2m5U7j/TeWxKmxIGYs?= =?us-ascii?Q?j6zjWH0oDkxx8/RU4EYcaJYv7pcAWLkbu2USkqwJZXRu05+ufvtm7GsSUn1d?= =?us-ascii?Q?g3X5HJ2BqBnskNn7OYdv7uH2ZRu9DTOeDddOeO94rYLI4A3XuUm6x0OrAJvE?= =?us-ascii?Q?3UA5cuus7t+UY0I7HrgpepOIHYvJcRSCikEFxLE77cFZuN/ncoNRoz/YlKzl?= =?us-ascii?Q?RannTjkuQG7YGdnOq9ANlF/gN7Rpf8PY7miSKhvRZomJsL5YoQ5TrHdBpW+i?= =?us-ascii?Q?BnSHkyT1FQkRYLKru8bDHkgTgvuABAFa1TAoqApsaStgJqSkYlK9RARd6b2d?= =?us-ascii?Q?p/pd+ow9HykUlXyiXuRU22TadmwH4lOPhqLbD4RGuvZ/VTKAMWOZXNNW4Qhf?= =?us-ascii?Q?BRWlZoXGQvh9R78ujSIfBVd/XBywlQ2a8+XLA8gBoY4yN/xLbMXm9jWRK9dd?= =?us-ascii?B?QT09?= X-Microsoft-Antispam-Message-Info: 0yLCvDuRkqbn+3mh1HpLgqo2ifk46eLNu5//0mMPcux+rP1uZgK+NRu+ZyeZokg/Z5l7BC0Os7fYGNR2RCtFRSo+feidRSk0M9DUltSie7Sz+gM/fghPuts1BPmzUbbReNMGWrooJbDHTVO8pLhP/mOFSc1Fl7E7zsNotQei2awEIKqDA6I+jRHEJouxT2Pnby1+AT+WhsKxG+fDC/cTzDRYOecFhggjEt5s2s6qRIE+VkOx7xV76YjtmB0kPADlHvRq+4OKlX1U0QhKPJnzmKI9iec+GMfHRQGwUuXIed6q06jvB72Ex9OVo6fitEGB0c+bL05i3iYroQBbH2h6TCOh0m5wjwU/3NTGM1zBnBg= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 6:+DHNnm9JGLbI6XM8zOii2103M6ust9k4llHwTBeWPPId5k1NvGKxeTPeCCQXe+8gxowldr6aYqJTjN47R1UPq/3K8bWwzXIAjDg55W4gXENrmhuTyZcdj8RTD8LERN804CCTYhAqTttlnLCyN+LoDlH636zccxXhabI/nqVYouni5roE47yMbCNFWIy+OekmmbIrAn1FPA83aBvWjU4JiLgjIUhE4pGxkrfTVkuEYGO1E64PBoyRGPzFlT7REWPeb/oOoh+aoArE81yzXUE4B+DXCEnpJYyUKrYrMyoF/0KrDObw1qaXcGTEzdNNZC4my5JZdYoNA6SbPHFlCSaS+tVm3em8IGM7+V52c7kx+kV039ZDd380JUbtnxHYtnw+3p9mdoBkLbMnME2KJ8rfI766It+tIl5KVB9I1S8VbEPAw7/y9nS4VrqDhkl5cwqvpUXSdJzVCcrBlfoX8J8TIg==; 5:L5oDKY4jhfllx6h1xOn5nv5l9TrZo5O+5x1n4xN69MniLUuG7CUOybMXzf4RBAimQpbuPQ/uPFV44AcYMSvBuEyjTUcLte3oUCubjIgdBW209K6vRqfjmVuAX42PadsgZKzVT68sxE8fr9T4g2KSArg1cIbaf5AarEij2UK3dZc=; 7:Oq1jKeYDfBK0Cy54vCPQ5kTMulHsmdw6lKLrSmpMESy1dT7PN4zIDbTmQW92/xG5+juHJGbxDe5Pk+nqlEJhJvSGKtCMPjV5O4oV2tQ9Z64tB4aREqRoutAx7h8AuWwwlhFzYrm2T9IuBkMtSN7thRBlW6gZ6m8FAr24IY8dPHJddS5fJZXljUSulpbK/SYq6Ey6rqUCgk5z9KWAZUINan/YH5yWlKIJCjrpHHzZ9XXEYidQn98q9BGDtDpVIDXO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2018 17:24:01.7642 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84ae9a9d-819b-4b9b-5e4c-08d61fe7074e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2618 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.73.118 Subject: [Qemu-devel] [PATCH v10 8/9] qcow2: Set the default cache-clean-interval to 10 minutes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Leonid Bloch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). * For non-Linux platforms the default is kept at 0, because cache-clean-interval is not supported there yet. Signed-off-by: Leonid Bloch --- block/qcow2.c | 2 +- block/qcow2.h | 4 +++- docs/qcow2-cache.txt | 4 ++-- qapi/block-core.json | 3 ++- qemu-options.hx | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1445cd5360..f885afa0ed 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -944,7 +944,7 @@ static int qcow2_update_options_prepare(BlockDriverStat= e *bs, /* New interval for cache cleanup timer */ r->cache_clean_interval =3D qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, - s->cache_clean_interval); + DEFAULT_CACHE_CLEAN_INTERVAL); #ifndef CONFIG_LINUX if (r->cache_clean_interval !=3D 0) { error_setg(errp, QCOW2_OPT_CACHE_CLEAN_INTERVAL diff --git a/block/qcow2.h b/block/qcow2.h index 0f0e3534bf..ba430316b9 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -76,13 +76,15 @@ =20 #ifdef CONFIG_LINUX #define DEFAULT_L2_CACHE_MAX_SIZE S_32MiB +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */ #else #define DEFAULT_L2_CACHE_MAX_SIZE S_8MiB +/* Cache clean interval is currently available only on Linux, so must be 0= */ +#define DEFAULT_CACHE_CLEAN_INTERVAL 0 #endif =20 #define DEFAULT_CLUSTER_SIZE S_64KiB =20 - #define QCOW2_OPT_LAZY_REFCOUNTS "lazy-refcounts" #define QCOW2_OPT_DISCARD_REQUEST "pass-discard-request" #define QCOW2_OPT_DISCARD_SNAPSHOT "pass-discard-snapshot" diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 5965d3d094..15ae797931 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -209,8 +209,8 @@ This example removes all unused cache entries every 15 = minutes: =20 -drive file=3Dhd.qcow2,cache-clean-interval=3D900 =20 -If unset, the default value for this parameter is 0 and it disables -this feature. +If unset, the default value for this parameter is 600. Setting it to 0 +disables this feature. =20 Note that this functionality currently relies on the MADV_DONTNEED argument for madvise() to actually free the memory. This is a diff --git a/qapi/block-core.json b/qapi/block-core.json index 4c7a37afdc..08c27b9af7 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2827,7 +2827,8 @@ # # @cache-clean-interval: clean unused entries in the L2 and refcount # caches. The interval is in seconds. The default = value -# is 0 and it disables this feature (since 2.5) +# is 600, and 0 disables this feature. (since 2.5) +# # @encrypt: Image decryption options. Mandatory for # encrypted images, except when doing a metadata-o= nly # probe of the image. (since 2.10) diff --git a/qemu-options.hx b/qemu-options.hx index d5f4bcadd4..2975fdf9f8 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -757,7 +757,7 @@ it which is not used for the L2 cache) =20 @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in sec= onds. -The default value is 0 and it disables this feature. +The default value is 600. Setting it to 0 disables this feature. =20 @item pass-discard-request Whether discard requests to the qcow2 device should be forwarded to the da= ta --=20 2.17.1