From nobody Wed Nov 5 18:21:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1537172910828938.6270093081911; Mon, 17 Sep 2018 01:28:30 -0700 (PDT) Received: from localhost ([::1]:34368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1otR-0002DE-LJ for importer@patchew.org; Mon, 17 Sep 2018 04:28:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1ori-0001EX-BE for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1org-0004Wx-CP for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1ore-0004Tv-IT for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:38 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED3CD30832D2 for ; Mon, 17 Sep 2018 08:26:36 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C97D18669; Mon, 17 Sep 2018 08:26:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DF07B41A70; Mon, 17 Sep 2018 10:26:28 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Mon, 17 Sep 2018 10:26:26 +0200 Message-Id: <20180917082628.10916-2-kraxel@redhat.com> In-Reply-To: <20180917082628.10916-1-kraxel@redhat.com> References: <20180917082628.10916-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 17 Sep 2018 08:26:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/3] display/edid: add edid generator to qemu. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" EDID is a metadata format to describe monitors. On physical hardware the monitor has an eeprom with that data block which can be read over i2c bus. On a linux system you can usually find the EDID data block in /sys/class/drm/$card/$connector/edid. xorg ships a edid-decode utility which you can use to turn the blob into readable form. I think it would be a good idea to use EDID for virtual displays too. Needs changes in both qemu and guest kms drivers. This patch is the first step, it adds an generator for EDID blobs to qemu. Comes with a qemu-edid test tool included. With EDID we can pass more information to the guest. Names and serial numbers, so the guests display configuration has no boring "Unknown Monitor". List of video modes. Display resolution, pretty important in case we want add HiDPI support some day. Signed-off-by: Gerd Hoffmann --- configure | 2 +- Makefile | 2 + include/hw/display/edid.h | 18 +++ hw/display/edid-generate.c | 334 +++++++++++++++++++++++++++++++++++++++++= ++++ qemu-edid.c | 106 ++++++++++++++ hw/display/Makefile.objs | 2 + 6 files changed, 463 insertions(+), 1 deletion(-) create mode 100644 include/hw/display/edid.h create mode 100644 hw/display/edid-generate.c create mode 100644 qemu-edid.c diff --git a/configure b/configure index 58862d2ae8..053facfb68 100755 --- a/configure +++ b/configure @@ -5715,7 +5715,7 @@ fi =20 tools=3D"" if test "$want_tools" =3D "yes" ; then - tools=3D"qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools" + tools=3D"qemu-img\$(EXESUF) qemu-io\$(EXESUF) qemu-edid\$(EXESUF) $tools" if [ "$linux" =3D "yes" -o "$bsd" =3D "yes" -o "$solaris" =3D "yes" ] ; = then tools=3D"qemu-nbd\$(EXESUF) $tools" fi diff --git a/Makefile b/Makefile index fe623e4634..7bb6675f4a 100644 --- a/Makefile +++ b/Makefile @@ -543,6 +543,8 @@ qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o $(COM= MON_LDADDS) =20 qemu-keymap$(EXESUF): qemu-keymap.o ui/input-keymap.o $(COMMON_LDADDS) =20 +qemu-edid$(EXESUF): qemu-edid.o hw/display/edid-generate.o $(COMMON_LDADDS) + fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/9p-m= arshal.o fsdev/9p-iov-marshal.o $(COMMON_LDADDS) fsdev/virtfs-proxy-helper$(EXESUF): LIBS +=3D -lcap =20 diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h new file mode 100644 index 0000000000..63b60015c3 --- /dev/null +++ b/include/hw/display/edid.h @@ -0,0 +1,18 @@ +#ifndef EDID_H +#define EDID_H + +typedef struct qemu_edid_info { + const char *vendor; + const char *name; + const char *serial; + uint32_t dpi; + uint32_t prefx; + uint32_t prefy; + uint32_t maxx; + uint32_t maxy; +} qemu_edid_info; + +void qemu_edid_generate(uint8_t *edid, size_t size, + qemu_edid_info *info); + +#endif /* EDID_H */ diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c new file mode 100644 index 0000000000..e439b1e893 --- /dev/null +++ b/hw/display/edid-generate.c @@ -0,0 +1,334 @@ +/* + * QEMU EDID generator. + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ +#include "qemu/osdep.h" +#include "qemu-common.h" +#include "qemu/bswap.h" +#include "hw/display/edid.h" + +static const struct edid_mode { + uint32_t xres; + uint32_t yres; + uint32_t byte; + uint32_t xtra3; + uint32_t bit; +} modes[] =3D { + /* other */ + { .xres =3D 2048, .yres =3D 1152 }, + { .xres =3D 1920, .yres =3D 1440 }, + { .xres =3D 1920, .yres =3D 1080 }, + + /* additional standard timings 3 (all @75Hz) */ + { .xres =3D 1920, .yres =3D 1200, .xtra3 =3D 11, .bit =3D 7 }, + { .xres =3D 1856, .yres =3D 1392, .xtra3 =3D 10, .bit =3D 2 }, + { .xres =3D 1792, .yres =3D 1344, .xtra3 =3D 10, .bit =3D 4 }, + { .xres =3D 1600, .yres =3D 1200, .xtra3 =3D 10, .bit =3D 7 }, + { .xres =3D 1680, .yres =3D 1050, .xtra3 =3D 9, .bit =3D 4 }, + { .xres =3D 1440, .yres =3D 1050, .xtra3 =3D 8, .bit =3D 0 }, + { .xres =3D 1440, .yres =3D 900, .xtra3 =3D 8, .bit =3D 4 }, + { .xres =3D 1280, .yres =3D 768, .xtra3 =3D 7, .bit =3D 5 }, + + /* established timings (all @75Hz) */ + { .xres =3D 1280, .yres =3D 1024, .byte =3D 36, .bit =3D 0 }, + { .xres =3D 1024, .yres =3D 768, .byte =3D 36, .bit =3D 1 }, + { .xres =3D 800, .yres =3D 600, .byte =3D 36, .bit =3D 6 }, + { .xres =3D 640, .yres =3D 480, .byte =3D 35, .bit =3D 2 }, +}; + +static int edid_std_mode(uint8_t *mode, uint32_t xres, uint32_t yres) +{ + uint32_t aspect; + + if (xres =3D=3D 0 || yres =3D=3D 0) { + mode[0] =3D 0x01; + mode[1] =3D 0x01; + return 0; + + } else if (xres * 10 =3D=3D yres * 16) { + aspect =3D 0; + } else if (xres * 3 =3D=3D yres * 4) { + aspect =3D 1; + } else if (xres * 4 =3D=3D yres * 5) { + aspect =3D 2; + } else if (xres * 9 =3D=3D yres * 16) { + aspect =3D 3; + } else { + return -1; + } + + mode[0] =3D (xres / 8) - 31; + mode[1] =3D ((aspect << 6) | (75 - 60)); + return 0; +} + +static void edid_fill_modes(uint8_t *edid, uint8_t *xtra3, + uint32_t maxx, uint32_t maxy) +{ + const struct edid_mode *mode; + int std =3D 38; + int rc, i; + + for (i =3D 0; i < ARRAY_SIZE(modes); i++) { + mode =3D modes + i; + + if ((maxx && mode->xres > maxx) || + (maxy && mode->yres > maxy)) { + continue; + } + + if (mode->byte) { + edid[mode->byte] |=3D (1 << mode->bit); + } else if (mode->xtra3 && xtra3) { + xtra3[mode->xtra3] |=3D (1 << mode->bit); + } else if (std < 54) { + rc =3D edid_std_mode(edid + std, mode->xres, mode->yres); + if (rc =3D=3D 0) { + std +=3D 2; + } + } + } + + while (std < 54) { + edid_std_mode(edid + std, 0, 0); + std +=3D 2; + } +} + +static void edid_checksum(uint8_t *edid) +{ + uint32_t sum =3D 0; + int i; + + for (i =3D 0; i < 127; i++) { + sum +=3D edid[i]; + } + sum &=3D 0xff; + if (sum) { + edid[127] =3D 0x100 - sum; + } +} + +static void edid_desc_type(uint8_t *desc, uint8_t type) +{ + desc[0] =3D 0; + desc[1] =3D 0; + desc[2] =3D 0; + desc[3] =3D type; + desc[4] =3D 0; +} + +static void edid_desc_text(uint8_t *desc, uint8_t type, + const char *text) +{ + size_t len; + + edid_desc_type(desc, type); + memset(desc + 5, ' ', 13); + + len =3D strlen(text); + if (len > 12) + len =3D 12; + strncpy((char*)(desc + 5), text, len); + desc[ 5 + len ] =3D '\n'; +} + +static void edid_desc_ranges(uint8_t *desc) +{ + edid_desc_type(desc, 0xfd); + + /* vertical */ + desc[ 5] =3D 50; + desc[ 6] =3D 100; + + /* horizontal */ + desc[ 7] =3D 30; + desc[ 8] =3D 120; + + /* dot clock */ + desc[ 9] =3D 250 / 10; + + /* padding */ + desc[11] =3D '\n'; + memset(desc + 12, ' ', 6); +} + +/* additional standard timings 3 */ +static void edid_desc_xtra3_std(uint8_t *desc) +{ + edid_desc_type(desc, 0xf7); + desc[5] =3D 10; +} + +static void edid_desc_dummy(uint8_t *desc) +{ + edid_desc_type(desc, 0x10); +} + +static void edid_desc_timing(uint8_t *desc, + uint32_t xres, uint32_t yres, + uint32_t dpi) +{ + /* physical display size */ + uint32_t xmm =3D xres * dpi / 254; + uint32_t ymm =3D yres * dpi / 254; + + /* pull some realistic looking timings out of thin air */ + uint32_t xfront =3D xres * 25 / 100; + uint32_t xsync =3D xres * 3 / 100; + uint32_t xblank =3D xres * 35 / 100; + + uint32_t yfront =3D yres * 5 / 1000; + uint32_t ysync =3D yres * 5 / 1000; + uint32_t yblank =3D yres * 35 / 1000; + + uint32_t clock =3D 75 * (xres + xblank) * (yres + yblank); + + *(uint32_t*)(desc) =3D cpu_to_le32(clock / 10000); + + desc[2] =3D xres & 0xff; + desc[3] =3D xblank & 0xff; + desc[4] =3D ((( xres & 0xf00 ) >> 4) | + (( xblank & 0xf00 ) >> 8)); + + desc[5] =3D yres & 0xff; + desc[6] =3D yblank & 0xff; + desc[7] =3D ((( yres & 0xf00 ) >> 4) | + (( yblank & 0xf00 ) >> 8)); + + desc[8] =3D xfront & 0xff; + desc[9] =3D xsync & 0xff; + + desc[10] =3D ((( yfront & 0x00f ) << 4) | + (( ysync & 0x00f ) << 0)); + desc[11] =3D ((( xfront & 0x300 ) >> 2) | + (( xsync & 0x300 ) >> 4) | + (( yfront & 0x030 ) >> 2) | + (( ysync & 0x030 ) >> 4)); + + desc[12] =3D xmm & 0xff; + desc[13] =3D ymm & 0xff; + desc[14] =3D ((( xmm & 0xf00 ) >> 4) | + (( ymm & 0xf00 ) >> 8)); + + desc[17] =3D 0x18; +} + +void qemu_edid_generate(uint8_t *edid, size_t size, + qemu_edid_info *info) +{ + uint32_t desc =3D 54; + uint8_t *xtra3 =3D NULL; + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D set defaults =3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + if (!info->vendor || strlen(info->vendor) !=3D 3) { + info->vendor =3D "EMU"; + } + if (!info->name) { + info->name =3D "QEMU Monitor"; + } + if (!info->dpi) { + info->dpi =3D 100; + } + if (!info->prefx) { + info->prefx =3D 1024; + } + if (!info->prefy) { + info->prefy =3D 768; + } + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D header information = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + /* fixed */ + edid[0] =3D 0x00; + edid[1] =3D 0xff; + edid[2] =3D 0xff; + edid[3] =3D 0xff; + edid[4] =3D 0xff; + edid[5] =3D 0xff; + edid[6] =3D 0xff; + edid[7] =3D 0x00; + + /* manufacturer id, product code, serial number */ + uint16_t vendor_id =3D ((((info->vendor[0] - '@') & 0x1f) << 10) | + (((info->vendor[1] - '@') & 0x1f) << 5) | + (((info->vendor[2] - '@') & 0x1f) << 0)); + uint16_t model_nr =3D 0x1234; + uint32_t serial_nr =3D info->serial ? atoi(info->serial) : 0; + *(uint16_t*)(edid + 8) =3D cpu_to_be16(vendor_id); + *(uint16_t*)(edid + 10) =3D cpu_to_le16(model_nr); + *(uint32_t*)(edid + 12) =3D cpu_to_le32(serial_nr); + + /* manufacture week and year */ + edid[16] =3D 42; + edid[17] =3D 2014 - 1990; + + /* edid version */ + edid[18] =3D 1; + edid[19] =3D 4; + + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D basic display paramet= ers =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + /* video input: digital, 8bpc, displayport */ + edid[20] =3D 0xa5; + + /* screen size: undefined */ + edid[21] =3D info->prefx * info->dpi / 2540; + edid[22] =3D info->prefy * info->dpi / 2540; + + /* display gamma: 1.0 */ + edid[23] =3D 0x00; + + /* supported features bitmap: preferred timing */ + edid[24] =3D 0x02; + + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D chromaticity coordina= tes =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + /* TODO (bytes 25 -> 34) */ + + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D established timing bi= tmap =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D standard timing infor= mation =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + /* both filled by edid_fill_modes() */ + + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D descriptor blocks =3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + edid_desc_timing(edid + desc, info->prefx, info->prefy, info->dpi); + desc +=3D 18; + + edid_desc_ranges(edid + desc); + desc +=3D 18; + + if (info->name) { + edid_desc_text(edid + desc, 0xfc, info->name); + desc +=3D 18; + } + + if (info->serial) { + edid_desc_text(edid + desc, 0xff, info->serial); + desc +=3D 18; + } + + if (desc < 126) { + xtra3 =3D edid + desc; + edid_desc_xtra3_std(xtra3); + desc +=3D 18; + } + + while (desc < 126) { + edid_desc_dummy(edid + desc); + desc +=3D 18; + } + + /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D finish up =3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ + + edid_fill_modes(edid, xtra3, info->maxx, info->maxy); + edid_checksum(edid); +} diff --git a/qemu-edid.c b/qemu-edid.c new file mode 100644 index 0000000000..2e533a3a21 --- /dev/null +++ b/qemu-edid.c @@ -0,0 +1,106 @@ +/* + * QEMU EDID test tool. + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ +#include "qemu/osdep.h" +#include "qemu-common.h" +#include "qemu/bswap.h" +#include "qemu/cutils.h" +#include "hw/display/edid.h" + +static qemu_edid_info info; + +static void usage(FILE *out) +{ + fprintf(out, + "\n" + "This is a test tool for the qemu edid generator.\n" + "\n" + "Typically you'll pipe the output into edid-decode\n" + "to check if the generator works correctly.\n" + "\n" + "usage: qemu-edid \n" + "options:\n" + " -h print this text\n" + " -o set output file (stdout by default)\n" + " -v set monitor vendor (three letters)\n" + " -n set monitor name\n" + " -s set monitor serial\n" + " -d set display resolution\n" + " -x set preferred width\n" + " -y set preferred height\n" + "\n"); +} + +int main(int argc, char *argv[]) +{ + FILE *outfile =3D NULL; + uint8_t blob[128]; + int rc; + + for (;;) { + rc =3D getopt(argc, argv, "ho:x:y:d:v:n:s:"); + if (rc =3D=3D -1) { + break; + } + switch (rc) { + case 'o': + if (outfile) { + fprintf(stderr, "outfile specified twice\n"); + exit(1); + } + outfile =3D fopen(optarg, "w"); + if (outfile =3D=3D NULL) { + fprintf(stderr, "open %s: %s\n", optarg, strerror(errno)); + exit(1); + } + break; + case 'x': + if (qemu_strtoui(optarg, NULL, 10, &info.prefx) < 0) { + fprintf(stderr, "not a number: %s\n", optarg); + exit(1); + } + break; + case 'y': + if (qemu_strtoui(optarg, NULL, 10, &info.prefy) < 0) { + fprintf(stderr, "not a number: %s\n", optarg); + exit(1); + } + break; + case 'd': + if (qemu_strtoui(optarg, NULL, 10, &info.dpi) < 0) { + fprintf(stderr, "not a number: %s\n", optarg); + exit(1); + } + break; + case 'v': + info.vendor =3D optarg; + break; + case 'n': + info.name =3D optarg; + break; + case 's': + info.serial =3D optarg; + break; + case 'h': + usage(stdout); + exit(0); + default: + usage(stderr); + exit(1); + } + } + + if (outfile =3D=3D NULL) { + outfile =3D stdout; + } + + memset(blob, 0, sizeof(blob)); + qemu_edid_generate(blob, sizeof(blob), &info); + fwrite(blob, sizeof(blob), 1, outfile); + fflush(outfile); + + exit(0); +} diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs index a606fb7404..492404c09e 100644 --- a/hw/display/Makefile.objs +++ b/hw/display/Makefile.objs @@ -1,3 +1,5 @@ +common-obj-y +=3D edid-generate.o + common-obj-$(CONFIG_FW_CFG_DMA) +=3D ramfb.o common-obj-$(CONFIG_FW_CFG_DMA) +=3D ramfb-standalone.o =20 --=20 2.9.3 From nobody Wed Nov 5 18:21:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1537173020302444.24764652427245; Mon, 17 Sep 2018 01:30:20 -0700 (PDT) Received: from localhost ([::1]:34380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1ovD-0003rQ-Bx for importer@patchew.org; Mon, 17 Sep 2018 04:30:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1orz-0001OS-Ec for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1orv-0004jd-GJ for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51598) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1orq-0004cd-4P for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:51 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F00E3D95A for ; Mon, 17 Sep 2018 08:26:42 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1738D2B1C0; Mon, 17 Sep 2018 08:26:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EB2F04F973; Mon, 17 Sep 2018 10:26:28 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Mon, 17 Sep 2018 10:26:27 +0200 Message-Id: <20180917082628.10916-3-kraxel@redhat.com> In-Reply-To: <20180917082628.10916-1-kraxel@redhat.com> References: <20180917082628.10916-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 17 Sep 2018 08:26:42 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] display/edid: add region helper. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Create a io region for an EDID data block. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/display/edid.h | 4 ++++ hw/display/edid-region.c | 33 +++++++++++++++++++++++++++++++++ hw/display/Makefile.objs | 1 + 3 files changed, 38 insertions(+) create mode 100644 hw/display/edid-region.c diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h index 63b60015c3..c39d5cd77b 100644 --- a/include/hw/display/edid.h +++ b/include/hw/display/edid.h @@ -1,6 +1,8 @@ #ifndef EDID_H #define EDID_H =20 +#include "hw/hw.h" + typedef struct qemu_edid_info { const char *vendor; const char *name; @@ -14,5 +16,7 @@ typedef struct qemu_edid_info { =20 void qemu_edid_generate(uint8_t *edid, size_t size, qemu_edid_info *info); +void qemu_edid_region_io(MemoryRegion *region, Object *owner, + uint8_t *edid, size_t size); =20 #endif /* EDID_H */ diff --git a/hw/display/edid-region.c b/hw/display/edid-region.c new file mode 100644 index 0000000000..9a15734d3a --- /dev/null +++ b/hw/display/edid-region.c @@ -0,0 +1,33 @@ +#include "qemu/osdep.h" +#include "qemu-common.h" +#include "hw/display/edid.h" + +static uint64_t edid_region_read(void *ptr, hwaddr addr, unsigned size) +{ + uint8_t *edid =3D ptr; + + return edid[addr]; +} + +static void edid_region_write(void *ptr, hwaddr addr, + uint64_t val, unsigned size) +{ + /* read only */ +} + +static const MemoryRegionOps edid_region_ops =3D { + .read =3D edid_region_read, + .write =3D edid_region_write, + .valid.min_access_size =3D 1, + .valid.max_access_size =3D 4, + .impl.min_access_size =3D 1, + .impl.max_access_size =3D 1, + .endianness =3D DEVICE_LITTLE_ENDIAN, +}; + +void qemu_edid_region_io(MemoryRegion *region, Object *owner, + uint8_t *edid, size_t size) +{ + memory_region_init_io(region, owner, &edid_region_ops, + edid, "edid", size); +} diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs index 492404c09e..780a76b9f0 100644 --- a/hw/display/Makefile.objs +++ b/hw/display/Makefile.objs @@ -15,6 +15,7 @@ common-obj-$(CONFIG_XEN) +=3D xenfb.o =20 common-obj-$(CONFIG_VGA_PCI) +=3D vga-pci.o common-obj-$(CONFIG_VGA_PCI) +=3D bochs-display.o +common-obj-$(CONFIG_VGA_PCI) +=3D edid-region.o common-obj-$(CONFIG_VGA_ISA) +=3D vga-isa.o common-obj-$(CONFIG_VGA_ISA_MM) +=3D vga-isa-mm.o common-obj-$(CONFIG_VMWARE_VGA) +=3D vmware_vga.o --=20 2.9.3 From nobody Wed Nov 5 18:21:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1537172910118991.1577887245238; Mon, 17 Sep 2018 01:28:30 -0700 (PDT) Received: from localhost ([::1]:34367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1otQ-0002BV-IJ for importer@patchew.org; Mon, 17 Sep 2018 04:28:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1ori-0001EV-Aj for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1ore-0004Vk-Qf for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1ore-0004Sv-Fz for qemu-devel@nongnu.org; Mon, 17 Sep 2018 04:26:38 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A57286666 for ; Mon, 17 Sep 2018 08:26:36 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2757918686; Mon, 17 Sep 2018 08:26:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 06A7396125; Mon, 17 Sep 2018 10:26:29 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Mon, 17 Sep 2018 10:26:28 +0200 Message-Id: <20180917082628.10916-4-kraxel@redhat.com> In-Reply-To: <20180917082628.10916-1-kraxel@redhat.com> References: <20180917082628.10916-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 17 Sep 2018 08:26:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/3] display/stdvga: add edid support. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds edid support to the qemu stdvga. It is turned off by default and can be enabled with the new edid property. The patch also adds xres and yres properties to specify the video mode you want the guest use. Works only with edid enabled and updated guest driver. The mmio bar of the stdvga has some unused address space at the start. It was reserved just in case it'll be needed for virtio, but it turned out to not be needed for that. So let's use that region to place the EDID data block there. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/specs/standard-vga.txt | 2 +- hw/display/vga_int.h | 2 +- hw/display/vga-pci.c | 42 ++++++++++++++++++++++++++++++++++++++---- hw/display/virtio-vga.c | 2 +- 4 files changed, 41 insertions(+), 7 deletions(-) diff --git a/docs/specs/standard-vga.txt b/docs/specs/standard-vga.txt index 19d2a74509..18f75f1b30 100644 --- a/docs/specs/standard-vga.txt +++ b/docs/specs/standard-vga.txt @@ -61,7 +61,7 @@ MMIO area spec =20 Likewise applies to the pci variant only for obvious reasons. =20 -0000 - 03ff : reserved, for possible virtio extension. +0000 - 03ff : edid data blob. 0400 - 041f : vga ioports (0x3c0 -> 0x3df), remapped 1:1. word access is supported, bytes are written in little endia order (aka index port first), diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 339661bc01..6e4fa48a79 100644 --- a/hw/display/vga_int.h +++ b/hw/display/vga_int.h @@ -197,6 +197,6 @@ void pci_std_vga_mmio_region_init(VGACommonState *s, Object *owner, MemoryRegion *parent, MemoryRegion *subs, - bool qext); + bool qext, bool edid); =20 #endif diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index e9e62eac70..5e692baf78 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -30,18 +30,23 @@ #include "ui/pixel_ops.h" #include "qemu/timer.h" #include "hw/loader.h" +#include "hw/display/edid.h" =20 enum vga_pci_flags { PCI_VGA_FLAG_ENABLE_MMIO =3D 1, PCI_VGA_FLAG_ENABLE_QEXT =3D 2, + PCI_VGA_FLAG_ENABLE_EDID =3D 3, }; =20 typedef struct PCIVGAState { PCIDevice dev; VGACommonState vga; uint32_t flags; + uint32_t xres; + uint32_t yres; MemoryRegion mmio; - MemoryRegion mrs[3]; + MemoryRegion mrs[4]; + uint8_t edid[128]; } PCIVGAState; =20 #define TYPE_PCI_VGA "pci-vga" @@ -195,8 +200,10 @@ void pci_std_vga_mmio_region_init(VGACommonState *s, Object *owner, MemoryRegion *parent, MemoryRegion *subs, - bool qext) + bool qext, bool edid) { + PCIVGAState *d =3D container_of(s, PCIVGAState, vga); + memory_region_init_io(&subs[0], owner, &pci_vga_ioport_ops, s, "vga ioports remapped", PCI_VGA_IOPORT_SIZE); memory_region_add_subregion(parent, PCI_VGA_IOPORT_OFFSET, @@ -213,6 +220,16 @@ void pci_std_vga_mmio_region_init(VGACommonState *s, memory_region_add_subregion(parent, PCI_VGA_QEXT_OFFSET, &subs[2]); } + + if (edid) { + qemu_edid_info info =3D { + .prefx =3D d->xres, + .prefy =3D d->yres, + }; + qemu_edid_generate(d->edid, sizeof(d->edid), &info); + qemu_edid_region_io(&subs[3], owner, d->edid, sizeof(d->edid)); + memory_region_add_subregion(parent, 0, &subs[3]); + } } =20 static void pci_std_vga_realize(PCIDevice *dev, Error **errp) @@ -220,6 +237,7 @@ static void pci_std_vga_realize(PCIDevice *dev, Error *= *errp) PCIVGAState *d =3D PCI_VGA(dev); VGACommonState *s =3D &d->vga; bool qext =3D false; + bool edid =3D false; =20 /* vga + console init */ vga_common_init(s, OBJECT(dev)); @@ -240,7 +258,11 @@ static void pci_std_vga_realize(PCIDevice *dev, Error = **errp) qext =3D true; pci_set_byte(&d->dev.config[PCI_REVISION_ID], 2); } - pci_std_vga_mmio_region_init(s, OBJECT(dev), &d->mmio, d->mrs, qex= t); + if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_EDID)) { + edid =3D true; + } + pci_std_vga_mmio_region_init(s, OBJECT(dev), &d->mmio, d->mrs, + qext, edid); =20 pci_register_bar(&d->dev, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &d->mm= io); } @@ -263,6 +285,7 @@ static void pci_secondary_vga_realize(PCIDevice *dev, E= rror **errp) PCIVGAState *d =3D PCI_VGA(dev); VGACommonState *s =3D &d->vga; bool qext =3D false; + bool edid =3D false; =20 /* vga + console init */ vga_common_init(s, OBJECT(dev)); @@ -276,7 +299,10 @@ static void pci_secondary_vga_realize(PCIDevice *dev, = Error **errp) qext =3D true; pci_set_byte(&d->dev.config[PCI_REVISION_ID], 2); } - pci_std_vga_mmio_region_init(s, OBJECT(dev), &d->mmio, d->mrs, qext); + if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_EDID)) { + edid =3D true; + } + pci_std_vga_mmio_region_init(s, OBJECT(dev), &d->mmio, d->mrs, qext, e= did); =20 pci_register_bar(&d->dev, 0, PCI_BASE_ADDRESS_MEM_PREFETCH, &s->vram); pci_register_bar(&d->dev, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &d->mmio); @@ -308,6 +334,10 @@ static Property vga_pci_properties[] =3D { DEFINE_PROP_BIT("mmio", PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_MMIO, = true), DEFINE_PROP_BIT("qemu-extended-regs", PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_QEXT, true), + DEFINE_PROP_BIT("edid", + PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_EDID, false), + DEFINE_PROP_UINT32("xres", PCIVGAState, xres, 0), + DEFINE_PROP_UINT32("yres", PCIVGAState, yres, 0), DEFINE_PROP_BOOL("global-vmstate", PCIVGAState, vga.global_vmstate, fa= lse), DEFINE_PROP_END_OF_LIST(), }; @@ -316,6 +346,10 @@ static Property secondary_pci_properties[] =3D { DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16), DEFINE_PROP_BIT("qemu-extended-regs", PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_QEXT, true), + DEFINE_PROP_BIT("edid", + PCIVGAState, flags, PCI_VGA_FLAG_ENABLE_EDID, false), + DEFINE_PROP_UINT32("xres", PCIVGAState, xres, 0), + DEFINE_PROP_UINT32("yres", PCIVGAState, yres, 0), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/hw/display/virtio-vga.c b/hw/display/virtio-vga.c index 701d980872..3bea0693f6 100644 --- a/hw/display/virtio-vga.c +++ b/hw/display/virtio-vga.c @@ -163,7 +163,7 @@ static void virtio_vga_realize(VirtIOPCIProxy *vpci_dev= , Error **errp) =20 /* add stdvga mmio regions */ pci_std_vga_mmio_region_init(vga, OBJECT(vvga), &vpci_dev->modern_bar, - vvga->vga_mrs, true); + vvga->vga_mrs, true, false); =20 vga->con =3D g->scanout[0].con; g->disable_scanout =3D virtio_vga_disable_scanout; --=20 2.9.3