From nobody Wed Nov 5 20:14:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536768298001656.0171304938599; Wed, 12 Sep 2018 09:04:58 -0700 (PDT) Received: from localhost ([::1]:36988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g07dM-0000S0-Cp for importer@patchew.org; Wed, 12 Sep 2018 12:04:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g07aW-00074N-C3 for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:01:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g07aV-0003eb-HG for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:01:56 -0400 Received: from m12-15.163.com ([220.181.12.15]:52585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g07aU-0003dN-RQ for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:01:55 -0400 Received: from ubuntu.localdomain (unknown [36.27.41.0]) by smtp11 (Coremail) with SMTP id D8CowADHy0FjOJlbpTj+Gw--.61042S6; Thu, 13 Sep 2018 00:01:49 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=6ryNm+27fWoVufiWi+ WyNaeWZpL+x3M/kNXMdWkkuo8=; b=Xa97VHB1JjK2pVnRhld+IGvDaTAxW0OyfF PWHiNtO1U14xLS1cIunI4A3lFOvoIjN6cyWLaR1jsHWYCEyfvDJRR8zTGT9gI7vY 77qVh8Wni5e9mQVMwGFI3Yqy4XJ94GfHaXd+lAlRMjPSTeaomH+F1y5rXkaTusD1 ZwNwv7mEg= From: Li Qiang To: pbonzini@redhat.com, lersek@redhat.com, marcandre.lureau@gmail.com, ehabkost@redhat.com, mst@redhat.com, peter.maydell@linaro.org, ppandit@redhat.com Date: Wed, 12 Sep 2018 09:01:14 -0700 Message-Id: <20180912160118.21158-5-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180912160118.21158-1-liq3ea@163.com> References: <20180912160118.21158-1-liq3ea@163.com> X-CM-TRANSID: D8CowADHy0FjOJlbpTj+Gw--.61042S6 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur43GF15KFy7KrWxWF47twb_yoW8Cw1xpr n5WF4jqFs3tF1aqFZ8Jw17JFWrGwnrt34fCFs0kr1q9rn3Zw1qgFZrGFyI9rWkC3ykZw45 Can8GFWxWa1UJ3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jy0P-UUUUU= X-Originating-IP: [36.27.41.0] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiKQ2-bVXln3E4SAAAsY X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.15 Subject: [Qemu-devel] [PATCH 4/8] hw: pc-testdev: add read memory region callback X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang Also change the write callback name. Signed-off-by: Li Qiang --- hw/misc/pc-testdev.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/misc/pc-testdev.c b/hw/misc/pc-testdev.c index b81d820084..697eb88c97 100644 --- a/hw/misc/pc-testdev.c +++ b/hw/misc/pc-testdev.c @@ -58,7 +58,12 @@ typedef struct PCTestdev { #define TESTDEV(obj) \ OBJECT_CHECK(PCTestdev, (obj), TYPE_TESTDEV) =20 -static void test_irq_line(void *opaque, hwaddr addr, uint64_t data, +static uint64_t test_irq_line_read(void *opaque, hwaddr addr, unsigned siz= e) +{ + return 0; +} + +static void test_irq_line_write(void *opaque, hwaddr addr, uint64_t data, unsigned len) { PCTestdev *dev =3D opaque; @@ -68,7 +73,8 @@ static void test_irq_line(void *opaque, hwaddr addr, uint= 64_t data, } =20 static const MemoryRegionOps test_irq_ops =3D { - .write =3D test_irq_line, + .read =3D test_irq_line_read, + .write =3D test_irq_line_write, .valid.min_access_size =3D 1, .valid.max_access_size =3D 1, .endianness =3D DEVICE_LITTLE_ENDIAN, @@ -110,7 +116,12 @@ static const MemoryRegionOps test_ioport_byte_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 -static void test_flush_page(void *opaque, hwaddr addr, uint64_t data, +static uint64_t test_flush_page_read(void *opaque, hwaddr addr, unsigned s= ize) +{ + return 0; +} + +static void test_flush_page_write(void *opaque, hwaddr addr, uint64_t data, unsigned len) { hwaddr page =3D 4096; @@ -126,7 +137,8 @@ static void test_flush_page(void *opaque, hwaddr addr, = uint64_t data, } =20 static const MemoryRegionOps test_flush_ops =3D { - .write =3D test_flush_page, + .read =3D test_flush_page_read, + .write =3D test_flush_page_write, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, .endianness =3D DEVICE_LITTLE_ENDIAN, --=20 2.17.1