From nobody Wed Nov 5 18:26:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536629619150369.41156040693966; Mon, 10 Sep 2018 18:33:39 -0700 (PDT) Received: from localhost ([::1]:54868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzXYa-0002QU-DN for importer@patchew.org; Mon, 10 Sep 2018 21:33:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzXXY-0000bC-HN for qemu-devel@nongnu.org; Mon, 10 Sep 2018 21:32:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzXXX-00087e-IQ for qemu-devel@nongnu.org; Mon, 10 Sep 2018 21:32:28 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:34322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fzXXX-00086J-9y; Mon, 10 Sep 2018 21:32:27 -0400 Received: by mail-lf1-x142.google.com with SMTP id c29-v6so19053720lfj.1; Mon, 10 Sep 2018 18:32:27 -0700 (PDT) Received: from octofox.cadence.com (jcmvbkbc-1-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:1fa::2]) by smtp.gmail.com with ESMTPSA id g16-v6sm3054570lje.1.2018.09.10.18.32.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Sep 2018 18:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=SmTH0IhtZH4ku7oSgcHQcfDWILw8y/E/1zJUqyWdqG0=; b=XmLyJx5gbPT1UlbU1y4B/3MIgbQOxzgWWGJd3I/iLBQRxb2NANTtxrAlNt2RClGUy2 pfcfPbYkx5SMd5vG0XZcv5VdRR4zzhUs8NJG+rX2hNT4TtX/pHBkVmRWKaluNO3EcyKT hRbdX8aap3YHgFJbdxWE+lkbZxBGAMgCUsw2cxjhGDpe6e4gHZONhKQ5bbMamJx9ekZJ pT0oHT/JgvSq4DdJcSIdERbQjJ8e4xdQxRRoJFAaRzJHKJncABNozq7/r70JqrIOPq+q Vfbh1DhyAhKD0ZD6UKman6IZP0jUdPCjn0iuuw8KpOEZpxEzEnDEMnBuiZWKEGEqfmiY Euvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SmTH0IhtZH4ku7oSgcHQcfDWILw8y/E/1zJUqyWdqG0=; b=ePxe2U1xlJNhaob7XpaPeiJ8Q8EMB5lxCrOoLpuxDmziRrXZlc0ZACK47fZ8lyUgrM EnUPE2khxHAVdG3/lFEor8dZwr6GwxUq1qrB/wBwUph77OyrVY375RUm2XqIqRmEY1Iz xF2EVOls5vzG6uV6R0E8Odmdd6h1FaYnb6yo0uBAeMZRMqV73FjoSBp7zziDsZfLztm1 PxhZm/VCeZkC0mHuTUa7So4Yffald1aFG82q6hYlE45NAQsFBhoVmQGvNYrKJ+jW5Au9 zGyEJkJu55BXaTSkFYHwpFvEswxAniIszsUyMbrF4g5sd+MOvuSdGZFadrqD4TvNRBkl eAXw== X-Gm-Message-State: APzg51AU6KxtEAChpJJSYRHcRWgIsQHsVKVhFblrY79MXTaKOYpUM33a bLvgIVxuLLJirKNrfjKzTeGNp+uBd8w= X-Google-Smtp-Source: ANB0VdYpqpZ7+mq223Ont7Zz1++q7b1r9fC9Z4dC5Km+i15+ezVJvEJiXQXHRHdLSCv6QkM+5wHrHg== X-Received: by 2002:a19:7d84:: with SMTP id y126-v6mr14375749lfc.94.1536629545566; Mon, 10 Sep 2018 18:32:25 -0700 (PDT) From: Max Filippov To: qemu-devel@nongnu.org Date: Mon, 10 Sep 2018 18:32:11 -0700 Message-Id: <20180911013211.27340-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 Subject: [Qemu-devel] [PATCH] target/xtensa: fix s32c1i TCGMemOp flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Filippov , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" s32c1i must load and store value with target endianness, not host. This results in an infinite loop in atomic cmpxchg sequences when target endianness doesn't match host endianness. Fixes: 9fb40342d4b3 ("target/xtensa: support MTTCG") Cc: qemu-stable@nongnu.org Signed-off-by: Max Filippov Reviewed-by: Richard Henderson --- target/xtensa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 25399058a0db..c626583cd952 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -2288,7 +2288,7 @@ static void translate_s32c1i(DisasContext *dc, const = uint32_t arg[], gen_load_store_alignment(dc, 2, addr, true); gen_check_atomctl(dc, addr); tcg_gen_atomic_cmpxchg_i32(cpu_R[arg[0]], addr, cpu_SR[SCOMPARE1], - tmp, dc->cring, MO_32); + tmp, dc->cring, MO_TEUL); tcg_temp_free(addr); tcg_temp_free(tmp); } --=20 2.11.0