From nobody Wed Nov 5 20:17:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536622772955560.9546535035101; Mon, 10 Sep 2018 16:39:32 -0700 (PDT) Received: from localhost ([::1]:54607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzVmC-0006a8-AI for importer@patchew.org; Mon, 10 Sep 2018 19:39:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzVjm-0003UC-RU for qemu-devel@nongnu.org; Mon, 10 Sep 2018 19:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzVbU-0005LM-Hw for qemu-devel@nongnu.org; Mon, 10 Sep 2018 19:28:26 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60641) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzVbU-0005Jm-Ap for qemu-devel@nongnu.org; Mon, 10 Sep 2018 19:28:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0986F21F24; Mon, 10 Sep 2018 19:28:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 10 Sep 2018 19:28:22 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id B388AE4118; Mon, 10 Sep 2018 19:28:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=9xzDGhQBfkMKzb 8d1gDRfx3VsuHO5J5jltQ782rTgbk=; b=Pwyf5NCsc3iTw8oGTbbJ4D22kGTgwE I3Y+3vzoXQ7DtQW/fpOinxteNBbYAketpAvu1HNEYSZZyqA1//iu+WeiUvw4+lIn NpuKVGrZzjZf0Idc9T2oOEo/rNyXD+m49+ZiG0b/ZafUMjhLJmhwDW2nnw+cYXPu G5iKG6ZwVoo+k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=9xzDGhQBfkMKzb8d1gDRfx3VsuHO5J5jltQ782rTgbk=; b=vaM6ieRd FvfGSRUEfAmTTYRfRELgg+86WpHvvjK+bhy4J3Wl/2C7LXjruwa6YIKTtaiEL6cC WYmUXMyqYKwbbLXsBPbOKQYq8dYmg6sViRtu3p4QOf0dnOsZjlJqFghDDjEZB+U7 gNUNW3ziL2rKc5rsci1ttA5A+KgtgzdvCwu8N3N1vtQXKp/fJYICMoCdXa9Rn41A mBUXNaGaVuixaQJk7w30ljbQgfL8cfFPzF365JlZnl+QGkWL2VWv/GC7C1aqqlbu Qeovv16DlDVoCzvcMjs4SxGtpBnhvQQJJg2Po0VDO4qKRz3YtjjCiT0qoEXhwcba kc7RwkFCaJGF9w== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Mon, 10 Sep 2018 19:27:49 -0400 Message-Id: <20180910232752.31565-10-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180910232752.31565-1-cota@braap.org> References: <20180910232752.31565-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH v2 09/12] cpus: access .qemu_icount with atomic64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Peter Crosthwaite , Murilo Opsfelder Araujo , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Emilio G. Cota --- cpus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 38dabb138d..f045416c94 100644 --- a/cpus.c +++ b/cpus.c @@ -252,8 +252,8 @@ void cpu_update_icount(CPUState *cpu) =20 seqlock_write_lock(&timers_state.vm_clock_seqlock, &timers_state.vm_clock_lock); - atomic_set__nocheck(&timers_state.qemu_icount, - timers_state.qemu_icount + executed); + atomic_set_i64(&timers_state.qemu_icount, + timers_state.qemu_icount + executed); seqlock_write_unlock(&timers_state.vm_clock_seqlock, &timers_state.vm_clock_lock); } @@ -270,8 +270,8 @@ static int64_t cpu_get_icount_raw_locked(void) /* Take into account what has run */ cpu_update_icount(cpu); } - /* The read is protected by the seqlock, so __nocheck is okay. */ - return atomic_read__nocheck(&timers_state.qemu_icount); + /* The read is protected by the seqlock, but needs atomic64 to avoid U= B */ + return atomic_read_i64(&timers_state.qemu_icount); } =20 static int64_t cpu_get_icount_locked(void) --=20 2.17.1