From nobody Wed Nov 5 18:39:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=wdc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536185859458334.85988396515916; Wed, 5 Sep 2018 15:17:39 -0700 (PDT) Received: from localhost ([::1]:58290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxg7G-0007eO-99 for importer@patchew.org; Wed, 05 Sep 2018 18:17:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxg0Q-0001DG-1D for qemu-devel@nongnu.org; Wed, 05 Sep 2018 18:10:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxg0L-00041W-Kx for qemu-devel@nongnu.org; Wed, 05 Sep 2018 18:10:33 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:48173) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxg0L-0003le-4q for qemu-devel@nongnu.org; Wed, 05 Sep 2018 18:10:29 -0400 Received: from mail-by2nam01lp0184.outbound.protection.outlook.com (HELO NAM01-BY2-obe.outbound.protection.outlook.com) ([216.32.181.184]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2018 06:10:14 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.171) by BN6PR04MB0386.namprd04.prod.outlook.com (2603:10b6:404:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Wed, 5 Sep 2018 22:10:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1536185429; x=1567721429; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=xYGuRkJ1QXCJ77Fbcaf9wzqfmy4ZrgdVKMtyutItGpc=; b=EN5Ej0EBx/n4g8EUwUc0L86rNtrM2R9SFD9ODVlX7z6yuNbmZLE4cKuS LdBR+y4M49pi2jYB91f2Fi6rGumivDQPDLniekqYwrj3NXXdkwsu2mhwN BgjnkuxDKDbR+HB9n2q7w8b6AV3REHdbxjiHSrQuC7qvDY2yCStGb5xCm DB6LS64uj2xhcwUMBXUdlWR5s1i0uLfMLQ8kPROeFeWrQvrmVJGDWHRA6 /DvG26hjf2U82A92GJuNQnfu90Sr6y0xkhL/vMIFM7RwBPcvqQGlXsL2B 3lYvBGDrjihrXk7X3qy3DaagiQiwXOKZR9QYXtJFRGVc8HBvUua3h9jIw A==; X-IronPort-AV: E=Sophos;i="5.53,334,1531756800"; d="scan'208";a="93247428" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RWpSmPfpVxjYqENRZAI47YUa1dnejfhV7fkK77Is+nE=; b=SNLOZ/hTBaHJvLvje6npqpyN5izsctsohP+dVlW+7IaR8EdzSmAeQGGeYymY9uKFeby9GVPOVP6lOMbb1NdbR1IHeWDNVwDkB/UFC7jFdyYph3x4lDGHLtU8xbR3MXvQzXNMbV1Akhj5YY7hFNcMnaG7g7vf2CHHlo5LyKFwATg= From: Alistair Francis To: qemu-devel@nongnu.org Date: Wed, 5 Sep 2018 15:09:30 -0700 Message-Id: <20180905220932.6152-8-alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180905220932.6152-1-alistair.francis@wdc.com> References: <20180905220932.6152-1-alistair.francis@wdc.com> MIME-Version: 1.0 X-Originating-IP: [199.255.44.171] X-ClientProxiedBy: CO2PR06CA0060.namprd06.prod.outlook.com (2603:10b6:104:3::18) To BN6PR04MB0386.namprd04.prod.outlook.com (2603:10b6:404:91::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f9ca6d4-ea28-415b-3963-08d6137c5a10 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:BN6PR04MB0386; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 3:pW4wA+m48x7nIokscTm+IWxmO0/o0G/86fvSI9m+JZN+17ePgizwqIoNyIlxQfP3Fzk2pG3LhzMOoA72orBvoVG3keD8mg/KTbWaU+yhAOOHcD5nICs97E6oQaTNIoMiDcxwFZpC3fHxoxzkdVBe/RhJslakMp0D+pazmF7q/Ifh+gtr/GY2/pafV4xZ2gndygykN0xM8eG1/IirNtuTMYN7yNhlEejEsWLyyutPaDsYPaprNTOIHgkCM/jEwwzo; 25:TiH0hclaRDLnLtJjOjhNQJNXm0IHJnb3stWUUXV6uU53Ga9QNrfq+hmBCQbay0PVgpgUfkSQJWHoH4oZ3uGa0Q7dbHI993fjYXHuMN/1Ds2bdcuJfdaoHeufiYeD3JBgIgpQfNg7ZgKumGp+YDJUeH5WFo5ll6jEogEupOqFOM43Af0TnOz1d2Gyc5Lk97ypTySG+WHuYa5T9Ml1alrsCFXnuDpYiLOMrMP1pnbjCBBvQYHxvS69GA7CJEtp+5nQnz7MN5C9MycRBzIzINd75K1EOWigumcdG110HPLauJZGGzR3/k3Sk58yrzEBbsaTifTDP1XVyk2K2e39a29IJA==; 31:EHOlep6lvOvaSPTalA4VErGfJVVG8aPnvEZRJBssqFRp98fo/I3/zWSaRVjCS4h3agS5E8u6lcUBbiCReDtVaLtiUnVExbaBUuNjV76Qz1uwlAWb2CD0J4f2CViO4DjpFKkUdExOuBL1dI36TWGVPo5cmwEsjRZ9gXn/nMkCxGCTxWwZh4M7iedKPkhwoSdEStcYbHzwT5SiT2OQ4SLoEfJNrCHrKAe7Skte4jA4J8I= X-MS-TrafficTypeDiagnostic: BN6PR04MB0386: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 20:JPV3S33dV+VbwZ0M1cFqeKvvhhYuYse7OMrigaf0a1ORWLHViol3JcoascHvW9mEJ1PsumuWxo1sVW2ACGC+YChpaYZniJ68TYmRPuOb5eS55XyoZeINtOkwLnPrpDOqNiRX1JI1uq/t1w/rBp6vdPX5WllD+8TveiAVwpkV32N3rUoy9VETKD7rknaWBWz2PmjJSdu3yDxsqnIJ58kA9bW/pOPuwXMWAI5oOT6mA1yszMGumfV06BhhTzzG/YvapuSjHfEQYhcayJzNfI8lzo1BHyLESNGGfzt3cqYDTG4sbIqLnXUyLbrXdZKsKnGYsoP9Mau1l29CefmrZOlLMNgn9sLWxavKG8DmuAIBkVJRuXb6TvfWe2tWiWRlm6aCVq9e3a5oClAsl/XanvVzl/CyO/OrAs5WDmz6IvZ013gHziIn1rPDZP0YWcXLgDokWEr6tBZMc2NTkBBR6MHvZAkaIC/QeuAEpAw1B30NkPXTMiTeIK9SPbmEgRk4IOiK; 4:XSlYU2DcJk8kV9Xsh70kr8WiNy0sfqJf9G89kYtwsx2t9o2/ZsWZv2DS/3edA35DmWsi6KZh0k6WYr/iLFB+S1CLXkpwI/MRw+tGhM7Lfds2JqhPkKhOLqS2rlRwtCnJqPSB26FoSrmHUBskHO/g2skYVE9g6OW7O6pyY1S4tdNSMf7tTg8rQ8WeNTeX80aXRdtV1MFq9/7L7FrJDHeVv8xUGk27c+TtRPHER9gQbhkkxbFfLSiFiHS8h96eyBlmoOtissIBwfhOyHzRTnh/C1CCkWFlb3TH/Pa0eOufEo8Uga6AcOI8yA1ksIB/iggo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(10201501046)(3231344)(944501410)(52105095)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201708071742011)(7699016); SRVR:BN6PR04MB0386; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0386; X-Forefront-PRVS: 078693968A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(346002)(396003)(376002)(136003)(199004)(189003)(44832011)(53936002)(6512007)(86362001)(5660300001)(97736004)(6346003)(48376002)(6666003)(2906002)(6916009)(50466002)(386003)(6506007)(72206003)(186003)(26005)(1076002)(478600001)(36756003)(966005)(47776003)(66066001)(8676002)(16526019)(486006)(3846002)(68736007)(6486002)(6116002)(11346002)(956004)(2616005)(106356001)(105586002)(7736002)(2361001)(6306002)(4326008)(16586007)(476003)(76176011)(81156014)(81166006)(316002)(54906003)(8936002)(50226002)(2351001)(52116002)(51416003)(25786009)(305945005)(446003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0386; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0386; 23:HkSijiOzRa585idcVABrqxABq9rLKK7Qdpn1GaqHl?= =?us-ascii?Q?bGWpP2UG5UV3N7LwDgpeKs/ka523eO7FzsnIdlSWfgfTma8kVBQWf2SfNaeG?= =?us-ascii?Q?hwt94ECiL6r6cKf1ASKeZDhmzLdrMr2B+kIpJOMnZyleX4qKJ5KeL/byUKbl?= =?us-ascii?Q?d3BXhX8WEwcqQFERrRCht+lF6uJ83QNnka2nO9HmFMxN3bR4IYT7j9+k1VaM?= =?us-ascii?Q?OxgcIjOxKY3i2ryF89BuGq3ZM0MbV2gnV2CTpuIaxQ4aO27iz6U/PQbpuJN0?= =?us-ascii?Q?BEcZPct78Hb1PF4wqdTiDFXmyOFrVZuOm6cByVGlPRzGBOwsXNnJkgJqPur7?= =?us-ascii?Q?V2eSr7DAgYK6zgTNlfux4cdCgcDx899sZHKvd1WHcUTpHGWJWQe7jMQv6Ocf?= =?us-ascii?Q?R+lWJAmxzfslGoIoKhCdt8HLqhGpEd19KqcRPnd1SAcnO/Br+pWcbJ8KfhQo?= =?us-ascii?Q?Qz8fSO8exRfW8ypNJVThaYW7+PPg6sfiXkR8mLzl0VM4IOAd+74eepXBfas5?= =?us-ascii?Q?XoCDkNOxkOGhr1AXcRew7CnEdqitqnvJnlqBQqhGve4exrYGFbTe2vmkRMRI?= =?us-ascii?Q?qV6f0GVW3B3ryTF+EpwgE5JT/h3AgYiy45lrWvlhkWVWunBGaYYTptvWxXpK?= =?us-ascii?Q?bu+QjF24cpJabNYBGHiyTZOD3ajQv6QYJcfOgXELmC7E5jfb7keGPd3O1dIy?= =?us-ascii?Q?IWHWrF+y36Y00CpzpndZlUVuU05DKfE28QYLzRfbIP9Zyl86LolU/f5aIFQE?= =?us-ascii?Q?3neZ0UXlvPLhi3G7gtUhrONpZa8M5N8a8zcP8nyXzXVA4XL6UDhNlQ7d/FH+?= =?us-ascii?Q?AcCXQzUO3nV33MjNmtACwGsVu4YVrN3Db6GoIXUftxbu/i9acWgnEH7QDnjT?= =?us-ascii?Q?i6s+XV9a3wkth9+AyxvMeK2OSLv3HPvMmrw+J/1wOvu11IAD5bnen8biFFnK?= =?us-ascii?Q?7i6w/VMSFDZ5QgdXI4RI47vJNQ4Tfg3nFh3JtP31oXoQTDL/F6RfRcylsY66?= =?us-ascii?Q?27AwzdHGjpyp1hXh6EQ8+JnEoc4XypHf6qjXwvZ0YKDt1ZlXw7f8AfUIuhgt?= =?us-ascii?Q?4JFBX8eLo30wugCSzRhZf7NdmjFcQi+NTgvDP9LBqroIPDLjRRbs/nI2mcsX?= =?us-ascii?Q?V/W3jetw+fANG/32vr/nzVFBgV9AoMAhzGrBWiszl2E9/em56XsRPkaY+SEN?= =?us-ascii?Q?l6JkqosIwF+zIZnE1TGxXwRRNGSR8N8hjLQ9OkE0hVJiA1za9/ClaFmT7B56?= =?us-ascii?Q?unNMSvGgdjgiBR8x2I/pmjWLpxAnl898Of5coUFDALB8Mm0pHCUtQ/CyGatT?= =?us-ascii?Q?eoTYLTtZsDMJxBuwns23OtDnA3EV/9neGYihfEsMkeK?= X-Microsoft-Antispam-Message-Info: PG1fMjZ6qYot73C52cssci1W6SOnD0m8H0z5lXYgrMHlmDHJsca9h5BVemMOQRzbc3k3fyxZLAb3MZh9EjW349cceq1pqrULRMrR6Usa+Yo5LFdlm1B0HIu5wb5XJzcYBlnLxGg8EZfOShphArQf9o9USezItk3mMpcCrkEHqNyxPu4uGV7RZYrAVmacfRLOn51KMYtuqb0sdb8qUFxhoAelksHNRCryhC0dmcRYRIRjIqvm0Gy0E1/uOzREyghx0eWT5zovNWnOkwEeN2me4DiFwcAW28g8WFxy3l1JYHuaWwpBJtzwwzn0ULagGcC2mZZf/fWXZqP352PDr23R6oCVBRiQpc8BwBqZYV6n0U4= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 6:+mOxnzRZYF1agclY6fnZwUcHcBjLD5V3Z3JCXfg133iIPSZzvrZoy5vLwGWVqbS7/DRXhyZAnUlM2dZAMpNGFtRdk8ACUSSrB32Hp0i5tQUHdxRMlgMTsz7QXzVaLdew1lEcGiGJLpzwmevVwkuoNqk0aPw5dTbvDUYRl1wLPqNlbP4ZnO9UXjSfzUiiMtxWAmEPrqfDqeoLLQWHAzDHiXPlXBz/ToszcKdzsJoIVW4Wo30vWxc71B1xTNlDQPyIDXSF0dNRk601Y7qE1L+T5MJ5D6NP3bhPKvsmDtnZ1aN5lkJCZT+i8Vtoai8UY+6uf7txKFbwqqoBUjZEc7TQt2dO2HpnZAIXuFpHXegEbK9YH0NNRK/afMAgUdhIclcTccL4exWSx8f/skTm9818tRfL+YOwkO73iiNHtWjR/QygQwOsBXBY9/PiQ/DdNXndAEsuTn/rMjUk6ozdb58KGQ==; 5:S1aagC5a9okhud/11Hv/7VMhcylO85Y57h6wxbWOXzRGXA5XOZ1zZPwn/bjmDkzTczze57lBr3sQ7y7ncGrI0tNpTG8epLa4HPytbNTrIYtqEQUDlO6ih3uz0kDWW/3/NKhCjFo0ND3QKXvB5+TzYrV0ZxFu32+2G/R5fbFRdU8=; 7:0C3Cmztphl9K9P14hlcYLRdFye9xbdORNvZnwv0rN+z9d8UBOnAtN5PElPpMhzjIpfbRwteKijVvsP/Yl8TJQ71WZQARHpVRpsdHA3kt7+EZA84fuWEJzMjkmXrNd/tTXdvrzG1oHDUJJrvZafZz0WbKobx19AjARM81mrM1AJcCEkBqWSH2SImpyODzZyk8cTN2bAMHSnhI5mP/TK6JnL7eSTkW2XQ+KUAhYdHPuiZOJsdWhI2q6CcIr+r4cb9r SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2018 22:10:12.2388 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9ca6d4-ea28-415b-3963-08d6137c5a10 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0386 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.141 Subject: [Qemu-devel] [PULL v2 07/10] target/riscv: call gen_goto_tb on DISAS_TOO_MANY X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , Alistair Francis Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" Performance impact of this and the previous commits, measured with the very-easy-to-cross-compile rv8-bench: https://github.com/rv8-io/rv8-bench Host: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz - Key: before: master after1,2,3: the 3 commits in this series (i.e. 3 is this commit) - User-mode: bench before after1 after2 after3 final speedup --------------------------------------------------------- aes 1.12s 1.12s 1.10s 1.00s 1.12 bigint 0.78s 0.78s 0.78s 0.78s 1 dhrystone 0.96s 0.97s 0.49s 0.49s 1.9591837 miniz 1.94s 1.94s 1.88s 1.86s 1.0430108 norx 0.51s 0.51s 0.49s 0.48s 1.0625 primes 0.85s 0.85s 0.84s 0.84s 1.0119048 qsort 4.87s 4.88s 1.86s 1.86s 2.6182796 sha512 0.76s 0.77s 0.64s 0.64s 1.1875 (after1 only applies to softmmu, so no surprises here) - Full-system (fedora): bench before after1 after2 after3 final speedup --------------------------------------------------------- aes 2.68s 2.54s 2.60s 2.34s 1.1452991 bigint 1.61s 1.56s 1.55s 1.64s 0.98170732 dhrystone 1.78s 1.67s 1.25s 1.24s 1.4354839 miniz 3.53s 3.35s 3.28s 3.35s 1.0537313 norx 1.13s 1.09s 1.07s 1.06s 1.0660377 primes 15.37s 15.41s 15.20s 15.37s 1 qsort 7.20s 6.71s 3.85s 3.96s 1.8181818 sha512 1.07s 1.04s 0.90s 0.90s 1.1888889 SoftMMU slows things down, so the numbers are less sensitive. Cross-page jumps improve things a little bit, though. Note that I'm not showing here averages, just results from a single run, so with primes there isn't much to worry about. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alistair Francis --- target/riscv/translate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 66a80ca772..18d7b6d147 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1868,12 +1868,7 @@ static void riscv_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cpu) =20 switch (ctx->base.is_jmp) { case DISAS_TOO_MANY: - tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next); - if (ctx->base.singlestep_enabled) { - gen_exception_debug(); - } else { - tcg_gen_exit_tb(NULL, 0); - } + gen_goto_tb(ctx, 0, ctx->base.pc_next); break; case DISAS_NORETURN: break; --=20 2.17.1