From nobody Wed Nov 5 08:20:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535848556118392.984619463444; Sat, 1 Sep 2018 17:35:56 -0700 (PDT) Received: from localhost ([::1]:38886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwGMt-00032V-6B for importer@patchew.org; Sat, 01 Sep 2018 20:35:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwGL8-0001aO-J5 for qemu-devel@nongnu.org; Sat, 01 Sep 2018 20:34:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwGL7-0003Te-Uy for qemu-devel@nongnu.org; Sat, 01 Sep 2018 20:34:06 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:42037) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fwGL7-0003RS-Pj; Sat, 01 Sep 2018 20:34:05 -0400 Received: by mail-qt0-x242.google.com with SMTP id z8-v6so18463013qto.9; Sat, 01 Sep 2018 17:34:05 -0700 (PDT) Received: from WAL-L-PZ01.rocketsoftware.com (inet-64-112-177-9.bos.netblazr.com. [64.112.177.9]) by smtp.gmail.com with ESMTPSA id i125-v6sm8426810qke.36.2018.09.01.17.34.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 17:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9G3br1g2cttPzUwdsVYECrJcOgamyZnXPHXNPL4GsxU=; b=gF3LDEUXdBXdwu316ihkEJNCKyg92sKDNSmNIDl/EvnuKDC+jgk/EPswqErVzfP6/f DbPEYl1g+nucGFhQH0WX96fsD8WEaKFK2n5XRLAkEJ1dNGZfMMPhDd8yENwQ2qb9CHnl vC87ZMG3gOM4eS1rc/QNB/MsJOYf/BrF0HUjnSLuS5BLbGvsHMMcG9gJa/7pRKepnGaH wSl/QUKeQjZHbz0GoRXAhUZjri6DBpztbFV2AKXIIhh5C0YHcK7YrYdPkF/DQfrdqjoH ThLwvqgXaERKze3NcQq38tPxtTkfmnK3w0KEBKUnKIkjIkcDlzAudslzlPMva/DGX784 SsfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9G3br1g2cttPzUwdsVYECrJcOgamyZnXPHXNPL4GsxU=; b=iWh2sT5E7xJqhT/JoUGTgbmfFb8lHAe6pGq+kCq2VrDr57xMrBR5013I8LW4pup69B 2Z9XcQp26p8tmTas/RzkG+bfyD4LmpqhKbu04J2is2WDsMA1cq/rq8asYT5TyvgMQ5Ny Ra0jaIOaJq8rXq8TUvVXs3mmi1DMvqTy0a0fh/nAPzLtrHjsomL1fGQlyQXBvNQgsVNs NUsNwYPnaKw5hyP9MjjQd/D6RVO9GtGomzuafDfx4lGBC9W9MpQa8tGjbjA2GfudGu03 dgJj925CbyAZjz07/rwvAxKgaYL/m7JAQ66LcNdBdG8GnhzhvMAgXgYFJax5kyWFZ78t SAYA== X-Gm-Message-State: APzg51Amgm03YcePDNTTzsf2QvcWe7V23ml109NI7X56C2xBwjzY3ZlI BQ+Wcij1nR9e5PDDWFMO5oGOir1fhRo= X-Google-Smtp-Source: ANB0VdaxI7O1NbzLFKXIFY5CQ+4Q0bs+D0fzREsYHG2pR8JPcAvhSRNqFj6iwqbX2BgFuXoDX+UpSw== X-Received: by 2002:aed:2417:: with SMTP id r23-v6mr21417011qtc.172.1535848445164; Sat, 01 Sep 2018 17:34:05 -0700 (PDT) From: Pavel Zbitskiy To: qemu-devel@nongnu.org Date: Sat, 1 Sep 2018 20:33:21 -0400 Message-Id: <20180902003322.3428-3-pavel.zbitskiy@gmail.com> In-Reply-To: <20180902003322.3428-1-pavel.zbitskiy@gmail.com> References: <20180902003322.3428-1-pavel.zbitskiy@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v5 2/3] target/s390x: exception on non-aligned LPSW(E) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Zbitskiy , david@redhat.com, cohuck@redhat.com, richard.henderson@linaro.org, Alexander Graf , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Both LPSW and LPSWE should raise a specification exception when their operand is not doubleword aligned. Signed-off-by: Pavel Zbitskiy Reviewed-by: David Hildenbrand --- target/s390x/translate.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 7363aabf3a..59b1e5893c 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -2835,7 +2835,8 @@ static DisasJumpType op_lpsw(DisasContext *s, DisasOp= s *o) =20 t1 =3D tcg_temp_new_i64(); t2 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld32u(t1, o->in2, get_mem_index(s)); + tcg_gen_qemu_ld_i64(t1, o->in2, get_mem_index(s), + MO_TEUL | MO_ALIGN_8); tcg_gen_addi_i64(o->in2, o->in2, 4); tcg_gen_qemu_ld32u(t2, o->in2, get_mem_index(s)); /* Convert the 32-bit PSW_MASK into the 64-bit PSW_MASK. */ @@ -2855,7 +2856,8 @@ static DisasJumpType op_lpswe(DisasContext *s, DisasO= ps *o) =20 t1 =3D tcg_temp_new_i64(); t2 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld64(t1, o->in2, get_mem_index(s)); + tcg_gen_qemu_ld_i64(t1, o->in2, get_mem_index(s), + MO_TEQ | MO_ALIGN_8); tcg_gen_addi_i64(o->in2, o->in2, 8); tcg_gen_qemu_ld64(t2, o->in2, get_mem_index(s)); gen_helper_load_psw(cpu_env, t1, t2); --=20 2.18.0