From nobody Wed Nov 5 18:37:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535812435284174.9010000544664; Sat, 1 Sep 2018 07:33:55 -0700 (PDT) Received: from localhost ([::1]:37382 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw6yI-0007Z5-5z for importer@patchew.org; Sat, 01 Sep 2018 10:33:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw6py-0005sK-GH for qemu-devel@nongnu.org; Sat, 01 Sep 2018 10:25:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fw6pC-000654-Ki for qemu-devel@nongnu.org; Sat, 01 Sep 2018 10:24:31 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51182 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fw6p9-00061T-8P; Sat, 01 Sep 2018 10:24:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6111885748; Sat, 1 Sep 2018 14:24:26 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-157.ams2.redhat.com [10.36.116.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A76C2166B41; Sat, 1 Sep 2018 14:24:24 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Date: Sat, 1 Sep 2018 16:23:10 +0200 Message-Id: <20180901142312.11662-19-eric.auger@redhat.com> In-Reply-To: <20180901142312.11662-1-eric.auger@redhat.com> References: <20180901142312.11662-1-eric.auger@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 01 Sep 2018 14:24:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 01 Sep 2018 14:24:26 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'eric.auger@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [RFC 18/20] target/arm/kvm: Notifies IOMMU on MSI stage 1 binding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yi.l.liu@intel.com, cdall@kernel.org, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, alex.williamson@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When the MSI route is setup, we know the MSI IOVA and the doorbell GPA . At that point we can communicate this guest stage 1 binding to the host. Then the host will be able to construct a stage 2 binding taking as input address the doorbell GPA. We also directly use the iommu memory region translate() callback as the addr_mask is returned in IOTLB entry. address_space_translate does not return this information. Signed-off-by: Eric Auger --- TODO: access to as->root field may be cleaned later on --- target/arm/kvm.c | 46 ++++++++++++++++++++-------------------------- 1 file changed, 20 insertions(+), 26 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 65f867d569..6f905215b8 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -661,41 +661,35 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_e= ntry *route, uint64_t address, uint32_t data, PCIDevice *d= ev) { AddressSpace *as =3D pci_device_iommu_address_space(dev); - hwaddr xlat, len, doorbell_gpa; - MemoryRegionSection mrs; - MemoryRegion *mr; - int ret =3D 1; + IOMMUMemoryRegionClass *imrc; + IOMMUMemoryRegion *iommu_mr; + IOMMUTLBEntry entry; =20 if (as =3D=3D &address_space_memory) { return 0; } =20 + iommu_mr =3D IOMMU_MEMORY_REGION(as->root); + imrc =3D memory_region_get_iommu_class_nocheck(iommu_mr); + /* MSI doorbell address is translated by an IOMMU */ =20 rcu_read_lock(); - mr =3D address_space_translate(as, address, &xlat, &len, true, - MEMTXATTRS_UNSPECIFIED); - if (!mr) { - goto unlock; - } - mrs =3D memory_region_find(mr, xlat, 1); - if (!mrs.mr) { - goto unlock; - } - - doorbell_gpa =3D mrs.offset_within_address_space; - memory_region_unref(mrs.mr); - - route->u.msi.address_lo =3D doorbell_gpa; - route->u.msi.address_hi =3D doorbell_gpa >> 32; - - trace_kvm_arm_fixup_msi_route(address, doorbell_gpa); - - ret =3D 0; - -unlock: + entry =3D imrc->translate(iommu_mr, address, IOMMU_WO, 0); rcu_read_unlock(); - return ret; + + if (entry.perm =3D=3D IOMMU_NONE) { + return -ENOENT; + } + + route->u.msi.address_lo =3D entry.translated_addr; + route->u.msi.address_hi =3D entry.translated_addr >> 32; + + memory_region_iotlb_notify_iommu(iommu_mr, 0, entry); + + trace_kvm_arm_fixup_msi_route(address, entry.translated_addr); + + return 0; } =20 int kvm_arch_add_msi_route_post(struct kvm_irq_routing_entry *route, --=20 2.17.1