From nobody Wed Nov 5 18:33:13 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153580658943441.03959805937643; Sat, 1 Sep 2018 05:56:29 -0700 (PDT) Received: from localhost ([::1]:37085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw5S0-0006Wy-C9 for importer@patchew.org; Sat, 01 Sep 2018 08:56:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw5JZ-00068L-5v for qemu-devel@nongnu.org; Sat, 01 Sep 2018 08:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fw5JY-0007y3-5S for qemu-devel@nongnu.org; Sat, 01 Sep 2018 08:47:45 -0400 Received: from greensocs.com ([193.104.36.180]:40645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fw5JQ-0007kS-RO; Sat, 01 Sep 2018 08:47:37 -0400 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id C1D60DFFED; Sat, 1 Sep 2018 14:47:12 +0200 (CEST) Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IcFmYGyFwRrk; Sat, 1 Sep 2018 14:47:12 +0200 (CEST) Received: by greensocs.com (Postfix, from userid 998) id 02DF0521AAF; Sat, 1 Sep 2018 14:47:11 +0200 (CEST) Received: from michell-laptop.home.lmichel.fr (LFbn-LYO-1-488-36.w2-7.abo.wanadoo.fr [2.7.77.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 6075A521A9F; Sat, 1 Sep 2018 14:47:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1535806032; bh=H1BEeWZcXbhpNd6Me1rhtl3y8JK99Adxfg+psjia9g8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ukYnZFYp/m8aMitDU5I110umm6Sq3g4kVo+CS6vmkfZw3VjmApC4misij0J2D8isf HTMr+DmPX5BPwLMS8EtmuMZIvo12uvHIwvwN966LHHunCDmekyYs+Ws/pgUslyb4w8 PQWDAqYzqbOcy65DKS1rtwArmkaRXOz7a4Ev8row= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=ukYnZFYp; dkim=pass (1024-bit key) header.d=greensocs.com header.b=gp8rMuTe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1535806032; bh=H1BEeWZcXbhpNd6Me1rhtl3y8JK99Adxfg+psjia9g8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ukYnZFYp/m8aMitDU5I110umm6Sq3g4kVo+CS6vmkfZw3VjmApC4misij0J2D8isf HTMr+DmPX5BPwLMS8EtmuMZIvo12uvHIwvwN966LHHunCDmekyYs+Ws/pgUslyb4w8 PQWDAqYzqbOcy65DKS1rtwArmkaRXOz7a4Ev8row= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1535806031; bh=H1BEeWZcXbhpNd6Me1rhtl3y8JK99Adxfg+psjia9g8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gp8rMuTeJuLIoqJuROxNAfp1M4KSTljWUBQixpGux9BCAiOKracORZl8uGZlBVEWs BwWVDtLbyuHANmkNZxdcCx7WujxHfpxn0Htw70bkBXGxCDeupqeB5vZQXhI5t7J/Uj i+c6rPxO8ntYxCMPLWwL7G5b2nbp5V1+ejXv29bA= From: Luc Michel To: qemu-devel@nongnu.org Date: Sat, 1 Sep 2018 14:46:37 +0200 Message-Id: <20180901124639.19735-14-luc.michel@greensocs.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180901124639.19735-1-luc.michel@greensocs.com> References: <20180901124639.19735-1-luc.michel@greensocs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH 13/15] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , alistair@alistair23.me, mark.burton@greensocs.com, saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When gdb_set_stop_cpu() is called with a CPU associated to a process currently not attached by the GDB client, return without modifying the stop CPU. Otherwise, GDB get confused if it receives packets with a thread-id it does not know about. Signed-off-by: Luc Michel --- gdbstub.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 36ed7081ea..6a55bf2785 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1759,10 +1759,19 @@ static int gdb_handle_packet(GDBState *s, const cha= r *line_buf) return RS_IDLE; } =20 void gdb_set_stop_cpu(CPUState *cpu) { + GDBProcess *p =3D gdb_get_cpu_process(gdbserver_state, cpu); + + if (!p->attached) { + /* Having a stop CPU corresponding to a process that is not attach= ed + * confuses GDB. So we ignore the request. + */ + return; + } + gdbserver_state->c_cpu =3D cpu; gdbserver_state->g_cpu =3D cpu; } =20 #ifndef CONFIG_USER_ONLY --=20 2.18.0