From nobody Wed Nov 5 14:58:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535183354926311.62925508087085; Sat, 25 Aug 2018 00:49:14 -0700 (PDT) Received: from localhost ([::1]:44908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftTJg-0006Q3-5l for importer@patchew.org; Sat, 25 Aug 2018 03:49:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftTIV-0005z0-BS for qemu-devel@nongnu.org; Sat, 25 Aug 2018 03:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftTIQ-0000nG-C7 for qemu-devel@nongnu.org; Sat, 25 Aug 2018 03:47:51 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:33053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ftTIQ-0000lL-5J for qemu-devel@nongnu.org; Sat, 25 Aug 2018 03:47:46 -0400 Received: by mail-wr1-x444.google.com with SMTP id v90-v6so9228892wrc.0 for ; Sat, 25 Aug 2018 00:47:45 -0700 (PDT) Received: from donizetti.lan (dynamic-adsl-78-12-184-59.clienti.tiscali.it. [78.12.184.59]) by smtp.gmail.com with ESMTPSA id z101-v6sm14977593wrb.55.2018.08.25.00.47.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Aug 2018 00:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=h++tVJe+HQv91XyrGRX90bDVSfKX0IdyE9uGd2DVPIA=; b=Spx2AmCX4LNHWEFq00NdHaQD08WMcYnwcA6aF9+SeXkjPYK646unaVackNf7OkAehd tvI7TqnQJSZV9TiaWk5a+EbL+It+DUuXjnmJnkEu77UDkzoC+fSlTdercUrUyJe8gtT7 kKqxlZYYMh6NZXMkL352g8nX/tJWvT5GdNbLVZzVBKLC9x7xb4ud0114AAohh2b7qfrN RDUZPPar09w8K7TyGsffGppoLH6KQ3nmdNvEP5vEHtmHdm7dGA5a/pe+df7j1pWRSgPB GujFKvpPcUs9QHzrGmdDylMuxsvjKKKXMwNAZjDy92L0AHQeyb/PjeJmolqYfIBJS6Sk +BsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=h++tVJe+HQv91XyrGRX90bDVSfKX0IdyE9uGd2DVPIA=; b=bAr0GifDux1spLTySbAhX6JVwnBHLItXpQtWH5Vx7td3lAXldMOrSe/tsiXW3WvTyL JcrkVcQc0LHVWtBqaecTJlKCeb+dj7JaGN2eTPWVTlxFTae6Fd8csWTMHDA2KcL5gWri EPhwHMu52G/C2vtJCVypd+iVU2LxZLNliJjvRvELuKuFYewyp0MyYy35quzzjwesaPhL +Grz0egLjcYR0cH9P3YdFf/xBcN590h1dmq1mQldD2TFhEn7nDMJunq6DBlg8MERq+zn uDrqmw3CpK7ML5pH2JX1SIwmo9LYnO9ij+JXM1shvAgqZrT/yPHe3kdRH6LD4r9zGJ14 QBVw== X-Gm-Message-State: APzg51CKigMLaC5vh13ixXvLShtCoMSxewRDhBUy7Jo0k/cW3bWWl5M/ 6ugPJevjDZpG8nnlT4wZpJfDTLYo X-Google-Smtp-Source: ANB0VdZSeD1H/4eQG5dH52WTD9dabR0rI3IJd7OiWaCKUjTbVWspbeCvHmSI4grRFmRK4u1Nvqk/8w== X-Received: by 2002:a5d:4e0a:: with SMTP id p10-v6mr3266788wrt.48.1535183264633; Sat, 25 Aug 2018 00:47:44 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 25 Aug 2018 09:47:42 +0200 Message-Id: <20180825074742.15963-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH] es1370: fix ADC_FRAMEADR and ADC_FRAMECNT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" They are not consecutive with DAC1_FRAME* and DAC2_FRAME*. Fixes: 154c1d1f960c5147a3f8ef00907504112f271cd8 Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c index dd75c9e8f5..4f980a598b 100644 --- a/hw/audio/es1370.c +++ b/hw/audio/es1370.c @@ -506,10 +506,13 @@ static void es1370_write(void *opaque, hwaddr addr, u= int64_t val, unsigned size) d - &s->chan[0], val >> 16, (val & 0xffff)); break; =20 + case ES1370_REG_ADC_FRAMEADR: + d +=3D 2; + goto frameadr; case ES1370_REG_DAC1_FRAMEADR: case ES1370_REG_DAC2_FRAMEADR: - case ES1370_REG_ADC_FRAMEADR: d +=3D (addr - ES1370_REG_DAC1_FRAMEADR) >> 3; + frameadr: d->frame_addr =3D val; ldebug ("chan %td frame address %#x\n", d - &s->chan[0], val); break; @@ -521,10 +524,13 @@ static void es1370_write(void *opaque, hwaddr addr, u= int64_t val, unsigned size) lwarn ("writing to phantom frame address %#x\n", val); break; =20 + case ES1370_REG_ADC_FRAMECNT: + d +=3D 2; + goto framecnt; case ES1370_REG_DAC1_FRAMECNT: case ES1370_REG_DAC2_FRAMECNT: - case ES1370_REG_ADC_FRAMECNT: d +=3D (addr - ES1370_REG_DAC1_FRAMECNT) >> 3; + framecnt: d->frame_cnt =3D val; d->leftover =3D 0; ldebug ("chan %td frame count %d, buffer size %d\n", --=20 2.17.1