From nobody Wed Nov 5 16:36:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535139291403709.881055804114; Fri, 24 Aug 2018 12:34:51 -0700 (PDT) Received: from localhost ([::1]:43192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftHqz-0003Yb-GO for importer@patchew.org; Fri, 24 Aug 2018 15:34:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftHog-0002GM-Me for qemu-devel@nongnu.org; Fri, 24 Aug 2018 15:32:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftHoe-0001f0-Ge for qemu-devel@nongnu.org; Fri, 24 Aug 2018 15:32:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56382 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ftHoc-0001Y1-4d for qemu-devel@nongnu.org; Fri, 24 Aug 2018 15:32:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8A3E8780F for ; Fri, 24 Aug 2018 19:32:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-97.ams2.redhat.com [10.36.116.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD1892156701 for ; Fri, 24 Aug 2018 19:32:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8A6BE1132BD1; Fri, 24 Aug 2018 21:32:06 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 24 Aug 2018 21:31:11 +0200 Message-Id: <20180824193206.25475-4-armbru@redhat.com> In-Reply-To: <20180824193206.25475-1-armbru@redhat.com> References: <20180824193206.25475-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 24 Aug 2018 19:32:07 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 24 Aug 2018 19:32:07 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL 03/58] check-qjson: Cover blank and lexically erroneous input X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" qobject_from_json() can return null without setting an error on lexical errors. I call that a bug. Add test coverage to demonstrate it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20180823164025.12553-4-armbru@redhat.com> --- tests/check-qjson.c | 40 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index cc952c56ea..4daadc272b 100644 --- a/tests/check-qjson.c +++ b/tests/check-qjson.c @@ -1307,8 +1307,40 @@ static void simple_varargs(void) =20 static void empty_input(void) { - const char *empty =3D ""; - QObject *obj =3D qobject_from_json(empty, &error_abort); + QObject *obj =3D qobject_from_json("", &error_abort); + g_assert(obj =3D=3D NULL); +} + +static void blank_input(void) +{ + QObject *obj =3D qobject_from_json("\n ", &error_abort); + g_assert(obj =3D=3D NULL); +} + +static void junk_input(void) +{ + /* Note: junk within strings is covered elsewhere */ + Error *err =3D NULL; + QObject *obj; + + obj =3D qobject_from_json("@", &err); + g_assert(!err); /* BUG */ + g_assert(obj =3D=3D NULL); + + obj =3D qobject_from_json("[0\xFF]", &err); + error_free_or_abort(&err); + g_assert(obj =3D=3D NULL); + + obj =3D qobject_from_json("00", &err); + g_assert(!err); /* BUG */ + g_assert(obj =3D=3D NULL); + + obj =3D qobject_from_json("[1e", &err); + g_assert(!err); /* BUG */ + g_assert(obj =3D=3D NULL); + + obj =3D qobject_from_json("truer", &err); + error_free_or_abort(&err); g_assert(obj =3D=3D NULL); } =20 @@ -1462,7 +1494,9 @@ int main(int argc, char **argv) =20 g_test_add_func("/varargs/simple_varargs", simple_varargs); =20 - g_test_add_func("/errors/empty_input", empty_input); + g_test_add_func("/errors/empty", empty_input); + g_test_add_func("/errors/blank", blank_input); + g_test_add_func("/errors/junk", junk_input); g_test_add_func("/errors/unterminated/string", unterminated_string); g_test_add_func("/errors/unterminated/escape", unterminated_escape); g_test_add_func("/errors/unterminated/sq_string", unterminated_sq_stri= ng); --=20 2.17.1