From nobody Wed Nov 5 16:42:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535130576982960.4935382293389; Fri, 24 Aug 2018 10:09:36 -0700 (PDT) Received: from localhost ([::1]:42746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftFaY-0001IS-RN for importer@patchew.org; Fri, 24 Aug 2018 13:09:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftFVs-00057l-Et for qemu-devel@nongnu.org; Fri, 24 Aug 2018 13:04:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftFVr-0007u2-Fu for qemu-devel@nongnu.org; Fri, 24 Aug 2018 13:04:44 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:44922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ftFVq-0007ZW-Tt for qemu-devel@nongnu.org; Fri, 24 Aug 2018 13:04:43 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1ftFVb-0006yE-6v; Fri, 24 Aug 2018 18:04:27 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 24 Aug 2018 18:04:21 +0100 Message-Id: <20180824170422.5783-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180824170422.5783-1-peter.maydell@linaro.org> References: <20180824170422.5783-1-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH 2/3] hw/nvram/fw_cfg: Use memberwise copy of MemoryRegionOps struct X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We've now removed the 'old_mmio' member from MemoryRegionOps, so we can perform the copy as a simple struct copy rather than having to do it via a memberwise copy. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/nvram/fw_cfg.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index d79a568f540..b3c9b066239 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1109,12 +1109,7 @@ static void fw_cfg_mem_realize(DeviceState *dev, Err= or **errp) sysbus_init_mmio(sbd, &s->ctl_iomem); =20 if (s->data_width > data_ops->valid.max_access_size) { - /* memberwise copy because the "old_mmio" member is const */ - s->wide_data_ops.read =3D data_ops->read; - s->wide_data_ops.write =3D data_ops->write; - s->wide_data_ops.endianness =3D data_ops->endianness; - s->wide_data_ops.valid =3D data_ops->valid; - s->wide_data_ops.impl =3D data_ops->impl; + s->wide_data_ops =3D *data_ops; =20 s->wide_data_ops.valid.max_access_size =3D s->data_width; s->wide_data_ops.impl.max_access_size =3D s->data_width; --=20 2.18.0