From nobody Sun Apr 27 05:17:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1535104344006771.5300600402367; Fri, 24 Aug 2018 02:52:24 -0700 (PDT) Received: from localhost ([::1]:40747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>) id 1ft8lT-0006YF-1F for importer@patchew.org; Fri, 24 Aug 2018 05:52:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1ft8Tq-0007GE-Gx for qemu-devel@nongnu.org; Fri, 24 Aug 2018 05:34:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1ft8Tp-0003nQ-Bh for qemu-devel@nongnu.org; Fri, 24 Aug 2018 05:34:10 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:44878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <pm215@archaic.org.uk>) id 1ft8Tp-0003jk-23 for qemu-devel@nongnu.org; Fri, 24 Aug 2018 05:34:09 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from <pm215@archaic.org.uk>) id 1ft8To-0006Tq-3g for qemu-devel@nongnu.org; Fri, 24 Aug 2018 10:34:08 +0100 From: Peter Maydell <peter.maydell@linaro.org> To: qemu-devel@nongnu.org Date: Fri, 24 Aug 2018 10:33:10 +0100 Message-Id: <20180824093343.11346-20-peter.maydell@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180824093343.11346-1-peter.maydell@linaro.org> References: <20180824093343.11346-1-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 19/52] hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org> X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The MPS2 FPGAIO block includes some simple free-running counters. Implement these. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20180820141116.9118-2-peter.maydell@linaro.org --- include/hw/misc/mps2-fpgaio.h | 4 +++ hw/misc/mps2-fpgaio.c | 53 ++++++++++++++++++++++++++++++++++- 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/include/hw/misc/mps2-fpgaio.h b/include/hw/misc/mps2-fpgaio.h index eedf17ebc6d..ec057d38c76 100644 --- a/include/hw/misc/mps2-fpgaio.h +++ b/include/hw/misc/mps2-fpgaio.h @@ -38,6 +38,10 @@ typedef struct { uint32_t misc; =20 uint32_t prescale_clk; + + /* These hold the CLOCK_VIRTUAL ns tick when the CLK1HZ/CLK100HZ was z= ero */ + int64_t clk1hz_tick_offset; + int64_t clk100hz_tick_offset; } MPS2FPGAIO; =20 #endif diff --git a/hw/misc/mps2-fpgaio.c b/hw/misc/mps2-fpgaio.c index 7394a057d82..bbc28f641f0 100644 --- a/hw/misc/mps2-fpgaio.c +++ b/hw/misc/mps2-fpgaio.c @@ -22,6 +22,7 @@ #include "hw/sysbus.h" #include "hw/registerfields.h" #include "hw/misc/mps2-fpgaio.h" +#include "qemu/timer.h" =20 REG32(LED0, 0) REG32(BUTTON, 8) @@ -32,10 +33,21 @@ REG32(PRESCALE, 0x1c) REG32(PSCNTR, 0x20) REG32(MISC, 0x4c) =20 +static uint32_t counter_from_tickoff(int64_t now, int64_t tick_offset, int= frq) +{ + return muldiv64(now - tick_offset, frq, NANOSECONDS_PER_SECOND); +} + +static int64_t tickoff_from_counter(int64_t now, uint32_t count, int frq) +{ + return now - muldiv64(count, NANOSECONDS_PER_SECOND, frq); +} + static uint64_t mps2_fpgaio_read(void *opaque, hwaddr offset, unsigned siz= e) { MPS2FPGAIO *s =3D MPS2_FPGAIO(opaque); uint64_t r; + int64_t now; =20 switch (offset) { case A_LED0: @@ -54,10 +66,15 @@ static uint64_t mps2_fpgaio_read(void *opaque, hwaddr o= ffset, unsigned size) r =3D s->misc; break; case A_CLK1HZ: + now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + r =3D counter_from_tickoff(now, s->clk1hz_tick_offset, 1); + break; case A_CLK100HZ: + now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + r =3D counter_from_tickoff(now, s->clk100hz_tick_offset, 100); + break; case A_COUNTER: case A_PSCNTR: - /* These are all upcounters of various frequencies. */ qemu_log_mask(LOG_UNIMP, "MPS2 FPGAIO: counters unimplemented\n"); r =3D 0; break; @@ -76,6 +93,7 @@ static void mps2_fpgaio_write(void *opaque, hwaddr offset= , uint64_t value, unsigned size) { MPS2FPGAIO *s =3D MPS2_FPGAIO(opaque); + int64_t now; =20 trace_mps2_fpgaio_write(offset, value, size); =20 @@ -100,6 +118,14 @@ static void mps2_fpgaio_write(void *opaque, hwaddr off= set, uint64_t value, "MPS2 FPGAIO: MISC control bits unimplemented\n"); s->misc =3D value; break; + case A_CLK1HZ: + now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + s->clk1hz_tick_offset =3D tickoff_from_counter(now, value, 1); + break; + case A_CLK100HZ: + now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + s->clk100hz_tick_offset =3D tickoff_from_counter(now, value, 100); + break; default: qemu_log_mask(LOG_GUEST_ERROR, "MPS2 FPGAIO write: bad offset 0x%x\n", (int) offset= ); @@ -116,11 +142,14 @@ static const MemoryRegionOps mps2_fpgaio_ops =3D { static void mps2_fpgaio_reset(DeviceState *dev) { MPS2FPGAIO *s =3D MPS2_FPGAIO(dev); + int64_t now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); =20 trace_mps2_fpgaio_reset(); s->led0 =3D 0; s->prescale =3D 0; s->misc =3D 0; + s->clk1hz_tick_offset =3D tickoff_from_counter(now, 0, 1); + s->clk100hz_tick_offset =3D tickoff_from_counter(now, 0, 100); } =20 static void mps2_fpgaio_init(Object *obj) @@ -133,6 +162,24 @@ static void mps2_fpgaio_init(Object *obj) sysbus_init_mmio(sbd, &s->iomem); } =20 +static bool mps2_fpgaio_counters_needed(void *opaque) +{ + /* Currently vmstate.c insists all subsections have a 'needed' functio= n */ + return true; +} + +static const VMStateDescription mps2_fpgaio_counters_vmstate =3D { + .name =3D "mps2-fpgaio/counters", + .version_id =3D 1, + .minimum_version_id =3D 1, + .needed =3D mps2_fpgaio_counters_needed, + .fields =3D (VMStateField[]) { + VMSTATE_INT64(clk1hz_tick_offset, MPS2FPGAIO), + VMSTATE_INT64(clk100hz_tick_offset, MPS2FPGAIO), + VMSTATE_END_OF_LIST() + } +}; + static const VMStateDescription mps2_fpgaio_vmstate =3D { .name =3D "mps2-fpgaio", .version_id =3D 1, @@ -142,6 +189,10 @@ static const VMStateDescription mps2_fpgaio_vmstate = =3D { VMSTATE_UINT32(prescale, MPS2FPGAIO), VMSTATE_UINT32(misc, MPS2FPGAIO), VMSTATE_END_OF_LIST() + }, + .subsections =3D (const VMStateDescription*[]) { + &mps2_fpgaio_counters_vmstate, + NULL } }; =20 --=20 2.18.0