From nobody Sun Feb 8 18:32:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15349253594941005.9076565292825; Wed, 22 Aug 2018 01:09:19 -0700 (PDT) Received: from localhost ([::1]:57401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOCV-0003Ds-B3 for importer@patchew.org; Wed, 22 Aug 2018 04:09:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOAM-0001r4-4Z for qemu-devel@nongnu.org; Wed, 22 Aug 2018 04:06:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsO1l-00014j-Pl for qemu-devel@nongnu.org; Wed, 22 Aug 2018 03:58:09 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33788 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsO1l-00014S-Kj; Wed, 22 Aug 2018 03:58:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E19040201CA; Wed, 22 Aug 2018 07:58:05 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-232.ams2.redhat.com [10.36.116.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E5D810FFE7F; Wed, 22 Aug 2018 07:58:03 +0000 (UTC) From: David Hildenbrand To: qemu-s390x@nongnu.org Date: Wed, 22 Aug 2018 09:57:49 +0200 Message-Id: <20180822075750.12399-8-david@redhat.com> In-Reply-To: <20180822075750.12399-1-david@redhat.com> References: <20180822075750.12399-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 22 Aug 2018 07:58:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 22 Aug 2018 07:58:05 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v1 7/8] s390x/tcg: fix FP register pair checks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Alexander Graf , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Valid register pairs are 0/2, 1/3, 4/6, 5/7, 8/10, 9/11, 12/14, 13/15. R1/R2 always selects the lower number, so the current checks are not correct as e.g. 2/4 could be selected as a pair. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 1ca6ef45a1..27d2405ef4 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -1110,7 +1110,7 @@ typedef struct { #define IF_HFP3 0x0004 /* r3 points at fp reg for HFP instruction= s */ #define IF_BFP 0x0008 /* binary floating point instruction */ #define IF_DFP 0x0010 /* decimal floating point instruction */ -#define IF_PRIV 0x0020 /* priviledged instruction */ +#define IF_PRIV 0x0020 /* privileged instruction */ =20 struct DisasInsn { unsigned opc:16; @@ -5985,6 +5985,12 @@ static bool is_afp_reg(int reg) return reg % 2 || reg > 6; } =20 +static bool is_fp_pair(int reg) +{ + /* 0,1,4,5,8,9,12,13: to exclude the others, check for single bit */ + return !(reg & 0x2); +} + static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) { const DisasInsn *insn; @@ -6013,7 +6019,7 @@ static DisasJumpType translate_one(CPUS390XState *env= , DisasContext *s) =20 /* process flags */ if (insn->flags) { - /* priviledged instruction */ + /* privileged instruction */ if ((s->base.tb->flags & FLAG_MASK_PSTATE) && (insn->flags & IF_PR= IV)) { gen_program_exception(s, PGM_PRIVILEGED); return DISAS_NORETURN; @@ -6067,17 +6073,11 @@ static DisasJumpType translate_one(CPUS390XState *e= nv, DisasContext *s) excp =3D PGM_SPECIFICATION; } } - if (spec & SPEC_r1_f128) { - r =3D get_field(&f, r1); - if (r > 13) { - excp =3D PGM_SPECIFICATION; - } + if ((spec & SPEC_r1_f128) && !is_fp_pair(get_field(&f, r1))) { + excp =3D PGM_SPECIFICATION; } - if (spec & SPEC_r2_f128) { - r =3D get_field(&f, r2); - if (r > 13) { - excp =3D PGM_SPECIFICATION; - } + if ((spec & SPEC_r2_f128) && !is_fp_pair(get_field(&f, r2))) { + excp =3D PGM_SPECIFICATION; } if (excp) { gen_program_exception(s, excp); --=20 2.17.1