From nobody Sun Feb 8 14:07:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534925359402536.8173807807938; Wed, 22 Aug 2018 01:09:19 -0700 (PDT) Received: from localhost ([::1]:57402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOCY-0003IO-6B for importer@patchew.org; Wed, 22 Aug 2018 04:09:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsOAQ-0001qi-Bp for qemu-devel@nongnu.org; Wed, 22 Aug 2018 04:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsO1i-00012N-SH for qemu-devel@nongnu.org; Wed, 22 Aug 2018 03:58:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33782 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsO1i-00011q-Jk; Wed, 22 Aug 2018 03:58:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4495040201C0; Wed, 22 Aug 2018 07:58:02 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-232.ams2.redhat.com [10.36.116.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 091DE10FFE7E; Wed, 22 Aug 2018 07:58:00 +0000 (UTC) From: David Hildenbrand To: qemu-s390x@nongnu.org Date: Wed, 22 Aug 2018 09:57:47 +0200 Message-Id: <20180822075750.12399-6-david@redhat.com> In-Reply-To: <20180822075750.12399-1-david@redhat.com> References: <20180822075750.12399-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 22 Aug 2018 07:58:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 22 Aug 2018 07:58:02 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v1 5/8] s390x/tcg: check for AFP-register, BFP and DFP data exceptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Alexander Graf , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" With the annotated functions, we can now easily check this at a central place. DXC 1 is to be injected if an AFP register is used (for a HFP instruction) when AFP is disabled. DXC 2 is to be injected if a BFP instruction is used when AFP is disabled. DXC =C2=A7 is to be injected if a DFP instruction is used when AFP is disabled. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 8322c81e90..a0c834ebb9 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -6055,6 +6055,11 @@ static const DisasInsn *extract_insn(CPUS390XState *= env, DisasContext *s, return info; } =20 +static bool is_afp_reg(int reg) +{ + return reg % 2 || reg > 6; +} + static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) { const DisasInsn *insn; @@ -6081,6 +6086,34 @@ static DisasJumpType translate_one(CPUS390XState *en= v, DisasContext *s) } #endif =20 + /* process flags */ + if (insn->flags) { + /* if AFP is not enabled, instructions and registers are forbidden= */ + if (!(s->base.tb->flags & FLAG_MASK_AFP)) { + uint8_t dxc =3D 0; + + if ((insn->flags & IF_HFP1) && is_afp_reg(get_field(&f, r1))) { + dxc =3D 1; + } + if ((insn->flags & IF_HFP2) && is_afp_reg(get_field(&f, r2))) { + dxc =3D 1; + } + if ((insn->flags & IF_HFP3) && is_afp_reg(get_field(&f, r3))) { + dxc =3D 1; + } + if (insn->flags & IF_BFP) { + dxc =3D 2; + } + if (insn->flags & IF_DFP) { + dxc =3D 3; + } + if (dxc) { + gen_data_exception(dxc); + return DISAS_NORETURN; + } + } + } + /* Check for insn specification exceptions. */ if (insn->spec) { int spec =3D insn->spec, excp =3D 0, r; --=20 2.17.1