From nobody Wed Nov 5 13:02:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534868447117653.7320719509439; Tue, 21 Aug 2018 09:20:47 -0700 (PDT) Received: from localhost ([::1]:54749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs9Of-0007rF-GY for importer@patchew.org; Tue, 21 Aug 2018 12:20:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs9NQ-00071Y-5Z for qemu-devel@nongnu.org; Tue, 21 Aug 2018 12:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fs9NI-0006b2-Gr for qemu-devel@nongnu.org; Tue, 21 Aug 2018 12:19:27 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:34084) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fs9NG-0006Yv-7Q; Tue, 21 Aug 2018 12:19:20 -0400 Received: from 91-158-71-53.elisa-laajakaista.fi ([91.158.71.53] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1fs9ND-0000zU-38; Tue, 21 Aug 2018 18:19:15 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1fs9Mz-0007Pc-Hf; Tue, 21 Aug 2018 19:19:01 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=uutzliMcU96jzrTVeTAndbdEThb2CIZ0wSi568C57VM=; b=QbpUXT+AtKMkSUGIeccGIsbNA6CUdXubsJFRppQZOZDn1QfTh25nG4TipIdAuJMwu43991kPgnUaIfejHwB82nOkJ+C8YBeDEg9i3OtxERV2hTeFV5y2Tru57hDKGymp5zgW5Nst2qQAk/Z/7Kf/7pkZx6Z/HHx5SadUWBkF5+nUU0zHj8Lk8irXME6DGAiok3s/txgFrOH3cPuMKMgydGBDjcyCzp/bCd3R+CD++sMjhG54Gyiu0UWvytWNif/J+QHHhbiwYK1dntkfyUT9S7sw3DIaCqHSUmtcm3q2Dfgrv9B8eUCDmwYTy+Q4lsDAiL3/xrctwFPw4XSWvql1Jg==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Tue, 21 Aug 2018 19:18:57 +0300 Message-Id: <20180821161857.28402-1-berto@igalia.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH] qemu-io: Fix writethrough check in reopen X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" "qemu-io reopen" doesn't allow changing the writethrough setting of the cache, but the check is wrong, causing an error even on a simple reopen with the default parameters: $ qemu-img create -f qcow2 hd.qcow2 1M $ qemu-system-x86_64 -monitor stdio -drive if=3Dvirtio,file=3Dhd.qcow2 (qemu) qemu-io virtio0 reopen Cannot change cache.writeback: Device attached Signed-off-by: Alberto Garcia --- qemu-io-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 5bf5f28178..db0b3ee5ef 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -2025,7 +2025,7 @@ static int reopen_f(BlockBackend *blk, int argc, char= **argv) return -EINVAL; } =20 - if (writethrough !=3D blk_enable_write_cache(blk) && + if (!writethrough !=3D blk_enable_write_cache(blk) && blk_get_attached_dev(blk)) { error_report("Cannot change cache.writeback: Device attached"); --=20 2.11.0