From nobody Wed Nov 5 14:24:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534826409435372.0306046553234; Mon, 20 Aug 2018 21:40:09 -0700 (PDT) Received: from localhost ([::1]:50665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frySe-0000EJ-7d for importer@patchew.org; Tue, 21 Aug 2018 00:40:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fryMk-00044p-TN for qemu-devel@nongnu.org; Tue, 21 Aug 2018 00:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fryMh-0000G0-Sd for qemu-devel@nongnu.org; Tue, 21 Aug 2018 00:34:02 -0400 Received: from ozlabs.org ([203.11.71.1]:41689) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fryMh-0000DD-4g; Tue, 21 Aug 2018 00:33:59 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 41vd9D1q6vz9sCQ; Tue, 21 Aug 2018 14:33:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1534826032; bh=RajdpkrWg3kokuh+yyEROUNLdonb96GodpxiCk3QNX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mjo9jYFALLxNffFAJTIeJtJWFMYZjDhalkdrGgmYtD1vNRG4ReCnvVEwRi5w0AC6h nLAVQ3UOr+3lKTBpZQqfEZiYAFzmhvdNVV1a4w0/Jy16GzQXxGhQeVmp8XB9l2p+C/ 0xGk+ChLJWvh1XQtneVU8Lq0KA6MgmmUNago0tb0= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 21 Aug 2018 14:33:27 +1000 Message-Id: <20180821043343.7514-11-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180821043343.7514-1-david@gibson.dropbear.id.au> References: <20180821043343.7514-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 10/26] target/ppc: bcdsub fix sign when result is zero X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, groug@kaod.org, qemu-devel@nongnu.org, Yasmin Beatriz , qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yasmin Beatriz When the result of bcdsub is equal to zero, the result sign may be set to negative in some cases, and this does not follow the Power ISA specifications as to decimal integer arithmetic instructions. Signed-off-by: Yasmin Beatriz Signed-off-by: David Gibson --- target/ppc/int_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index d52338ed71..ac7f92d7ae 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -2747,6 +2747,9 @@ uint32_t helper_bcdadd(ppc_avr_t *r, ppc_avr_t *a, p= pc_avr_t *b, uint32_t ps) result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(sgna, ps); zero =3D bcd_sub_mag(&result, a, b, &invalid, &overflow); cr =3D (sgna > 0) ? CRF_GT : CRF_LT; + } else if (bcd_cmp_mag(a, b) =3D=3D 0) { + result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(0, ps); + zero =3D bcd_sub_mag(&result, b, a, &invalid, &overflow); } else { result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(sgnb, ps); zero =3D bcd_sub_mag(&result, b, a, &invalid, &overflow); --=20 2.17.1