From nobody Wed Nov 5 12:20:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534769261666872.6988992309282; Mon, 20 Aug 2018 05:47:41 -0700 (PDT) Received: from localhost ([::1]:46891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frjam-00018S-2W for importer@patchew.org; Mon, 20 Aug 2018 08:47:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frjYX-0008Q9-C1 for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frjYW-0000az-Lm for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:13 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:40035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frjYW-0000aU-FX for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:12 -0400 Received: by mail-wr1-x429.google.com with SMTP id n2-v6so2405048wrw.7 for ; Mon, 20 Aug 2018 05:45:12 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id g2-v6sm26704613wrd.71.2018.08.20.05.45.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Aug 2018 05:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5r/KKarbTMQgnpW2TRustIhW+heFG14NlO0AxEwya3I=; b=aAyadxKxfYHJOZSd8NJlLo4iVbKyvu43y43JzXMGXfups0MSLXF0DMLEaMI7p1RHza cjPeBh/5hME/8S2NiklF5naF2/z7eJfg3wVHPBLx12z0epkISUrDfM1QfNn5i/wJJUrA CZBz1cJWXz5AZlJPj6vwuYD9+C4VSzLYAlKvQh73PMp4fRXcCKf83DBxseVkr/uwG4tN vF9moz2D5Lrpw9094PHhtkfelM1YsZaTl9G1nKPv8nTFP3CFYI8leL5RaYqbg2rZzHUg fvhh/PUjSGzpLRNASz5AvVvGc5AeXMtGJQjJKTX5fHF194uyXWeXnvyZXwo8K3YdzlMQ JBQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5r/KKarbTMQgnpW2TRustIhW+heFG14NlO0AxEwya3I=; b=T776KsiJ/lXqTnyRzg+haqUOMupYMKS/mTZquLVOz3X0z94OB5NE6IPfHqFNwdjcRl wviYoTYX05nijZ558gZWwrw0Zd2Eh9xALaWquCwLQHvL4nDLG73OvKua9uSVQ8m5hhN0 FxHfDltoztYcru88CjSGh4yTtldxdbkuLvE6m9bx6Wdt5vCwjVKWjiPCQ31/Ni8ZA2rc oMYSoda4sNVdNASAWKuDVvQn7Ty1qNYaEjEUHCdueccytDyemZntsE/Ql2WajtEnUnEY 4uL0lln+YtnHdB9gupaxv2xhExkb0YHc8HTd+lEIANszZjsvcpAYMCwJ/J+Jo5qUYMX2 0FMA== X-Gm-Message-State: AOUpUlHJj34wofSvY4GUHDpBK9DuCchTDYlujMXe6LHR04nu7atCcBGU /7SZi1nJnF5uA4GxgcnwSi0N/qj8 X-Google-Smtp-Source: AA+uWPy3sPn9ywVYaZFfj1Kw7h0iK+yfP/poGfWaWFXHHPqoWP0CpF86PiSUxIa5pvFvMY2LEfLOmA== X-Received: by 2002:adf:f390:: with SMTP id m16-v6mr29732882wro.279.1534769111271; Mon, 20 Aug 2018 05:45:11 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sun, 19 Aug 2018 23:22:47 +0300 Message-Id: <20180819202300.10590-3-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180819202300.10590-1-marcel.apfelbaum@gmail.com> References: <20180819202300.10590-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 Subject: [Qemu-devel] [PATCH PULL 02/15] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yuval Shaia Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia Message-Id: <20180805153518.2983-3-yuval.shaia@oracle.com> Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 14255d609f..e7d6589cdc 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -524,6 +524,7 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_re= q *req, struct ibv_qp_init_attr init_attr; =20 pr_dbg("qp_handle=3D%d\n", cmd->qp_handle); + pr_dbg("attr_mask=3D0x%x\n", cmd->attr_mask); =20 memset(rsp, 0, sizeof(*rsp)); rsp->hdr.response =3D cmd->hdr.response; @@ -531,8 +532,8 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_re= q *req, =20 rsp->hdr.err =3D rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_de= v, cmd->qp_handle, - (struct ibv_qp_attr *)&resp->attrs, -1, - &init_attr); + (struct ibv_qp_attr *)&resp->attrs, + cmd->attr_mask, &init_attr); =20 pr_dbg("ret=3D%d\n", rsp->hdr.err); return rsp->hdr.err; --=20 2.17.1