From nobody Wed Nov 5 12:52:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534619399317196.92655282993292; Sat, 18 Aug 2018 12:09:59 -0700 (PDT) Received: from localhost ([::1]:40156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr6bf-000374-82 for importer@patchew.org; Sat, 18 Aug 2018 15:09:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr6Tc-0005Gh-9x for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fr6Ta-0007AG-UI for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:32 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:41175) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fr6Ta-00079b-LY for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:30 -0400 Received: by mail-pf1-x443.google.com with SMTP id y10-v6so4879838pfn.8 for ; Sat, 18 Aug 2018 12:01:30 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id q85-v6sm9362783pfa.151.2018.08.18.12.01.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Aug 2018 12:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yRCd/zNxWwSLW1eYS48HcYtNRh0OdYJc39wrHXnsgaY=; b=U1aAJfULDzUGFwxo3tIHv/zzFFzn4cdCrpNB83jdm8vTTF9vnFxm/QXGXCf5QIilD6 LvOc45NxQChqQeQmDPhogXkPX5r8oIAY1rFBpJW71Dza9IMT9FTySMFYQTneh1Z9gUFL 4h1relMc3SfMmAnr9z6XL/tPrsPhaLl6AlHVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yRCd/zNxWwSLW1eYS48HcYtNRh0OdYJc39wrHXnsgaY=; b=ddkXWrdT3hmm/qMaMReUFqOT/Vc66HvVnfCFTuE6XmD6Anj/SNL9T6n6ExA97SISgN H97lXgTvHHymAq6O7BXLz/KCVWBTi6WdO8JUlE4UKUj4k3UTVoc5pI+Bm1RFRToeHrbl DC7sswO4NBpkWzqfRWjh8xr8/W1K2duN0ZoXEUD4SFPS/qJ9tz4vszwOyYBrPRjrQ/7W qbO6/dIKexlSIxSbrJJlgOA4pDEn0HlK+vZ+srl6iMg8VRH5aDNjbW+lmP8vi7htPQPH LgeqTWOsV2HbXpris70rAVBiA7D559TgGuuXv60VYAkcfNikNeQlQO2mmSBMgjRzeMjj n9fA== X-Gm-Message-State: AOUpUlFyuAEuY8oyAdqxUXhgvOznE9wLBT5EwL+WeSDUr1ggzukEmqYe 7C1ncU2e92GUy756D20bct7AtRdEjxs= X-Google-Smtp-Source: AA+uWPw3/ZgMZ1FYOIr+JDSHPWZSokZ08ooisj8A4dc9COLqDr9xoqrAqZY7tbN/LnuQkITaRqSfhw== X-Received: by 2002:a63:586:: with SMTP id 128-v6mr6110992pgf.169.1534618889263; Sat, 18 Aug 2018 12:01:29 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 18 Aug 2018 12:01:08 -0700 Message-Id: <20180818190118.12911-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180818190118.12911-1-richard.henderson@linaro.org> References: <20180818190118.12911-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH v4 06/16] linux-user: Propagate goto unimplemented to default X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There is no point in listing a syscall if you want the same effect as not listing it. In one less trivial case, the goto was demonstrably not reachable. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 144 +------------------------------------------ 1 file changed, 1 insertion(+), 143 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 812fb27fa1..ef3b9b623c 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8341,14 +8341,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, unlock_user(p, arg1, 0); return ret; #endif -#ifdef TARGET_NR_break - case TARGET_NR_break: - goto unimplemented; -#endif -#ifdef TARGET_NR_oldstat - case TARGET_NR_oldstat: - goto unimplemented; -#endif #ifdef TARGET_NR_lseek case TARGET_NR_lseek: return get_errno(lseek(arg1, arg2, arg3)); @@ -8435,16 +8427,10 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, return get_errno(stime(&host_time)); } #endif - case TARGET_NR_ptrace: - goto unimplemented; #ifdef TARGET_NR_alarm /* not on alpha */ case TARGET_NR_alarm: return alarm(arg1); #endif -#ifdef TARGET_NR_oldfstat - case TARGET_NR_oldfstat: - goto unimplemented; -#endif #ifdef TARGET_NR_pause /* not on alpha */ case TARGET_NR_pause: if (!block_signals()) { @@ -8515,14 +8501,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, } return ret; #endif -#ifdef TARGET_NR_stty - case TARGET_NR_stty: - goto unimplemented; -#endif -#ifdef TARGET_NR_gtty - case TARGET_NR_gtty: - goto unimplemented; -#endif #ifdef TARGET_NR_access case TARGET_NR_access: if (!(p =3D lock_user_string(arg1))) { @@ -8544,10 +8522,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, #ifdef TARGET_NR_nice /* not on alpha */ case TARGET_NR_nice: return get_errno(nice(arg1)); -#endif -#ifdef TARGET_NR_ftime - case TARGET_NR_ftime: - goto unimplemented; #endif case TARGET_NR_sync: sync(); @@ -8661,14 +8635,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, ret =3D host_to_target_clock_t(ret); } return ret; -#ifdef TARGET_NR_prof - case TARGET_NR_prof: - goto unimplemented; -#endif -#ifdef TARGET_NR_signal - case TARGET_NR_signal: - goto unimplemented; -#endif case TARGET_NR_acct: if (arg1 =3D=3D 0) { ret =3D get_errno(acct(NULL)); @@ -8687,31 +8653,15 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, ret =3D get_errno(umount2(p, arg2)); unlock_user(p, arg1, 0); return ret; -#endif -#ifdef TARGET_NR_lock - case TARGET_NR_lock: - goto unimplemented; #endif case TARGET_NR_ioctl: return do_ioctl(arg1, arg2, arg3); #ifdef TARGET_NR_fcntl case TARGET_NR_fcntl: return do_fcntl(arg1, arg2, arg3); -#endif -#ifdef TARGET_NR_mpx - case TARGET_NR_mpx: - goto unimplemented; #endif case TARGET_NR_setpgid: return get_errno(setpgid(arg1, arg2)); -#ifdef TARGET_NR_ulimit - case TARGET_NR_ulimit: - goto unimplemented; -#endif -#ifdef TARGET_NR_oldolduname - case TARGET_NR_oldolduname: - goto unimplemented; -#endif case TARGET_NR_umask: return get_errno(umask(arg1)); case TARGET_NR_chroot: @@ -8720,10 +8670,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, ret =3D get_errno(chroot(p)); unlock_user(p, arg1, 0); return ret; -#ifdef TARGET_NR_ustat - case TARGET_NR_ustat: - goto unimplemented; -#endif #ifdef TARGET_NR_dup2 case TARGET_NR_dup2: ret =3D get_errno(dup2(arg1, arg2)); @@ -9432,10 +9378,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, } return ret; #endif -#ifdef TARGET_NR_oldlstat - case TARGET_NR_oldlstat: - goto unimplemented; -#endif #ifdef TARGET_NR_readlink case TARGET_NR_readlink: { @@ -9489,10 +9431,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, } return ret; #endif -#ifdef TARGET_NR_uselib - case TARGET_NR_uselib: - goto unimplemented; -#endif #ifdef TARGET_NR_swapon case TARGET_NR_swapon: if (!(p =3D lock_user_string(arg1))) @@ -9514,10 +9452,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, ret =3D get_errno(reboot(arg1, arg2, arg3, NULL)); } return ret; -#ifdef TARGET_NR_readdir - case TARGET_NR_readdir: - goto unimplemented; -#endif #ifdef TARGET_NR_mmap case TARGET_NR_mmap: #if (defined(TARGET_I386) && defined(TARGET_ABI32)) || \ @@ -9638,10 +9572,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, return ret; case TARGET_NR_setpriority: return get_errno(setpriority(arg1, arg2, arg3)); -#ifdef TARGET_NR_profil - case TARGET_NR_profil: - goto unimplemented; -#endif #ifdef TARGET_NR_statfs case TARGET_NR_statfs: if (!(p =3D lock_user_string(arg1))) { @@ -9713,10 +9643,6 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, ret =3D get_errno(fstatfs(arg1, &stfs)); goto convert_statfs64; #endif -#ifdef TARGET_NR_ioperm - case TARGET_NR_ioperm: - goto unimplemented; -#endif #ifdef TARGET_NR_socketcall case TARGET_NR_socketcall: return do_socketcall(arg1, arg2); @@ -9935,21 +9861,9 @@ static abi_long do_syscall1(void *cpu_env, int num, = abi_long arg1, } } return ret; -#endif -#ifdef TARGET_NR_olduname - case TARGET_NR_olduname: - goto unimplemented; -#endif -#ifdef TARGET_NR_iopl - case TARGET_NR_iopl: - goto unimplemented; #endif case TARGET_NR_vhangup: return get_errno(vhangup()); -#ifdef TARGET_NR_idle - case TARGET_NR_idle: - goto unimplemented; -#endif #ifdef TARGET_NR_syscall case TARGET_NR_syscall: return do_syscall(cpu_env, arg1 & 0xffff, arg2, arg3, arg4, arg5, @@ -10122,8 +10036,6 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, case TARGET_NR_modify_ldt: return do_modify_ldt(cpu_env, arg1, arg2, arg3); #if !defined(TARGET_X86_64) - case TARGET_NR_vm86old: - goto unimplemented; case TARGET_NR_vm86: return do_vm86(cpu_env, arg1, arg2); #endif @@ -10160,35 +10072,12 @@ static abi_long do_syscall1(void *cpu_env, int nu= m, abi_long arg1, } return ret; #endif -#ifdef TARGET_NR_create_module - case TARGET_NR_create_module: -#endif - case TARGET_NR_init_module: - case TARGET_NR_delete_module: -#ifdef TARGET_NR_get_kernel_syms - case TARGET_NR_get_kernel_syms: -#endif - goto unimplemented; - case TARGET_NR_quotactl: - goto unimplemented; case TARGET_NR_getpgid: return get_errno(getpgid(arg1)); case TARGET_NR_fchdir: return get_errno(fchdir(arg1)); -#ifdef TARGET_NR_bdflush /* not on x86_64 */ - case TARGET_NR_bdflush: - goto unimplemented; -#endif -#ifdef TARGET_NR_sysfs - case TARGET_NR_sysfs: - goto unimplemented; -#endif case TARGET_NR_personality: return get_errno(personality(arg1)); -#ifdef TARGET_NR_afs_syscall - case TARGET_NR_afs_syscall: - goto unimplemented; -#endif #ifdef TARGET_NR__llseek /* Not on alpha */ case TARGET_NR__llseek: { @@ -10702,14 +10591,6 @@ static abi_long do_syscall1(void *cpu_env, int num= , abi_long arg1, } } return ret; -#ifdef TARGET_NR_query_module - case TARGET_NR_query_module: - goto unimplemented; -#endif -#ifdef TARGET_NR_nfsservctl - case TARGET_NR_nfsservctl: - goto unimplemented; -#endif case TARGET_NR_prctl: switch (arg1) { case PR_GET_PDEATHSIG: @@ -10795,7 +10676,7 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, #if defined(TARGET_I386) && !defined(TARGET_ABI32) return do_arch_prctl(cpu_env, arg1, arg2); #else - goto unimplemented; +#error unreachable #endif #endif #ifdef TARGET_NR_pread64 @@ -10945,21 +10826,6 @@ static abi_long do_syscall1(void *cpu_env, int num= , abi_long arg1, return ret; } #endif -#else - case TARGET_NR_sendfile: -#ifdef TARGET_NR_sendfile64 - case TARGET_NR_sendfile64: -#endif - goto unimplemented; -#endif - -#ifdef TARGET_NR_getpmsg - case TARGET_NR_getpmsg: - goto unimplemented; -#endif -#ifdef TARGET_NR_putpmsg - case TARGET_NR_putpmsg: - goto unimplemented; #endif #ifdef TARGET_NR_vfork case TARGET_NR_vfork: @@ -11502,9 +11368,6 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, case TARGET_NR_setfsgid32: return get_errno(setfsgid(arg1)); #endif - - case TARGET_NR_pivot_root: - goto unimplemented; #ifdef TARGET_NR_mincore case TARGET_NR_mincore: { @@ -11662,10 +11525,6 @@ static abi_long do_syscall1(void *cpu_env, int num= , abi_long arg1, /* self-modifying code is handled automatically, so nothing needed= */ return 0; #endif -#ifdef TARGET_NR_security - case TARGET_NR_security: - goto unimplemented; -#endif #ifdef TARGET_NR_getpagesize case TARGET_NR_getpagesize: return TARGET_PAGE_SIZE; @@ -12631,7 +12490,6 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, #endif =20 default: - unimplemented: qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num); return -TARGET_ENOSYS; } --=20 2.17.1