From nobody Wed Nov 5 13:15:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534514102431334.1665371009981; Fri, 17 Aug 2018 06:55:02 -0700 (PDT) Received: from localhost ([::1]:34036 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfDL-0003rv-5J for importer@patchew.org; Fri, 17 Aug 2018 09:54:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfBI-0001PA-A6 for qemu-devel@nongnu.org; Fri, 17 Aug 2018 09:52:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqfBH-0007Ct-IR for qemu-devel@nongnu.org; Fri, 17 Aug 2018 09:52:48 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53994 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fqfBH-0007C0-DH for qemu-devel@nongnu.org; Fri, 17 Aug 2018 09:52:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13D576F4C7 for ; Fri, 17 Aug 2018 13:52:47 +0000 (UTC) Received: from localhost (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 389652026D6C; Fri, 17 Aug 2018 13:52:43 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Fri, 17 Aug 2018 15:52:24 +0200 Message-Id: <20180817135224.22971-5-marcandre.lureau@redhat.com> In-Reply-To: <20180817135224.22971-1-marcandre.lureau@redhat.com> References: <20180817135224.22971-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 17 Aug 2018 13:52:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 17 Aug 2018 13:52:47 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'marcandre.lureau@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 4/4] test-char: add socket reconnect test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , peterx@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This test exhibits a regression fixed by the previous reverts. Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/test-char.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-char.c b/tests/test-char.c index 5905d31441..d99742d86d 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -309,7 +309,7 @@ static int socket_can_read_hello(void *opaque) return 10; } =20 -static void char_socket_test_common(Chardev *chr) +static void char_socket_test_common(Chardev *chr, bool reconnect) { Chardev *chr_client; QObject *addr; @@ -329,7 +329,8 @@ static void char_socket_test_common(Chardev *chr) addr =3D object_property_get_qobject(OBJECT(chr), "addr", &error_abort= ); qdict =3D qobject_to(QDict, addr); port =3D qdict_get_str(qdict, "port"); - tmp =3D g_strdup_printf("tcp:127.0.0.1:%s", port); + tmp =3D g_strdup_printf("tcp:127.0.0.1:%s%s", port, + reconnect ? ",reconnect=3D1" : ""); qobject_unref(qdict); =20 qemu_chr_fe_init(&be, chr, &error_abort); @@ -370,7 +371,15 @@ static void char_socket_basic_test(void) { Chardev *chr =3D qemu_chr_new("server", "tcp:127.0.0.1:0,server,nowait= "); =20 - char_socket_test_common(chr); + char_socket_test_common(chr, false); +} + + +static void char_socket_reconnect_test(void) +{ + Chardev *chr =3D qemu_chr_new("server", "tcp:127.0.0.1:0,server,nowait= "); + + char_socket_test_common(chr, true); } =20 =20 @@ -402,7 +411,7 @@ static void char_socket_fdpass_test(void) =20 qemu_opts_del(opts); =20 - char_socket_test_common(chr); + char_socket_test_common(chr, false); } =20 =20 @@ -823,6 +832,7 @@ int main(int argc, char **argv) g_test_add_func("/char/file-fifo", char_file_fifo_test); #endif g_test_add_func("/char/socket/basic", char_socket_basic_test); + g_test_add_func("/char/socket/reconnect", char_socket_reconnect_test); g_test_add_func("/char/socket/fdpass", char_socket_fdpass_test); g_test_add_func("/char/udp", char_udp_test); #ifdef HAVE_CHARDEV_SERIAL --=20 2.18.0.547.g1d89318c48