From nobody Wed Nov 5 13:00:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534429213941484.0351905864652; Thu, 16 Aug 2018 07:20:13 -0700 (PDT) Received: from localhost ([::1]:55967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqJ86-0002V7-Io for importer@patchew.org; Thu, 16 Aug 2018 10:20:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqIno-0006FG-Ce for qemu-devel@nongnu.org; Thu, 16 Aug 2018 09:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqInl-0000Hq-0Z for qemu-devel@nongnu.org; Thu, 16 Aug 2018 09:59:04 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:46201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqInj-0000F4-I2; Thu, 16 Aug 2018 09:58:59 -0400 Received: by mail-qt0-x242.google.com with SMTP id d4-v6so4704574qtn.13; Thu, 16 Aug 2018 06:58:58 -0700 (PDT) Received: from localhost.localdomain ([177.83.75.169]) by smtp.gmail.com with ESMTPSA id p13-v6sm16454824qki.12.2018.08.16.06.58.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 06:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=h7/Szol+ROAWCt2ccsKOVzB5/cZAfQ7tIQ+od8CDv9I=; b=vgRNFNBL6LZwLiGOO1D8nOBs5K7YoCOI3k6hA0UdN76gPQAWYgnIjhltQrYqNaMa2c cdOPLNNtpeVd492LpUdc7tKAba96M6rvm4QxPT++CErEryy79bCKaoWnxYUKCOTq7G5Y UwByqzR+FDR+RPdVUcM+ZbmmRmOiU9z0LPui8zzkZHOjjrqbevsconI+fweRHTao08hb TyJYrvoQpEO+lg9PK6JF0CbxshJ0IJRKjGuA985foHjjfOnVI3UbfsBqoIUmmnUAez6y NY4U0MVLMHcHnHRPEnzPFl/jNz4hrP3Y8NsWFSM1hpMNHBhK4nhHEx0k/sJVYtlh6lN/ qb/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=h7/Szol+ROAWCt2ccsKOVzB5/cZAfQ7tIQ+od8CDv9I=; b=ebXCENuz2ITTTB6MBXXZJXqsfLUSxIK6CvgQIhy9ZH2OhenHYhyMtR2ZFMGx5Hh5db UOiG3H9KOVZtGKxgPk+Rx2e9q/HnOtjnMAjr4OBBXnMXbgjvAU/pdh0sYAQqoMYFNuRj T8MIXzl6JSNms+W1yq61drYVW2S/GNzxc/BI6p7aZfNFP3/pnfJ3+5mTg9O+1qDVDVGV ymXvbWI98Il+9e38z6uzazxJFZx1HiHm25fHt/W7V6NCQMslEbULef2UPDkaDVv5vzSD rQB1JTHa6g+lmOdfEZ5OXQzHGWEgqlFePRxhJFtFzAxQ04Y/euoL/Mq7tuHKazIaDHoC 0isg== X-Gm-Message-State: AOUpUlGX7+EXBt3XsFligmhZaLywYUjOBYnG/NKWkJb4KHBiFr5Mph91 ouCfa0AOvS9nq0j5VYU6t32CQ7CS X-Google-Smtp-Source: AA+uWPzVQNlVlV4ZzkkubdSxSHD99o6OoCgl3+HH6X0KsgZQ8zdwKhff/08xVcS8DbyqLhR9QuCrcQ== X-Received: by 2002:ac8:110c:: with SMTP id c12-v6mr29703731qtj.269.1534427937637; Thu, 16 Aug 2018 06:58:57 -0700 (PDT) From: Julio Faracco To: qemu-devel@nongnu.org Date: Thu, 16 Aug 2018 10:58:37 -0300 Message-Id: <20180816135837.13149-5-jcfaracco@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180816135837.13149-1-jcfaracco@gmail.com> References: <20180816135837.13149-1-jcfaracco@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v2 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/block/dmg.c b/block/dmg.c index 615f818c5a..6d055594df 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -44,6 +44,19 @@ enum { DMG_SECTORCOUNTS_MAX =3D DMG_LENGTHS_MAX / 512, }; =20 +enum { + /* DMG Block Type */ + UDZE =3D 0, /* Zeroes */ + UDRW, /* RAW type */ + UDIG, /* Ignore */ + UDCO =3D 0x80000004, + UDZO, + UDBZ, + ULFO, + UDCM =3D 0x7ffffffe, /* Comments */ + UDLE /* Last Entry */ +}; + static int dmg_probe(const uint8_t *buf, int buf_size, const char *filenam= e) { int len; @@ -108,16 +121,16 @@ static void update_max_chunk_size(BDRVDMGState *s, ui= nt32_t chunk, uint32_t uncompressed_sectors =3D 0; =20 switch (s->types[chunk]) { - case 0x80000005: /* zlib compressed */ - case 0x80000006: /* bzip2 compressed */ - case 0x80000007: /* lzfse compressed */ + case UDZO: /* zlib compressed */ + case UDBZ: /* bzip2 compressed */ + case ULFO: /* lzfse compressed */ compressed_size =3D s->lengths[chunk]; uncompressed_sectors =3D s->sectorcounts[chunk]; break; - case 1: /* copy */ + case UDRW: /* copy */ uncompressed_sectors =3D DIV_ROUND_UP(s->lengths[chunk], 512); break; - case 2: /* zero */ + case UDIG: /* zero */ /* as the all-zeroes block may be large, it is treated specially: = the * sector is not copied from a large buffer, a simple memset is us= ed * instead. Therefore uncompressed_sectors does not need to be set= . */ @@ -186,13 +199,13 @@ typedef struct DmgHeaderState { static bool dmg_is_known_block_type(uint32_t entry_type) { switch (entry_type) { - case 0x00000001: /* uncompressed */ - case 0x00000002: /* zeroes */ - case 0x80000005: /* zlib */ + case UDRW: /* uncompressed */ + case UDIG: /* zeroes */ + case UDZO: /* zlib */ return true; - case 0x80000006: /* bzip2 */ + case UDBZ: /* bzip2 */ return !!dmg_uncompress_bz2; - case 0x80000007: /* lzfse */ + case ULFO: /* lzfse */ return !!dmg_uncompress_lzfse; default: return false; @@ -592,7 +605,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) =20 s->current_chunk =3D s->n_chunks; switch (s->types[chunk]) { /* block entry type */ - case 0x80000005: { /* zlib compressed */ + case UDZO: { /* zlib compressed */ /* we need to buffer, because only the chunk as whole can be * inflated. */ ret =3D bdrv_pread(bs->file, s->offsets[chunk], @@ -615,7 +628,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) return -1; } break; } - case 0x80000006: /* bzip2 compressed */ + case UDBZ: /* bzip2 compressed */ if (!dmg_uncompress_bz2) { break; } @@ -636,7 +649,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) return ret; } break; - case 0x80000007: + case ULFO: if (!dmg_uncompress_lzfse) { break; } @@ -657,14 +670,14 @@ static inline int dmg_read_chunk(BlockDriverState *bs= , uint64_t sector_num) return ret; } break; - case 1: /* copy */ + case UDRW: /* copy */ ret =3D bdrv_pread(bs->file, s->offsets[chunk], s->uncompressed_chunk, s->lengths[chunk]); if (ret !=3D s->lengths[chunk]) { return -1; } break; - case 2: /* zero */ + case UDIG: /* zero */ /* see dmg_read, it is treated specially. No buffer needs to be * pre-filled, the zeroes can be set directly. */ break; --=20 2.17.1