From nobody Thu Dec 18 22:23:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534426974961806.0846931120612; Thu, 16 Aug 2018 06:42:54 -0700 (PDT) Received: from localhost ([::1]:55687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqIY9-0003np-OX for importer@patchew.org; Thu, 16 Aug 2018 09:42:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqIQR-00008p-36 for qemu-devel@nongnu.org; Thu, 16 Aug 2018 09:34:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqIQQ-0001rx-6s for qemu-devel@nongnu.org; Thu, 16 Aug 2018 09:34:55 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:44456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fqIQP-0001pa-UL for qemu-devel@nongnu.org; Thu, 16 Aug 2018 09:34:54 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1fqIQG-0008Re-3C for qemu-devel@nongnu.org; Thu, 16 Aug 2018 14:34:44 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 16 Aug 2018 14:34:10 +0100 Message-Id: <20180816133438.17061-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180816133438.17061-1-peter.maydell@linaro.org> References: <20180816133438.17061-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 02/30] target/arm: Fix sign-extension in sve do_ldr/do_str X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 From: Richard Henderson The expression (int) imm + (uint32_t) len_align turns into uint32_t and thus with negative imm produces a memory operation at the wrong offset. None of the numbers involved are particularly large, so change everything to use int. Cc: qemu-stable@nongnu.org (3.0.1) Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 89efc80ee70..9e63b5f8e55 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4372,12 +4372,11 @@ static bool trans_UCVTF_dd(DisasContext *s, arg_rpr= _esz *a, uint32_t insn) * The load should begin at the address Rn + IMM. */ =20 -static void do_ldr(DisasContext *s, uint32_t vofs, uint32_t len, - int rn, int imm) +static void do_ldr(DisasContext *s, uint32_t vofs, int len, int rn, int im= m) { - uint32_t len_align =3D QEMU_ALIGN_DOWN(len, 8); - uint32_t len_remain =3D len % 8; - uint32_t nparts =3D len / 8 + ctpop8(len_remain); + int len_align =3D QEMU_ALIGN_DOWN(len, 8); + int len_remain =3D len % 8; + int nparts =3D len / 8 + ctpop8(len_remain); int midx =3D get_mem_index(s); TCGv_i64 addr, t0, t1; =20 @@ -4458,12 +4457,11 @@ static void do_ldr(DisasContext *s, uint32_t vofs, = uint32_t len, } =20 /* Similarly for stores. */ -static void do_str(DisasContext *s, uint32_t vofs, uint32_t len, - int rn, int imm) +static void do_str(DisasContext *s, uint32_t vofs, int len, int rn, int im= m) { - uint32_t len_align =3D QEMU_ALIGN_DOWN(len, 8); - uint32_t len_remain =3D len % 8; - uint32_t nparts =3D len / 8 + ctpop8(len_remain); + int len_align =3D QEMU_ALIGN_DOWN(len, 8); + int len_remain =3D len % 8; + int nparts =3D len / 8 + ctpop8(len_remain); int midx =3D get_mem_index(s); TCGv_i64 addr, t0; =20 --=20 2.18.0