From nobody Wed Nov 5 13:17:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15343882241799.78838963678595; Wed, 15 Aug 2018 19:57:04 -0700 (PDT) Received: from localhost ([::1]:53231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq8T2-0003US-5a for importer@patchew.org; Wed, 15 Aug 2018 22:56:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq8RB-0002IU-3z for qemu-devel@nongnu.org; Wed, 15 Aug 2018 22:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fq8R8-0006ix-Mk for qemu-devel@nongnu.org; Wed, 15 Aug 2018 22:55:01 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:35049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fq8R8-0006iK-GC for qemu-devel@nongnu.org; Wed, 15 Aug 2018 22:54:58 -0400 Received: by mail-pg1-x533.google.com with SMTP id w10-v6so1361295pgv.2 for ; Wed, 15 Aug 2018 19:54:58 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id k64-v6sm45231497pfc.160.2018.08.15.19.54.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Aug 2018 19:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IhMON8SIkP+qjZyAFnHW2Wam9h9Vd5CT55tJoV/HJxY=; b=Xqp9x9446bC+sg/TqiY72VYhJEEhIz1YHsVa28iFz6jR9FlPXrtE3S+OcHCEqyJt5Z m2v7kEFmjrhonx6i6KwLdjZzRqt8uSI/oxFNTEubBZYGx39AfTQ8rpzb6IASKBhyJ2MI wY45xQ6iL0n8cTwTMqKdtqdcuUnoYZ3bACme4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IhMON8SIkP+qjZyAFnHW2Wam9h9Vd5CT55tJoV/HJxY=; b=OLLoLU83lvFwiDq1kdciZC8OgY+IZkqvpw91jXLQMaeiWzJ6lyxAMMBhmQkojjuBx8 2/vm8mQ3CRiFk6JiD5ED6GZPvlt9bqh10ximkP0bRzTjPfyOcoS2qLP0aFuMLs8j/+Ju q42eds/8l/Z21zcQUfBboZAjqt8Aic2YzDcJhpqdioDtEMRgZCE2qKMv+I75cWiHOJEf 8CbBI3A33H/yhwyqzecfCNZbcFqA5D63kFdHZKlkGpW1ougyZNhivoOo7qq64bnCMiZn Fs1rv5PVhL2oJQ/ohdNfRm6TtUEawc4925ZrzwvDjXC/QKASc6Akp1yGGXxTZR3V9PzA yXiA== X-Gm-Message-State: AOUpUlHd5/Ht24sEgCSa90PKTmpC5inAutkcd3pLAaL/+Ffk++5ODtWE NIQTJggACXvtk5bHo/iv4ym5OY9f9PI= X-Google-Smtp-Source: AA+uWPyVIEFtVxDEvrY2s9y0Wa9fWLdKpFnNQ87fjQ9JmQmmJlFQPnrGhJvB+Wiqz4osxC7anMIYcQ== X-Received: by 2002:a62:41d6:: with SMTP id g83-v6mr30104451pfd.219.1534388097231; Wed, 15 Aug 2018 19:54:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 15 Aug 2018 19:54:49 -0700 Message-Id: <20180816025452.21358-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180816025452.21358-1-richard.henderson@linaro.org> References: <20180816025452.21358-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::533 Subject: [Qemu-devel] [PATCH 2/5] target/i386: Convert to HAVE_CMPXCHG128 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, cota@braap.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota --- target/i386/mem_helper.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/i386/mem_helper.c b/target/i386/mem_helper.c index 30c26b9d9c..6cc53bcb40 100644 --- a/target/i386/mem_helper.c +++ b/target/i386/mem_helper.c @@ -23,6 +23,7 @@ #include "exec/exec-all.h" #include "exec/cpu_ldst.h" #include "qemu/int128.h" +#include "qemu/atomic128.h" #include "tcg.h" =20 void helper_cmpxchg8b_unlocked(CPUX86State *env, target_ulong a0) @@ -137,10 +138,7 @@ void helper_cmpxchg16b(CPUX86State *env, target_ulong = a0) =20 if ((a0 & 0xf) !=3D 0) { raise_exception_ra(env, EXCP0D_GPF, ra); - } else { -#ifndef CONFIG_ATOMIC128 - cpu_loop_exit_atomic(ENV_GET_CPU(env), ra); -#else + } else if (HAVE_CMPXCHG128) { int eflags =3D cpu_cc_compute_all(env, CC_OP); =20 Int128 cmpv =3D int128_make128(env->regs[R_EAX], env->regs[R_EDX]); @@ -159,7 +157,8 @@ void helper_cmpxchg16b(CPUX86State *env, target_ulong a= 0) eflags &=3D ~CC_Z; } CC_SRC =3D eflags; -#endif + } else { + cpu_loop_exit_atomic(ENV_GET_CPU(env), ra); } } #endif --=20 2.17.1