From nobody Wed Nov 5 10:14:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534178481107646.9816216730591; Mon, 13 Aug 2018 09:41:21 -0700 (PDT) Received: from localhost ([::1]:40434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpFuB-0006xM-TV for importer@patchew.org; Mon, 13 Aug 2018 12:41:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpFs7-0004kP-VB for qemu-devel@nongnu.org; Mon, 13 Aug 2018 12:39:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpFs3-00011k-0y for qemu-devel@nongnu.org; Mon, 13 Aug 2018 12:39:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57053) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fpFs2-000110-QI; Mon, 13 Aug 2018 12:39:06 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id ED0D021E31; Mon, 13 Aug 2018 12:39:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 13 Aug 2018 12:39:04 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id C6F8EE405D; Mon, 13 Aug 2018 12:39:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=/ideQeRRjunNXD //L4a/EvNwvzFdoV8y6Dye+QoxrI0=; b=IOZx9krloCsS5pTXzgiu45ifoqMTLg vBPTI770p6nwb2BEdzZl09cExlYBsXrjwsSweu5Mgs3wyaJkIdT4pLY1LO9LS4c1 gx856MyAd9adxUpO0jDMRGLj8IOh7ETrl6SmpkLgJquwzbaLE8knK82vxh+dBqof ZRyGCQ/xxuq4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=/ideQeRRjunNXD//L4a/EvNwvzFdoV8y6Dye+QoxrI0=; b=rxwGnHfz jbz6j9iZtCurmCuERV/ZtcQKfewPnbLpDBsNDhHgsL+RYrCkVS61rbHJomllJVTr 5Sao7OLGa39XpOWUxakypcMsAYl5Rvqg5KyPmC3jtWEBiHOIE4Sp0lCzHhGE29Ma Z0u7c2XqZrj64YgWHrSz020Js1P7XKsogk2ujp+X1XCt+eE5ri0tN3uhuG4hvnXs 3WVeKKoZjk0amuCAX/Jn2g1+n/GZwb34cq65BkuX1Yv3UTjkuZE1TwGHZ2amfcVA WCdIPfDKT8IdQQdExzGZiLXD8Rpd/roK4emThKOJFc3clls8M5mfJQJsv8Ty6XS3 7VdeKr4oMeO8Sw== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Mon, 13 Aug 2018 12:38:57 -0400 Message-Id: <20180813163859.17964-2-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180813163859.17964-1-cota@braap.org> References: <20180813163859.17964-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH 1/3] qom: use cpu->in_cpu_list instead of QTAILQ_IN_USE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , Riku Voipio , Alexander Graf , Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , David Gibson , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This paves the way for implementing the CPU list with an RCU QLIST. Signed-off-by: Emilio G. Cota --- cpus-common.c | 3 ++- include/qom/cpu.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cpus-common.c b/cpus-common.c index 59f751ecf9..6eaedae60b 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -85,6 +85,7 @@ void cpu_list_add(CPUState *cpu) assert(!cpu_index_auto_assigned); } QTAILQ_INSERT_TAIL(&cpus, cpu, node); + cpu->in_cpu_list =3D true; qemu_mutex_unlock(&qemu_cpu_list_lock); =20 finish_safe_work(cpu); @@ -93,7 +94,7 @@ void cpu_list_add(CPUState *cpu) void cpu_list_remove(CPUState *cpu) { qemu_mutex_lock(&qemu_cpu_list_lock); - if (!QTAILQ_IN_USE(cpu, node)) { + if (!cpu->in_cpu_list) { /* there is nothing to undo since cpu_exec_init() hasn't been call= ed */ qemu_mutex_unlock(&qemu_cpu_list_lock); return; diff --git a/include/qom/cpu.h b/include/qom/cpu.h index bd796579ee..aa555e27a7 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -411,6 +411,8 @@ struct CPUState { =20 bool ignore_memory_transaction_failures; =20 + bool in_cpu_list; /* protected by qemu_cpu_list_lock */ + /* Note that this is accessed at the start of every TB via a negative offset from AREG0. Leave this field at the end so as to make the (absolute value) offset as small as possible. This reduces code --=20 2.17.1