From nobody Wed Nov 5 10:41:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534126972449602.4278237435544; Sun, 12 Aug 2018 19:22:52 -0700 (PDT) Received: from localhost ([::1]:37165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fp2VF-0004d0-RG for importer@patchew.org; Sun, 12 Aug 2018 22:22:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fp2T0-0003Mp-N4 for qemu-devel@nongnu.org; Sun, 12 Aug 2018 22:20:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fp2Sx-0007jf-Gt for qemu-devel@nongnu.org; Sun, 12 Aug 2018 22:20:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38922 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fp2Su-0007bQ-5O; Sun, 12 Aug 2018 22:20:16 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C32664022414; Mon, 13 Aug 2018 02:20:15 +0000 (UTC) Received: from localhost (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FF5110031F2; Mon, 13 Aug 2018 02:20:15 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Mon, 13 Aug 2018 04:19:51 +0200 Message-Id: <20180813022006.7216-3-mreitz@redhat.com> In-Reply-To: <20180813022006.7216-1-mreitz@redhat.com> References: <20180813022006.7216-1-mreitz@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 13 Aug 2018 02:20:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 13 Aug 2018 02:20:15 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mreitz@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 02/17] mirror: Make wait_for_any_operation() coroutine_fn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Jeff Cody , Fam Zheng , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" mirror_wait_for_any_operation() calls qemu_co_queue_wait(), which is a coroutine_fn (technically it is a macro which resolves to a coroutine_fn). Therefore, this function needs to be a coroutine_fn as well. This patch makes it and all of its callers coroutine_fns. Signed-off-by: Max Reitz Reviewed-by: Jeff Cody --- block/mirror.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 85f5742eae..c28b6159d5 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -279,7 +279,8 @@ static int mirror_cow_align(MirrorBlockJob *s, int64_t = *offset, return ret; } =20 -static inline void mirror_wait_for_any_operation(MirrorBlockJob *s, bool a= ctive) +static inline void coroutine_fn + mirror_co_wait_for_any_operation(MirrorBlockJob *s, bool active) { MirrorOp *op; =20 @@ -297,10 +298,11 @@ static inline void mirror_wait_for_any_operation(Mirr= orBlockJob *s, bool active) abort(); } =20 -static inline void mirror_wait_for_free_in_flight_slot(MirrorBlockJob *s) +static inline void coroutine_fn + mirror_co_wait_for_free_in_flight_slot(MirrorBlockJob *s) { /* Only non-active operations use up in-flight slots */ - mirror_wait_for_any_operation(s, false); + mirror_co_wait_for_any_operation(s, false); } =20 /* Perform a mirror copy operation. @@ -343,7 +345,7 @@ static void coroutine_fn mirror_co_read(void *opaque) =20 while (s->buf_free_count < nb_chunks) { trace_mirror_yield_in_flight(s, op->offset, s->in_flight); - mirror_wait_for_free_in_flight_slot(s); + mirror_co_wait_for_free_in_flight_slot(s); } =20 /* Now make a QEMUIOVector taking enough granularity-sized chunks @@ -549,7 +551,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlo= ckJob *s) =20 while (s->in_flight >=3D MAX_IN_FLIGHT) { trace_mirror_yield_in_flight(s, offset, s->in_flight); - mirror_wait_for_free_in_flight_slot(s); + mirror_co_wait_for_free_in_flight_slot(s); } =20 if (s->ret < 0) { @@ -600,10 +602,10 @@ static void mirror_free_init(MirrorBlockJob *s) * mirror_resume() because mirror_run() will begin iterating again * when the job is resumed. */ -static void mirror_wait_for_all_io(MirrorBlockJob *s) +static void coroutine_fn mirror_co_wait_for_all_io(MirrorBlockJob *s) { while (s->in_flight > 0) { - mirror_wait_for_free_in_flight_slot(s); + mirror_co_wait_for_free_in_flight_slot(s); } } =20 @@ -762,7 +764,7 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJo= b *s) if (s->in_flight >=3D MAX_IN_FLIGHT) { trace_mirror_yield(s, UINT64_MAX, s->buf_free_count, s->in_flight); - mirror_wait_for_free_in_flight_slot(s); + mirror_co_wait_for_free_in_flight_slot(s); continue; } =20 @@ -770,7 +772,7 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJo= b *s) offset +=3D bytes; } =20 - mirror_wait_for_all_io(s); + mirror_co_wait_for_all_io(s); s->initial_zeroing_ongoing =3D false; } =20 @@ -916,7 +918,7 @@ static void coroutine_fn mirror_run(void *opaque) /* Do not start passive operations while there are active * writes in progress */ while (s->in_active_write_counter) { - mirror_wait_for_any_operation(s, true); + mirror_co_wait_for_any_operation(s, true); } =20 if (s->ret < 0) { @@ -942,7 +944,7 @@ static void coroutine_fn mirror_run(void *opaque) if (s->in_flight >=3D MAX_IN_FLIGHT || s->buf_free_count =3D= =3D 0 || (cnt =3D=3D 0 && s->in_flight > 0)) { trace_mirror_yield(s, cnt, s->buf_free_count, s->in_flight= ); - mirror_wait_for_free_in_flight_slot(s); + mirror_co_wait_for_free_in_flight_slot(s); continue; } else if (cnt !=3D 0) { delay_ns =3D mirror_iteration(s); @@ -1028,7 +1030,7 @@ immediate_exit: assert(ret < 0 || ((s->common.job.force_cancel || !s->synced) && job_is_cancelled(&s->common.job))); assert(need_drain); - mirror_wait_for_all_io(s); + mirror_co_wait_for_all_io(s); } =20 assert(s->in_flight =3D=3D 0); @@ -1098,11 +1100,11 @@ static void mirror_complete(Job *job, Error **errp) job_enter(job); } =20 -static void mirror_pause(Job *job) +static void coroutine_fn mirror_pause(Job *job) { MirrorBlockJob *s =3D container_of(job, MirrorBlockJob, common.job); =20 - mirror_wait_for_all_io(s); + mirror_co_wait_for_all_io(s); } =20 static bool mirror_drained_poll(BlockJob *job) --=20 2.17.1