From nobody Wed Nov 5 07:14:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533922917514202.463648409259; Fri, 10 Aug 2018 10:41:57 -0700 (PDT) Received: from localhost ([::1]:57438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBQ2-0006VT-LG for importer@patchew.org; Fri, 10 Aug 2018 13:41:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBOA-0004Kr-KY for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foBO6-0001Qp-OH for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:50 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:53661) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1foBO6-0001PY-2W for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:46 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 38434324; Fri, 10 Aug 2018 13:39:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 10 Aug 2018 13:39:44 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E0F310255; Fri, 10 Aug 2018 13:39:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=KaG2riUEqIdNq9 wIt1lDcPeHXs9zcr6mUNDFRTGwRNE=; b=ZlzekSY0xhCYQ8c1EhtjFM6rsZM19p xAJNi9v6qEC+cdCY4DMeWEGFN5uWkGZVX4N9XTBiTKpkP1ZzBc1RDf8NX+jl1Ssy dk8L1YiqeMLUSGgZr07IQPRCunZP1fgtU/5Pl+k48sLfKk0toF4j7UiSYkj8pXnV EvHW+x8BpXvfs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=KaG2riUEqIdNq9wIt1lDcPeHXs9zcr6mUNDFRTGwRNE=; b=R6BRFpmh RRM8KL+RJB+D69HHXTUbfPGOTab279EGhIEH4Mf5lO13jaJcf3AxkQ16nCS/Zkj+ e/8r3TiZB3BGN6PMLl9sGfG5ftOjGIZgzlzNKkk18PXe9/hE1bMGXPuGTc8Sk3jK xavl1WhNziEwqizMJXQCVfh5dXjiAhxtk4Uq1As5CVh267CllP+1EqIkNl2QVsMo B4wCa1DIzBnqC5KdhOnxRy9QonoRTEhPL+3YByKW78tBvWfjLIA7EcdGzIAE7AA7 zsSV0nB7c1JzYrngspzvFUDeeYXzMcHIntlLYsrs5BGeoLhX8Gx8Yds1sV9PtoLE 0epjppj3sGJ+6A== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 13:39:39 -0400 Message-Id: <20180810173941.5301-2-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810173941.5301-1-cota@braap.org> References: <20180810173941.5301-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 Subject: [Qemu-devel] [PATCH v2 1/3] target/riscv: optimize cross-page direct jumps in softmmu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Richard Henderson , Sagar Karandikar , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/riscv/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 0b6be74f2d..ec2988b4f6 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -135,7 +135,7 @@ static void gen_goto_tb(DisasContext *ctx, int n, targe= t_ulong dest) if (ctx->base.singlestep_enabled) { gen_exception_debug(); } else { - tcg_gen_exit_tb(NULL, 0); + tcg_gen_lookup_and_goto_ptr(); } } } --=20 2.17.1 From nobody Wed Nov 5 07:14:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533922924274358.31313610201414; Fri, 10 Aug 2018 10:42:04 -0700 (PDT) Received: from localhost ([::1]:57441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBQ4-0006YF-SZ for importer@patchew.org; Fri, 10 Aug 2018 13:41:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBOA-0004Kq-K8 for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foBO6-0001Qc-MH for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:50 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:35729) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1foBO6-0001PW-2Y for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:46 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 39DBC327; Fri, 10 Aug 2018 13:39:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 10 Aug 2018 13:39:44 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 517F310273; Fri, 10 Aug 2018 13:39:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=Q4xpNbRPgefAIu cpyqKdZzDzvRzrOYXZVKIdENpVsUg=; b=ReUEydrd3vACuYFt+m+LZaqvctFAxZ 6/rG2I9thwwpC69jgnIYJAc8+HStoNo1xnZYy1bvr73ECUqm2kT/9V7IceQHMwbM AN4re15hO1m0sR2jGO4i5tKbOF6xRL3ju+YfFpNzPFhFl8quyIl99bmrCrHQtLxg gzgcd2QBv/14s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=Q4xpNbRPgefAIucpyqKdZzDzvRzrOYXZVKIdENpVsUg=; b=ZcKUUeZC ijtvJUv/d5TM7EPJk1YeFYlNpEqw5tzppiNUjtRCN+c9I9poxn09i4aCULXhh1bG WtTRyKFuL2YD/JCf0rw4JlBJECu9AgY/KugyYFC6s+hstTmUGfiFklNW6bdghxHH lhP1ojk1WfSJuV9XSQvmTEuDJMce7sM7HL9Bn6VPWKuVJ2yeBzaT2P/gEQ+kX0Tc 0iwXcvkb252WcuPx4ueA26l/kB+5hYCkPOIn/RrxgEF1uXlb8Pq/wz5mM4qf9wbu eJl/itPCPYbYcFZOH2uu0WuIiC7/5m3s4vRQdLkL16SJHCKH0bWZrqpeIZJZGbVk /2fcJxj1eRz5uA== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 13:39:40 -0400 Message-Id: <20180810173941.5301-3-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810173941.5301-1-cota@braap.org> References: <20180810173941.5301-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 Subject: [Qemu-devel] [PATCH v2 2/3] target/riscv: optimize indirect branches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Richard Henderson , Sagar Karandikar , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- target/riscv/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index ec2988b4f6..66a80ca772 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -548,7 +548,7 @@ static void gen_jalr(CPURISCVState *env, DisasContext *= ctx, uint32_t opc, if (rd !=3D 0) { tcg_gen_movi_tl(cpu_gpr[rd], ctx->pc_succ_insn); } - tcg_gen_exit_tb(NULL, 0); + tcg_gen_lookup_and_goto_ptr(); =20 if (misaligned) { gen_set_label(misaligned); --=20 2.17.1 From nobody Wed Nov 5 07:14:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533922916645751.5671499082518; Fri, 10 Aug 2018 10:41:56 -0700 (PDT) Received: from localhost ([::1]:57440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBQ2-0006WV-Na for importer@patchew.org; Fri, 10 Aug 2018 13:41:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foBOA-0004Ku-Lo for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foBO6-0001Qu-Np for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:50 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:50677) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1foBO6-0001PU-2U for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:39:46 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4B06D328; Fri, 10 Aug 2018 13:39:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 10 Aug 2018 13:39:44 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 8638C1028C; Fri, 10 Aug 2018 13:39:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=DAuITGlgdVQ5Iu SX/hg/+Vcd/9SaP+WmNseOhvdtc9k=; b=djPiRnixbnEz9jyi+uaoDxLoBBUUln xacS3tG31xBOd4dBp+zVezJfhbnq1prJnVRcEgFaC4juHlrgMRZONl7CPeUSfq4p vZapswuQDntoF/9GT+xb0C4KdSSKZkJLX1jn8h86HjuU5Rgvx56A6owoH2ruA/E7 hgmRdalh4s9AY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=DAuITGlgdVQ5IuSX/hg/+Vcd/9SaP+WmNseOhvdtc9k=; b=ZO1WjR0t 0MGKF4VBG34HPfC4tqkYGVF+LLahG4Lk2s3vNmOSOTcUGxz4echaC0YLhEW0taPy l5gpa+tYHMmk4fjhsdz/kWos4GRYcxxDTEjp2bbQlVz0H6f3WdTJ4X4T9UWIDrSx Qd2FarR5HixGyTPcHaGsHUJbszs7oJZwpJC0plQVXhOgS7PGV32HpPsMtFQSAVjT gRnqRvZRjf63oSPc1cnlIFULf/4RL8l1QpzhwyyskmGiLl95PKmDEvMrbhZW9t88 aTO64eBytoErxsQryEuLz4XTx5DcVXrQxK8FS/nBRw+2i2arQECMYfWZE2GDy2jk HvRAbubASj2eYg== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 13:39:41 -0400 Message-Id: <20180810173941.5301-4-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810173941.5301-1-cota@braap.org> References: <20180810173941.5301-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 Subject: [Qemu-devel] [PATCH v2 3/3] target/riscv: call gen_goto_tb on DISAS_TOO_MANY X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Richard Henderson , Sagar Karandikar , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Performance impact of this and the previous commits, measured with the very-easy-to-cross-compile rv8-bench: https://github.com/rv8-io/rv8-bench Host: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz - Key: before: master after1,2,3: the 3 commits in this series (i.e. 3 is this commit) - User-mode: bench before after1 after2 after3 final speedup Reviewed-by: Richard Henderson --------------------------------------------------------- aes 1.12s 1.12s 1.10s 1.00s 1.12 bigint 0.78s 0.78s 0.78s 0.78s 1 dhrystone 0.96s 0.97s 0.49s 0.49s 1.9591837 miniz 1.94s 1.94s 1.88s 1.86s 1.0430108 norx 0.51s 0.51s 0.49s 0.48s 1.0625 primes 0.85s 0.85s 0.84s 0.84s 1.0119048 qsort 4.87s 4.88s 1.86s 1.86s 2.6182796 sha512 0.76s 0.77s 0.64s 0.64s 1.1875 (after1 only applies to softmmu, so no surprises here) - Full-system (fedora): bench before after1 after2 after3 final speedup --------------------------------------------------------- aes 2.68s 2.54s 2.60s 2.34s 1.1452991 bigint 1.61s 1.56s 1.55s 1.64s 0.98170732 dhrystone 1.78s 1.67s 1.25s 1.24s 1.4354839 miniz 3.53s 3.35s 3.28s 3.35s 1.0537313 norx 1.13s 1.09s 1.07s 1.06s 1.0660377 primes 15.37s 15.41s 15.20s 15.37s 1 qsort 7.20s 6.71s 3.85s 3.96s 1.8181818 sha512 1.07s 1.04s 0.90s 0.90s 1.1888889 SoftMMU slows things down, so the numbers are less sensitive. Cross-page jumps improve things a little bit, though. Note that I'm not showing here averages, just results from a single run, so with primes there isn't much to worry about. Signed-off-by: Emilio G. Cota --- target/riscv/translate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 66a80ca772..18d7b6d147 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1868,12 +1868,7 @@ static void riscv_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cpu) =20 switch (ctx->base.is_jmp) { case DISAS_TOO_MANY: - tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next); - if (ctx->base.singlestep_enabled) { - gen_exception_debug(); - } else { - tcg_gen_exit_tb(NULL, 0); - } + gen_goto_tb(ctx, 0, ctx->base.pc_next); break; case DISAS_NORETURN: break; --=20 2.17.1