From nobody Wed Nov 5 10:43:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533874210074844.4907384034613; Thu, 9 Aug 2018 21:10:10 -0700 (PDT) Received: from localhost ([::1]:54176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnyka-0001yZ-T2 for importer@patchew.org; Fri, 10 Aug 2018 00:10:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnyj0-00012i-FR for qemu-devel@nongnu.org; Fri, 10 Aug 2018 00:08:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnyiw-0002nj-Es for qemu-devel@nongnu.org; Fri, 10 Aug 2018 00:08:30 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnyiw-0002n2-8v; Fri, 10 Aug 2018 00:08:26 -0400 Received: by mail-qk0-x241.google.com with SMTP id u21-v6so5586909qku.2; Thu, 09 Aug 2018 21:08:26 -0700 (PDT) Received: from localhost.localdomain ([186.223.91.15]) by smtp.gmail.com with ESMTPSA id s53-v6sm6561555qts.5.2018.08.09.21.08.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 21:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F6sddB7xBSDnVR3yVuFsA5iYHg4qxv4ct5JruTbqyMg=; b=kTx7i1jGDoaEi2zSY3iAEfMr/hEQ+WE4nQciS9xwyLMRzmVini9fxIUgrK0SzLpgzM Xw8XpFNdWXCmo26aRYTXCzNpLwjme/rNz9iXk4zmnspy9Bpdof1pFexR8ssT5zLWb4XI +CErPtNLUg00FyNSAC6NefGDzIBGvNpRXHllFBs3KqYABgw2fx2FYZCH8iD0DE5A0P4F vyb5f1lJs6r9e5+Sr3BsqjDyM8H2I4pNQIiZVSepTHupq6EG60Flx9QMGPGqMC6wZmSj YbzAMk9mlvMvG3X/9PzYj9IEyXJC1LbRRDelFlcmIFne7X+s6XFN83X+uVKGLZ7o5aXx vygA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F6sddB7xBSDnVR3yVuFsA5iYHg4qxv4ct5JruTbqyMg=; b=aOfJXSKJD9XMVOkPfx+Ye0/K2YnyebM6+f7hSBgbqeGr09Udj/2vw2kFa7aXZSGvRH 1frfvIsUTgGTthZGMv2ssDU1vTe7Dx7dpJH7jtzsrX+xxkFVujpOFXSzTESa4rpjOh24 sRsy84TLR6U0hHU6pJkW9ZgXJQ22hZmlW2AIuEzHjoVUEpIcN+iyW/sfDpuq69QIeIc9 ejPVQDhSkAw9Em/DFp+40DJexA29ACMDMn7q0LZ6CLagftJFAGIQiYuQHTc0msTwTlWP DAo3VYLlhSWWHSnGzleYHnoWKAOTZJKRq8QeZC/VBxFOIFXQ29gtH3KKQSHKqtSPRGvt w83Q== X-Gm-Message-State: AOUpUlHIlIeEap04ZjG5UCHJEWkzx9k5Up47u4zVyx8Ne5LCZHxIaETK D4qJ6AhThZvrRXU2TsEKTSkIuhPN X-Google-Smtp-Source: AA+uWPwhWIzYoEZ2sXi0LAkvr2o0gzj2rrwqZD1VqJkayBl5vIXnvHDT4K09GiPgYj05waCTarbluA== X-Received: by 2002:a37:c3cf:: with SMTP id r76-v6mr4428239qkl.150.1533874105273; Thu, 09 Aug 2018 21:08:25 -0700 (PDT) From: Julio Faracco To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 01:07:43 -0300 Message-Id: <20180810040743.25424-5-jcfaracco@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810040743.25424-1-jcfaracco@gmail.com> References: <20180810040743.25424-1-jcfaracco@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/block/dmg.c b/block/dmg.c index 390ab67e53..ae379adb20 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -44,6 +44,19 @@ enum { DMG_SECTORCOUNTS_MAX =3D DMG_LENGTHS_MAX / 512, }; =20 +enum { + /* DMG Block Type */ + UDZE=3D0, /* Zeroes */ + UDRW, /* RAW type */ + UDIG, /* Ignore */ + UDCO=3D0x80000004, + UDZO, + UDBZ, + ULFO, + UDCM=3D0x7ffffffe, /* Comments */ + UDLE /* Last Entry */ +}; + static int dmg_probe(const uint8_t *buf, int buf_size, const char *filenam= e) { int len; @@ -108,16 +121,16 @@ static void update_max_chunk_size(BDRVDMGState *s, ui= nt32_t chunk, uint32_t uncompressed_sectors =3D 0; =20 switch (s->types[chunk]) { - case 0x80000005: /* zlib compressed */ - case 0x80000006: /* bzip2 compressed */ - case 0x80000007: /* lzfse compressed */ + case UDCO: /* zlib compressed */ + case UDBZ: /* bzip2 compressed */ + case ULFO: /* lzfse compressed */ compressed_size =3D s->lengths[chunk]; uncompressed_sectors =3D s->sectorcounts[chunk]; break; - case 1: /* copy */ + case UDRW: /* copy */ uncompressed_sectors =3D DIV_ROUND_UP(s->lengths[chunk], 512); break; - case 2: /* zero */ + case UDIG: /* zero */ /* as the all-zeroes block may be large, it is treated specially: = the * sector is not copied from a large buffer, a simple memset is us= ed * instead. Therefore uncompressed_sectors does not need to be set= . */ @@ -186,13 +199,13 @@ typedef struct DmgHeaderState { static bool dmg_is_known_block_type(uint32_t entry_type) { switch (entry_type) { - case 0x00000001: /* uncompressed */ - case 0x00000002: /* zeroes */ - case 0x80000005: /* zlib */ + case UDRW: /* uncompressed */ + case UDIG: /* zeroes */ + case UDCO: /* zlib */ return true; - case 0x80000006: /* bzip2 */ + case UDBZ: /* bzip2 */ return !!dmg_uncompress_bz2; - case 0x80000007: /* lzfse */ + case ULFO: /* lzfse */ return !!dmg_uncompress_lzfse; default: return false; @@ -592,7 +605,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) =20 s->current_chunk =3D s->n_chunks; switch (s->types[chunk]) { /* block entry type */ - case 0x80000005: { /* zlib compressed */ + case UDZO: { /* zlib compressed */ /* we need to buffer, because only the chunk as whole can be * inflated. */ ret =3D bdrv_pread(bs->file, s->offsets[chunk], @@ -615,7 +628,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) return -1; } break; } - case 0x80000006: /* bzip2 compressed */ + case UDBZ: /* bzip2 compressed */ if (!dmg_uncompress_bz2) { break; } @@ -636,7 +649,7 @@ static inline int dmg_read_chunk(BlockDriverState *bs, = uint64_t sector_num) return ret; } break; - case 0x80000007: + case ULFO: if (!dmg_uncompress_lzfse) { break; } @@ -657,14 +670,14 @@ static inline int dmg_read_chunk(BlockDriverState *bs= , uint64_t sector_num) return ret; } break; - case 1: /* copy */ + case UDRW: /* copy */ ret =3D bdrv_pread(bs->file, s->offsets[chunk], s->uncompressed_chunk, s->lengths[chunk]); if (ret !=3D s->lengths[chunk]) { return -1; } break; - case 2: /* zero */ + case UDIG: /* zero */ /* see dmg_read, it is treated specially. No buffer needs to be * pre-filled, the zeroes can be set directly. */ break; --=20 2.17.1