From nobody Wed Nov 5 10:32:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533824684365123.61285665199216; Thu, 9 Aug 2018 07:24:44 -0700 (PDT) Received: from localhost ([::1]:51154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnlrn-0000fo-3o for importer@patchew.org; Thu, 09 Aug 2018 10:24:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnlod-0004Pf-FI for qemu-devel@nongnu.org; Thu, 09 Aug 2018 10:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnloa-0004f2-2l for qemu-devel@nongnu.org; Thu, 09 Aug 2018 10:21:27 -0400 Received: from mail-dm3nam03on0106.outbound.protection.outlook.com ([104.47.41.106]:60131 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnloZ-0004eW-Qx; Thu, 09 Aug 2018 10:21:23 -0400 Received: from Jupiter.local (141.226.29.227) by CY1PR07MB2618.namprd07.prod.outlook.com (2a01:111:e400:c637::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.18; Thu, 9 Aug 2018 14:21:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61HXpQJyq6RI3GZTlx+esLZKnZN2JEIxsOflHnYDkko=; b=SCviGfedD2sufGOyVbnezb73ysUyL3KHRFNBO8AbTFplMEhSeglgYqxhdVRbtt0Ar3dRa2KySzDi3gTpmCXvkLCtt+Wi//KlBVUfooE5Fk75UxFRoOnL4XPHRrbC2FAZdX0FQCpzlzIc7scZ6BGBHXVqPd9mMHXCGf7lI9J959k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; From: Leonid Bloch To: qemu-devel@nongnu.org Date: Thu, 9 Aug 2018 17:20:45 +0300 Message-Id: <20180809142046.12311-5-lbloch@janustech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180809142046.12311-1-lbloch@janustech.com> References: <20180809142046.12311-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: DB6PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:4:29::14) To CY1PR07MB2618.namprd07.prod.outlook.com (2a01:111:e400:c637::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdcb72ee-0330-4bf5-8122-08d5fe03620d X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2618; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 3:cFaaUAK80qo3p+4SF8oTc6avE+Kbd+1UjGb7m/715lLgNNSaKZ+iHFo5O8MQOgrLE+fElcrPZAvUZsTIKeqa9vXbQfnrR1epd0iz4vMge/PpXpMfz5zn4KzoxGJUUCQNvPEeDDiVyxMtUXHeqebg7o0Do9OyHWR5dFYoR7iiuibNiEVBaZi8TcbFMc20J/eeUU956+PTSPktpl2seXDLC08YfLyJ/59tZLy3evBYlzL7ZnoFzqE3UAWLdN4UGDhf; 25:jfew44UZ061xxNGwlaZMNy7ZpSVY3bD7uEEgC+Mi+i8p/gXsCaRxnRNRk5IZOTQjcVcHpaLp3OlbvFo0AHKT2KqhceF6kcW6XlnqJgtAFph+mkh3ySE2oIKMDp/uMYiAolCLzXt8ptitKASvGVEegSBKtnPHmihqC+r0NUTWK6kvVkXVKlNkVHZButk+92fI2YR4hCZ5Tghcla9u9bYcr+lVL3TP2o43cegjzuV55shznMuj6TYDmLQuxJXo/wEs1usDun0NjZdeivTjtZNlUFWuveWaqb5mOxzcAv4Qm+uH8FnyQzuInBaeAcMX4H+oqaSUb1yzQHpe6Op4JwBXeA==; 31:Fp6E3C+mn7GrfXCVP8yfDm6NYZEHUSVR4NeTuNl1BFIc5/TzhFwc2soc24AKUh18CKfRCBejMaij24yIGWNSNZMZvIxGEsWhsB/JxWWrGiEy2++0Qb9CQNuoJn5Sh6ZwNAH5CRlOgkNYNUttZGUyOgu8hjPqiwq6dJaMZokRd0uY/ysuKTKpItdg0bNyRxNOltJYLuLn7bR60eg7/tJuychszTf84p2raytYG9dtQ3A= X-MS-TrafficTypeDiagnostic: CY1PR07MB2618: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(2016111802025)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6043046)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB2618; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2618; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 4:L9uJCp2JKYV0FgwiaPt4Y49PkTkOREuFYHn99sXQj9+zE/4geLSpvB6y3BPgrNj6lbaR/oIUKSJOsyXcSjT5/U8pMf2qVnUJq9Mv2WxniC0Zn3t1P/LgHJLuxS2f2x5m7tvBNEprbon/mn7mI35ID6q5+HYHdxpSGS3JsjXsnGBCm48tCAzvKGaV5jzVyPKM5l+iaPH93m9tCAZoBADamK3XDkZrTeRVHpilq+5HVpKEAhpWNh8Lmv84/M/8wq0Stt69J3juuVPOra+qnnwa3g== X-Forefront-PRVS: 0759F7A50A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(39830400003)(136003)(366004)(199004)(189003)(25786009)(68736007)(53936002)(6666003)(81156014)(14444005)(81166006)(47776003)(6916009)(50226002)(6512007)(8676002)(305945005)(107886003)(7736002)(4326008)(86362001)(186003)(66066001)(26005)(2616005)(956004)(446003)(478600001)(11346002)(486006)(16526019)(386003)(476003)(6506007)(316002)(106356001)(105586002)(50466002)(48376002)(5660300001)(8936002)(6486002)(36756003)(54906003)(16586007)(51416003)(52116002)(76176011)(2906002)(6116002)(3846002)(2361001)(1076002)(97736004)(2351001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR07MB2618; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2618; 23:Ay9QQQNvtJfkfxrBOb7+f5dkqtW8alD+TBtMC5yPW?= =?us-ascii?Q?1uzpBDMaKYoukXqWYrrYVrWaZ5w6M+0ImwhBgEhKvg/2lzUC6NfL+zXHM71a?= =?us-ascii?Q?fjeES8K1EfQnUoZqxjw168CVMdyP2CvJu7I+TjnXlHbVmDQUsd/0F1ipAgF3?= =?us-ascii?Q?gVIxE6dpHHTJX0ysAh0dRQDnNoufFa1TOcv4mRAzWN7LutEy9PLbfJG/Me4u?= =?us-ascii?Q?AjgRqrne44oJOdtNJeyuGTPb63hwRTKQv2z0YsD44Rgz1qcTC77tCz/azWWt?= =?us-ascii?Q?EEFODDXLIEFUn7efWxP5UPcl7ORVPR9A1tc6xiriJSmBhCPQ38Mlcf9sOHEx?= =?us-ascii?Q?xaolFj/BDrmrEF7hZHf7Watb2Vs2/llh06yfDSVIQyKSZwgzvsQMCZalhJ08?= =?us-ascii?Q?N1Nk7u+oIoOIaoOXw3+tFWEfn8sVlQ8tstDCLbKl3NZ2TlXFE2Y+QxnDAblp?= =?us-ascii?Q?k81WuAc/pRGCPkCdLXBfOKndtPB5t8P9LWSsvz1RAnuqBhO0MIGXOa+T+lHF?= =?us-ascii?Q?1b7S5PGJBuP9xJjTSZtGX+Xi2466MKSCAOwDt3h0QtL8DEY6wyhW1a6q3TJb?= =?us-ascii?Q?c7UUeri5fGA3oXdnhbj4Kh784BYI/i1TcBAt/DsP42DELqO2B7OxlTjISrZt?= =?us-ascii?Q?kaQKoUSC+v1iQFlQ1rEOSA0CiwH9tNgkEQhYaUevbHC10vOIVXDw8t9mydEv?= =?us-ascii?Q?J8UYugc8NVvVbL74wj10mI5X0DIvPIxbZkW5zrRy4mk/gtvtP8VV2PHD9LST?= =?us-ascii?Q?LMMweGM6rBtS65AXeGLBS9Q/XlX5NVNT8HxfwtyeRIQUP/HvQbDJpRYtvQq7?= =?us-ascii?Q?vOhKhjNJh8oCMO2S9fP0WI5mP2IJo5haTeqxF/aguIm5nzpS9AEAdqG/OGmC?= =?us-ascii?Q?jcdNqnoQTiYqmw1WcoRf1gJY2e02cS/ln2n4HRzWfq0Rg0VFx3CQ6UJaXdzs?= =?us-ascii?Q?lu8StgMXl2JT9c4x31wzsPK9LPODarHG75aBAkjhBnKvUfJ9ayy3504ItzI9?= =?us-ascii?Q?i2OibmFYVFLXDd92Wr8bo5ioEvvl/7AznQJ+XQTfo9pfhAutPK2S9jOxgaF3?= =?us-ascii?Q?b0X7bw2ZhmIPyNUrmkiNME7G6HnsmcmEfFrK0DpZTbTH+8pnVP0uhLTVXIK+?= =?us-ascii?Q?6FTpxkwYfTyK+8Oi2AtRdEvkWcdhKZ0UVk6Y908hJAM3sToeC+sKJZm1WadA?= =?us-ascii?Q?DzleWTwGheriGQVVIE1cjWIZnoCW9ZozwnQf+kZ7OVVMsojouEtLMn3BiOyz?= =?us-ascii?Q?Weghcu3nAF8mBsBPjPdxuJrySNlKx5RuP9kWa4GgUcvNjO0msXWDFFZlAdwF?= =?us-ascii?B?UT09?= X-Microsoft-Antispam-Message-Info: KulN6jw9tRLi24f1QO+RyFkYSrceE60IQiABr1KgRdXycTzB3ZJXaFrT6+LQBQKKkuFp93EdFghYGdWYkO/luixmRfSAMGgbLgtBXrljfPoldlN0GOZQDVkY1kZPG5fkHiI/yEpTSXfRpeTiGq7NiB4ph/6LzoPwjgsbzKzdZMaVKJ14wsiW/B++q09GEaUSQvZhQ1K4GTQfnGdkJReD/LxLfOreH13bP0LuggVpto+IS539g+sjmPhrJql2qU4uS8I6RcxQ1Nrqx1p7TQzM0zuDFADJBbaScOQqrmTIG9BCdg8NfljpDzky17PADqUHY8figY4jSsJmthCeNPtNklzBpf0LWO2srVZPpeqgjtg= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2618; 6:kwcuXN7z306IJ69dgxVgsSWp3jPX7oDNQnXpQw/t0s72cdU+Jz672PwB6q63CqdH7wIi8fa4/xGZywbZw118V86/bRYJ2c3yPqEcT8O31DLstdS8thaooiOIif9xay293LlKomteSviLyLy68sTtqGLbM/8bWA3WZ+sCncwfx0e30zPHPhYHlu00yNd+/NJ5k+hcKzCgJu2twxeTsbwL3ZcwpWcVcSj2NUfHE6HtssD/zdVZBHPYVIUsRjHg1WtmEWplzHD/AvbEX0nQrjQ8OLLm2JsPz5yrySegOb++Fvl4BTLqIaTvsRavvoaGQgSsiWwuWlufypH7tNz0E5FoEe0fwJW/Armq8PAy1e78u84aPfk99HeABllbmoZtqBotuMwYMi0x36Fl+HJf3cqjbXuFMlQjFlljC/BzmZqUm4UxwFC3YDKcynK1/1bOCXCgAbwGfSQYA24RG06gUQAFgw==; 5:kMKnB6t+v1OA/ZIbPLMsbiMng1TkEuATs/GbnjAnApR1rn5W9rG9M1nObuZnB6pBgv3zLWmNBAs7S06dUzVYb6Z1tZkU4fNFBB50EHNyypcobAsS4i3xBScW5X91n8qQI9Bznqf8VXp5xtqsbCJk7eC8StkQBPVxcCalsJbbTpU=; 7:NE+xzrnZBWspgeXD33iyWZWDv/CJufQx09kLOUnM/a5ndmEimOX782CtDyKt3Q8gcNSEAzqQAemXbbDBA3PIgqyiNFILVLFJMjGdepwM8U8Qe8LbLiq4J0D5KIiklKZhiQBWYnZ+4r1BpKhRVwNCndromx5PfQya1I/sNV8cUVUeTTo92dYkPb8KI4tbigq1ExpQpEHFsryOaGCaWfn0xUHtEVw4xtwJh1s/VFXXFy6wU6Yhxra8pp2cbzaD3DjC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2018 14:21:20.7920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bdcb72ee-0330-4bf5-8122-08d5fe03620d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2618 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.41.106 Subject: [Qemu-devel] [PATCH v5 4/5] qcow2: Set the default cache-clean-interval to 10 minutes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Leonid Bloch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 2 +- block/qcow2.h | 1 + docs/qcow2-cache.txt | 4 ++-- qapi/block-core.json | 3 ++- qemu-options.hx | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 36113d199e..13715bbf2c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -942,7 +942,7 @@ static int qcow2_update_options_prepare(BlockDriverStat= e *bs, /* New interval for cache cleanup timer */ r->cache_clean_interval =3D qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, - s->cache_clean_interval); + DEFAULT_CACHE_CLEAN_INTERVAL); #ifndef CONFIG_LINUX if (r->cache_clean_interval !=3D 0) { error_setg(errp, QCOW2_OPT_CACHE_CLEAN_INTERVAL diff --git a/block/qcow2.h b/block/qcow2.h index d77a31d932..587b053453 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -77,6 +77,7 @@ =20 #define DEFAULT_CLUSTER_SIZE 65536 =20 +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */ =20 #define QCOW2_OPT_LAZY_REFCOUNTS "lazy-refcounts" #define QCOW2_OPT_DISCARD_REQUEST "pass-discard-request" diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 6ad1081d1a..684147ad45 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -204,8 +204,8 @@ This example removes all unused cache entries every 15 = minutes: =20 -drive file=3Dhd.qcow2,cache-clean-interval=3D900 =20 -If unset, the default value for this parameter is 0 and it disables -this feature. +If unset, the default value for this parameter is 600. Setting it to 0 +disables this feature. =20 Note that this functionality currently relies on the MADV_DONTNEED argument for madvise() to actually free the memory. This is a diff --git a/qapi/block-core.json b/qapi/block-core.json index 5b9084a394..9a6a708a37 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2830,7 +2830,8 @@ # # @cache-clean-interval: clean unused entries in the L2 and refcount # caches. The interval is in seconds. The default = value -# is 0 and it disables this feature (since 2.5) +# is 600, and 0 disables this feature. (since 2.5) +# # @encrypt: Image decryption options. Mandatory for # encrypted images, except when doing a metadata-o= nly # probe of the image. (since 2.10) diff --git a/qemu-options.hx b/qemu-options.hx index 4c44cdbc23..6abf3631ec 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -767,7 +767,7 @@ it which is not used for the L2 cache) =20 @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in sec= onds. -The default value is 0 and it disables this feature. +The default value is 600. Setting it to 0 disables this feature. =20 @item pass-discard-request Whether discard requests to the qcow2 device should be forwarded to the da= ta --=20 2.17.1