From nobody Wed Nov 5 10:41:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533789166839906.4682993026593; Wed, 8 Aug 2018 21:32:46 -0700 (PDT) Received: from localhost ([::1]:47278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnccu-0001ue-Lx for importer@patchew.org; Thu, 09 Aug 2018 00:32:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fncSw-0000sl-GW for qemu-devel@nongnu.org; Thu, 09 Aug 2018 00:22:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fncSv-0007Kh-KA for qemu-devel@nongnu.org; Thu, 09 Aug 2018 00:22:26 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:41706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fncSv-0007K5-DF for qemu-devel@nongnu.org; Thu, 09 Aug 2018 00:22:25 -0400 Received: by mail-pg1-x52d.google.com with SMTP id z8-v6so2107869pgu.8 for ; Wed, 08 Aug 2018 21:22:25 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id m30-v6sm7355799pff.121.2018.08.08.21.22.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 21:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ze8ZdJDqn6zsWMoBANBrHY4udg1WT+Qa4bIr6PsHaec=; b=e/qei9CvSkQMXtMVhwDal6FZ1VIphr0EApU1biWvNhpHqkEkZyyRT1iHuuRWhzFbXT TzX49Hxg/x46ngiKk7wIfSecasLKnfmP73iZ7YTYJNCmkurTSF/7s1FdeRwsN0Ns4Qhy 5Xfg9+8pcLKXpkZIE+EdJCA+oiiBtq6XhhpwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ze8ZdJDqn6zsWMoBANBrHY4udg1WT+Qa4bIr6PsHaec=; b=cKvUm1vhxfACQ6M9ls42JQ+TiRLowZYUV428i0FkouIaR5zDfLs6deo+FMlJbx19Gu uXIN2pUgkZoLU5hl673vYe8Q8HI7PZHoEUK5t/sfqUmB9fD91MQhiTWwi+Cfw2h5Az1w IFmh5DJDoe/+b8SQvoyt9cJ/yR9km16nwhkDKh8Un8GOq1amQ5ow6xW5vIlFbB6L4Yoc Qab7K8994NOy4qtyVEEua/20GDTHqU0s7Y3phMSQn0J0HIs/aGwSgYQ21GrcOZqeWtIp k0rWBBjWr9m3TC2Q7UPFTBL50aiIu3VKLhFc70aTuYZ4kengbK5MsbT2ihLMrXew39Sm QP0g== X-Gm-Message-State: AOUpUlEMOb/rlOKJUfRujOYP0Gs6CBbBpe9es2PXi5+y2ibMXSeT2O6v YIF5LB4vrLgF6T1auui/lv8SohlD/E4= X-Google-Smtp-Source: AA+uWPyC3GmaC1KwPofvpyNG+2feZ8/PyoSLIwUTOXcOrKzwnSLg/2VRgWW55R/IWs//d2NZvnuAEw== X-Received: by 2002:a63:5055:: with SMTP id q21-v6mr466933pgl.397.1533788544191; Wed, 08 Aug 2018 21:22:24 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 8 Aug 2018 21:21:57 -0700 Message-Id: <20180809042206.15726-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180809042206.15726-1-richard.henderson@linaro.org> References: <20180809042206.15726-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d Subject: [Qemu-devel] [PATCH 11/20] target/arm: Clear unused predicate bits for LD1RQ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The 16-byte load only uses 16 predicate bits. But while reusing the other load infrastructure, we find other bits that are set and trigger an assert. To avoid this and retain the assert, zero-extend the predicate that we pass to the LD1 helper. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index d27bc8c946..bef6b8242d 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4765,12 +4765,33 @@ static void do_ldrq(DisasContext *s, int zt, int pg= , TCGv_i64 addr, int msz) unsigned vsz =3D vec_full_reg_size(s); TCGv_ptr t_pg; TCGv_i32 desc; + int poff; =20 /* Load the first quadword using the normal predicated load helpers. = */ desc =3D tcg_const_i32(simd_desc(16, 16, zt)); - t_pg =3D tcg_temp_new_ptr(); =20 - tcg_gen_addi_ptr(t_pg, cpu_env, pred_full_reg_offset(s, pg)); + poff =3D pred_full_reg_offset(s, pg); + if (vsz > 16) { + /* + * Zero-extend the first 16 bits of the predicate into a temporary. + * This avoids triggering an assert making sure we don't have bits + * set within a predicate beyond VQ, but we have lowered VQ to 1 + * for this load operation. + */ + TCGv_i64 tmp =3D tcg_temp_new_i64(); +#ifdef HOST_WORDS_BIGENDIAN + poff +=3D 6; +#endif + tcg_gen_ld16u_i64(tmp, cpu_env, poff); + + poff =3D offsetof(CPUARMState, vfp.preg_tmp); + tcg_gen_st_i64(tmp, cpu_env, poff); + tcg_temp_free_i64(tmp); + } + + t_pg =3D tcg_temp_new_ptr(); + tcg_gen_addi_ptr(t_pg, cpu_env, poff); + fns[msz](cpu_env, t_pg, addr, desc); =20 tcg_temp_free_ptr(t_pg); --=20 2.17.1