From nobody Wed Nov 5 10:19:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533766664331277.5939148979203; Wed, 8 Aug 2018 15:17:44 -0700 (PDT) Received: from localhost ([::1]:45708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnWlz-0006E7-6F for importer@patchew.org; Wed, 08 Aug 2018 18:17:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnWgj-0002Sg-Rr for qemu-devel@nongnu.org; Wed, 08 Aug 2018 18:12:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnWgi-0002Bu-Ow for qemu-devel@nongnu.org; Wed, 08 Aug 2018 18:12:17 -0400 Received: from mail-co1nam03on071d.outbound.protection.outlook.com ([2a01:111:f400:fe48::71d]:46817 helo=NAM03-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnWgi-0002AH-FH; Wed, 08 Aug 2018 18:12:16 -0400 Received: from Jupiter.local (141.226.29.227) by CY1PR07MB2620.namprd07.prod.outlook.com (2a01:111:e400:c637::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Wed, 8 Aug 2018 22:12:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BN4tGnEj0Huo1qjRFvlRpUtYEQFfCV93mJzDp37zAZw=; b=T1aF34MQen0Kvc9gdP9vcMLuEZAuyfQcGiyNDyUyyLvUjUxrzP/TGYNmUrdb2DTiLWEWALXjWf1TQhhRydogroauxO3J0Ovkn6bWifMsFvaaBLT2ZJWeBhdhUalAZ6p5HC3VQRVXRGcM6MZBQPT5nOD6wo4O85xtd+e8MF3Ou2A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; From: Leonid Bloch To: qemu-devel@nongnu.org Date: Thu, 9 Aug 2018 01:11:37 +0300 Message-Id: <20180808221138.5770-5-lbloch@janustech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180808221138.5770-1-lbloch@janustech.com> References: <20180808221138.5770-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: AM0PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::31) To CY1PR07MB2620.namprd07.prod.outlook.com (2a01:111:e400:c637::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88a206fe-fc88-4bb4-1f90-08d5fd7bff0e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600074)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2620; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 3:UI1mWPE/UTl0UbK0mbtrbdPL9GepFPbNQOBTsigsQxqAM52GQRO9WAWkUHDdwSRzdPqQAaRqNfX47lZ9aibQpTymLkAN6DcUjOMO63ccGXrxS2iKkPR3rsjZk2SPypzMnOTW49qTYk1CeiRWtr6ZODkrOqxkoVbUoAp7V16PzEfK7cmZeppwqmk4wMKqoN3sGH/iA3bZyvSp+TufZMMzh33wlXk5mERhG5dX4lJhXBct32Ci3JP7hArWhODneoed; 25:tPXx34VqpZ9yBPypFf5mXzqL55RBXBBeD9fZpHRG5FK5ABZFHdcPoohKvrUYzZUzP/R7jcdF2i2Auvnyc5raJ4ek9xncpO0NGjW65AAOANBiZF/6YSl8NJCYp62nFWYjcHXuAbCN4ZYzUrVNnaYguUQGsPTknUedN1LNx7jTNtOotiwJDJ0T33uWSKhhcVYP4bHkPOcVp7tqEOqasx+7MNgFFxSpBtKZ323cicdUjz7syVZJg6ZZQj2suFQs67nKe1+JAJgsoiDb9iopBxzKCcVn6dR/Pk7nlhZtUjGCk56pbEDbAcfAdy61FHpYjM7xgOFS3dDjMWdZaegF9t5IbA==; 31:aV0HalqcnHBVhRjZmTLCrQYgGv1R/a9CCfHsSOOMIh2FPXrakkHDlmLPjF1sA62AOgR9mBnG/DnJrLF6umpv8vGiBFDJ0rdgFn77G1Wk1oeuQtK2MnLIvNezIvPu3AfEd2CxrwQYiJc5jerTd/FQebgj/JFGnz5oIz9C8bvc1/Ffwb+1nuy5nh4SDQ4P4coA/TKgVRvJpTt7SYrKPLqKg3hP13Aej18tB/VNO3TYVLo= X-MS-TrafficTypeDiagnostic: CY1PR07MB2620: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123562045)(2016111802025)(20161123558120)(20161123560045)(6043046)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB2620; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2620; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 4:bqREYVioVDeS1iumDk2KKbRfrsreJZROmxS6B9OKB17Ee1uWtfapOSCIEUYuK6Ox8gfXOO7tQN7cdcbNW9vSZPtUcfE2YFhXid0OEJQeynd4G/bOSFy3lwLZ/QFytkwgmEqA9ULOPYYzWhkKBc2EOZQUTumrUzklZUt2VRKX8WzSmPTsuESiZAdZjh9CikO1zkEhC4coNafhpz04NGjiA+gd5kcudzymdzHMzAxDZzxkj5XtcEACfCd663gqyVW2aje1gbZuZ+T4J9FDTj7EHQ== X-Forefront-PRVS: 07584EDBCD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(366004)(376002)(39830400003)(396003)(136003)(189003)(199004)(52116002)(6506007)(386003)(106356001)(97736004)(53936002)(68736007)(2351001)(105586002)(186003)(66066001)(11346002)(47776003)(14444005)(446003)(81166006)(8936002)(16526019)(76176011)(2616005)(956004)(305945005)(6512007)(476003)(7736002)(81156014)(26005)(8676002)(486006)(51416003)(36756003)(86362001)(575784001)(6486002)(50226002)(4326008)(107886003)(2361001)(50466002)(1076002)(478600001)(6916009)(6666003)(48376002)(6116002)(5660300001)(54906003)(16586007)(316002)(2906002)(3846002)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR07MB2620; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2620; 23:6kOQdnfQD2JQlfneb17+zS1VGwjegn1/IIXuIgccU?= =?us-ascii?Q?W7fc52tfQDr/qpMFvTaJwmy4BXdt8ejL4WAxybuIUSIImI8g+qLH+4WmTpr0?= =?us-ascii?Q?3h+0qFum34G8qF9J6QODUbUP4ASOQZ1ui9tHU0X0PdGEgAxVBdH73BsH/Loz?= =?us-ascii?Q?LBEEGJ9ZZDlyA73ZGW/cst4CBPf59y2GS3zfllG4BjlgSK4n1J54MerY4cZP?= =?us-ascii?Q?kDQBiOSjE1PpY47a75hJPc7I42uKhl3tfaWjGuxk8C9LehfY0bSEHL9uM53Q?= =?us-ascii?Q?wZM4dPri8jQXg0bG/ozOiCf/ICNJv4PmT9eLrL5cER0vdI6o6CFhUNlRdC1l?= =?us-ascii?Q?uSv//iSGAzSTYQKlhTGYiPcd4dJ5GG+tvepLelOw9bMDXACAzg9IwY1BEUAq?= =?us-ascii?Q?otg1fFQ+c4LNM8CE2SLxBrTKOraNqCqoyGVV/n3Bd/2zj1ZnV/LGC4TrWHte?= =?us-ascii?Q?615QnDQxY/qOyWRoW0Kz/TbIB/OxZksFkqP3RRSb55XJ/yDf2iLDS0gC444Q?= =?us-ascii?Q?5IlDEl+JnvHMrmnAWFl2iglmKGTpt1DSXZWEtiFtOkfaqOmbLo8fqK38x5fA?= =?us-ascii?Q?B2/DsYstUiDPA1MbysAowhXsyuLRm8+IxEmIl+9tn3zijIuk1iDAIlySwnD9?= =?us-ascii?Q?yMXp9d/VxGTxadG4j+A6xK3jkGDqEuAoQGLHe1bk+0BKrSo+raKynHJAD8TH?= =?us-ascii?Q?WcAfltyTAWyAI7zPKg5k/sUp5WPM5utFQy2qrWDD7EupzrhnLxcSHUcmgsSi?= =?us-ascii?Q?wjN7EMF3Rk7KLYNyTN8fzfM7RMp2lEhf0U+GXayPuOYq1CDhHeePRjVbSewR?= =?us-ascii?Q?OT8EIjIqiUpourLmZXNYJ604O+3cNuGhm5qvAsg9eruzUVawzD9Rm97NZO4Z?= =?us-ascii?Q?wHDWOxK2cogspOWImiQ0lBdObFMgPG4FSx8l5Z8bPSyf2KozxJh0R5MheDRa?= =?us-ascii?Q?kNg2cOmoi2xiSRGf5JPo6BanKEPvsTU9IehlyJnFv6mgh22PgorU9H7nzr6i?= =?us-ascii?Q?dmESAolqfTP47+Myur2p1k6QLzirAsaxA0yWC25F9JAkSVurTTG2cuXNDzGn?= =?us-ascii?Q?D5u9+FuUwKeTxdn6r5449VYNlmTfRwKu30vBsJM6CW+6wYZxLKxwV5fhTJTr?= =?us-ascii?Q?JugWh3eHKyQYa/PuLvD3YdSo/m3QjvQykvvAVZNzqYFCywOuauHQOGve1Lre?= =?us-ascii?Q?X8n6fqNf/ZlJ2neCQVp9LwMgy7E+XoBMqf5DfvgI6xSycKcodPb9Jx9u6No1?= =?us-ascii?Q?N+VFhOg5YqIEHhlqC9zsOKlX6Koq7Ff3qV8e14pe3+9/Fc2RoYzFDFEMKX3o?= =?us-ascii?Q?/C7znGBb0+1kl8b7sG0oUI=3D?= X-Microsoft-Antispam-Message-Info: wZYOc+mr7riIZcQ8tAR+pLQRd56cwoaajQ0GtvQj3VCeZ9JjXbA9tZ6UZo8wRc1c/yXrZV2l1FecctLEDAVEisy9VQvNzyA/bsBPOhsL01wnvCF+OdfSMloFAFhJJu5ceyll+ZHB7mcYJzNdl4dyRmax6bX8HoUM7p1R1MNyZdTp5wqjDDpAPOgYMUlmwJtszJstL0gQVMKWOL+DNDN42WcthBH1ZVR5+Wj2ZvA/AvuwQOhfoC7G5m1011xGqKAsbmFoFWFnyGTMJj3qjL3xq+lV64y/fJITzhWNJexRpST4PYEs2KaCnk1NTfAIMXppulxnCV5DWh8srmVUAQW72djjmqya/LvGO3B2zhyyvjM= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2620; 6:Rj+hd9stGyP8D47WHfItCBzv9pcgWIAEB4za3SD29n1HtRDFCMEpGV7hFvkYJLMSYD0G6kjkKKTnpnIFdQg22zeUF08yalfm1DQFcxNDtSAg0FNWV9O0HyiKnNPZEAltpEpceEzQUiAojEzjVeJ3FKGuqZKdjRm54aDwiVCWgM8oeuoWKoT2EEZzk5YYj4uFOz0Bq9EMV0J7SmuOe7FNrzmnKprABQKMPw+T7IjwHBcI2yy1COTMbrDIlbY6w1+/bqeMtEuEcpxmhTqvF4l7eaO2g0y0TzIhSUKqhIqYa+qDhyfXApcXLUuJ38vqlOObOYw7anKig7Mu7rlb2idc6SIhR6qH4mYEYVRHw2PkHwv8VjTy0AAO/+XoMdfzhnW6q+V4sULra8Ag4fqmXMAtrOKOt6+00BD06oLgUHGDAfopsTvOuRzd3qS020jN+b2+wSz3e3rtgDDjm4a1NQiBww==; 5:2LBq7eHF6YYwB5VeFvS2GS52GT9AciyXNz5i/+z8stXvj3AxZyNv6igIxZkY4haDDJCYQie2/Y92Mmu63cXOY8cNxtp3KnmRGzdJ02oOq8w3HVawVjBba7S8iVZ1ozqw79a78qqRow+SpSFWvjAyCWBXaU07HWDXjE8qXGdG5GY=; 7:2wnp/P18skzaWHhN2FUEq7zEZABzduka25wIOqDp1fE5rE3mE0eQ2X3Y+yTngRqb2OW0X6JqggrEKOFyQ7ANPU81qfcnkq3ajbJjhQVnXen8NE0HwxtoSJP/lbss0eLsSYAEKhPm8ADKwAHKKk0jP4Gc/pWDtAyzNoMvyXUVDCxSBDp0bnBjhQVfpEY5w4zA3rnmTUtBdhk8jwodFpbVkZgFu2djjPFSVUUClDmARbrM436DzRcE6yZLnCnk6Q0T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2018 22:12:12.6478 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88a206fe-fc88-4bb4-1f90-08d5fd7bff0e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2620 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 2a01:111:f400:fe48::71d Subject: [Qemu-devel] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Leonid Bloch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 2 +- block/qcow2.h | 1 + docs/qcow2-cache.txt | 4 ++-- qapi/block-core.json | 3 ++- qemu-options.hx | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3f75b6e701..15d849d1f0 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -941,7 +941,7 @@ static int qcow2_update_options_prepare(BlockDriverStat= e *bs, /* New interval for cache cleanup timer */ r->cache_clean_interval =3D qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, - s->cache_clean_interval); + DEFAULT_CACHE_CLEAN_INTERVAL); #ifndef CONFIG_LINUX if (r->cache_clean_interval !=3D 0) { error_setg(errp, QCOW2_OPT_CACHE_CLEAN_INTERVAL diff --git a/block/qcow2.h b/block/qcow2.h index d77a31d932..587b053453 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -77,6 +77,7 @@ =20 #define DEFAULT_CLUSTER_SIZE 65536 =20 +#define DEFAULT_CACHE_CLEAN_INTERVAL 600 /* seconds */ =20 #define QCOW2_OPT_LAZY_REFCOUNTS "lazy-refcounts" #define QCOW2_OPT_DISCARD_REQUEST "pass-discard-request" diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index c7625cdeb3..9926f83ada 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -202,8 +202,8 @@ This example removes all unused cache entries every 15 = minutes: =20 -drive file=3Dhd.qcow2,cache-clean-interval=3D900 =20 -If unset, the default value for this parameter is 0 and it disables -this feature. +If unset, the default value for this parameter is 600. Setting it to 0 +disables this feature. =20 Note that this functionality currently relies on the MADV_DONTNEED argument for madvise() to actually free the memory. This is a diff --git a/qapi/block-core.json b/qapi/block-core.json index 5b9084a394..7c6115096a 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2830,7 +2830,8 @@ # # @cache-clean-interval: clean unused entries in the L2 and refcount # caches. The interval is in seconds. The default = value -# is 0 and it disables this feature (since 2.5) +# is 600. Setting 0 disables this feature. (since = 2.5) +# # @encrypt: Image decryption options. Mandatory for # encrypted images, except when doing a metadata-o= nly # probe of the image. (since 2.10) diff --git a/qemu-options.hx b/qemu-options.hx index d6e15b2f06..8cebb0c77d 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -767,7 +767,7 @@ it which is not used for the L2 cache) =20 @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in sec= onds. -The default value is 0 and it disables this feature. +The default value is 600. Setting it to 0 disables this feature. =20 @item pass-discard-request Whether discard requests to the qcow2 device should be forwarded to the da= ta --=20 2.17.1