From nobody Wed Nov 5 10:36:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153373359975918.047055526120403; Wed, 8 Aug 2018 06:06:39 -0700 (PDT) Received: from localhost ([::1]:43614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnOAg-0002Ii-Ef for importer@patchew.org; Wed, 08 Aug 2018 09:06:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnNkc-0004Xg-6v for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnNka-0006yu-I5 for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:39:42 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:33328) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnNka-0006wL-5t for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:39:40 -0400 Received: by mail-wr1-x444.google.com with SMTP id g6-v6so1909805wrp.0 for ; Wed, 08 Aug 2018 05:39:40 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 8-v6sm9350975wmw.34.2018.08.08.05.39.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 05:39:35 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 90D503E0625; Wed, 8 Aug 2018 13:39:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZdYBzurg9prqy4LtY5QrG2Or37uNr2pMAaPFSDW/xqQ=; b=hnGw33Y/ONiw5MjOeQnU/dBy682+upLZ+WZdyVSx2uMxFcpVOBhxV/FiQ0YgSrIlmd aIiCc0jqVu+Qey888NzX53tTKRUJT1tex50Py7yRQLKZlm6K4N5rorMae0bmDA38h+RE 7AQmFuTfOXFfq37JGtg1JUohAvqubFNvnl7Mg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZdYBzurg9prqy4LtY5QrG2Or37uNr2pMAaPFSDW/xqQ=; b=ejUBHZoG6tPvNhQ8w4NuLFp4u6P2+b9Q1Q+aQvOk7MNEsu9U2paduj8LxPpKnIMzpY d5NCZQ2o/8DMkpUPLztU9oNmKsKnW7igGvjloejrP/kBjLqWN6FQ7pZyVkfwWa3hcxC5 VeHLT8QQnyA1tZbLzZX/InTy8+skWUpWPB7ouyZVcu7wlg64szpXl5ctgPt7pOIdmiIq LwAOyBOcxmrFh+9UZz2zcKsUskIcg9t7gRkxhL6f1s3kle6OIfROiPUNaN6DHGtvw2/C F/8T5UdG1tw+mM1m0+2tq24kkaB3jFO/HWhDOHwFQiT2iCNG269361vxmLUpH4lIXxkJ SMGg== X-Gm-Message-State: AOUpUlF5/SXKRra2AINiO+73jB9WvuWSnMQyBhPd/kO4uEI7FMxenhwl Y5TxaeBe82+P8szMQxPFPJDz7g== X-Google-Smtp-Source: AA+uWPxiNON81tMwQse8KGznNUzAkEbmPBRLNurO6Utj/ILty1QyrHaXO9o56LfpWKDO5VGdi3de3A== X-Received: by 2002:adf:ecc6:: with SMTP id s6-v6mr1915060wro.160.1533731979071; Wed, 08 Aug 2018 05:39:39 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 8 Aug 2018 13:39:33 +0100 Message-Id: <20180808123934.17450-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180808123934.17450-1-alex.bennee@linaro.org> References: <20180808123934.17450-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [RFC PATCH 3/4] target/arm: add a fallback disassemble function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, richard.henderson@linaro.org, Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Now we can generate a disassembler we need a function to hook into it. As we only deal with SVE instructions at the moment we don't need to differentiate the various decoders. I special case 0x5af0 as it is used by RISU for checkpoints. Signed-off-by: Alex Benn=C3=A9e --- target/arm/Makefile.objs | 8 ++++++++ target/arm/disassemble.c | 22 ++++++++++++++++++++++ target/arm/internals.h | 2 ++ 3 files changed, 32 insertions(+) create mode 100644 target/arm/disassemble.c diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.objs index 11c7baf8a3..4339353df8 100644 --- a/target/arm/Makefile.objs +++ b/target/arm/Makefile.objs @@ -20,3 +20,11 @@ target/arm/decode-sve.inc.c: $(SRC_PATH)/target/arm/sve.= decode $(DECODETREE) =20 target/arm/translate-sve.o: target/arm/decode-sve.inc.c obj-$(TARGET_AARCH64) +=3D translate-sve.o sve_helper.o + +target/arm/disas-sve.inc.c: $(SRC_PATH)/target/arm/sve.decode $(DECODETREE) + $(call quiet-command,\ + $(PYTHON) $(DECODETREE) --disassemble -o $@ $<,\ + "GEN", $(TARGET_DIR)$@) + +target/arm/disassemble.o: target/arm/disas-sve.inc.c +obj-$(TARGET_AARCH64) +=3D disassemble.o diff --git a/target/arm/disassemble.c b/target/arm/disassemble.c new file mode 100644 index 0000000000..801f9680cb --- /dev/null +++ b/target/arm/disassemble.c @@ -0,0 +1,22 @@ +/* + * Fallback dissasembly + */ +#include "qemu/osdep.h" +#include "cpu.h" +#include "internals.h" +#include "decoder.h" + +#include "disas-sve.inc.c" + +size_t do_aarch64_fallback_disassembly(const uint8_t *insnp, char *ptr, si= ze_t n) +{ + uint32_t insn =3D ldl_p(insnp); + + if (insn =3D=3D 0x5af0) { + snprintf(ptr, n, "illegal insn (risu checkpoint?)"); + } else if (!decode(ptr, n, insn)) { + snprintf(ptr, n, "failed decode"); + } + + return 4; +} diff --git a/target/arm/internals.h b/target/arm/internals.h index dc9357766c..80796632a2 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -796,4 +796,6 @@ static inline uint32_t arm_debug_exception_fsr(CPUARMSt= ate *env) } } =20 +size_t do_aarch64_fallback_disassembly(const uint8_t *insn, char *ptr, siz= e_t n); + #endif --=20 2.17.1