From nobody Wed Nov 5 07:16:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1533680388628731.9791027837914; Tue, 7 Aug 2018 15:19:48 -0700 (PDT) Received: from localhost ([::1]:41044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnAKI-000302-EH for importer@patchew.org; Tue, 07 Aug 2018 18:19:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnAJJ-0002hA-KV for qemu-devel@nongnu.org; Tue, 07 Aug 2018 18:18:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnAJI-00030h-Mk for qemu-devel@nongnu.org; Tue, 07 Aug 2018 18:18:37 -0400 Received: from mail.lekensteyn.nl ([2a02:2308::360:1:25]:39189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnAJI-0002zp-Cb; Tue, 07 Aug 2018 18:18:36 -0400 Received: by lekensteyn.nl with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fnAJE-0006q5-99; Wed, 08 Aug 2018 00:18:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lekensteyn.nl; s=s2048-2015-q1; h=Message-Id:Date:Subject:Cc:To:From; bh=ts+ynJxEGifjDQ4UDe13LlLpEYFbHnFQHIj0MqTjsQs=; b=C1mdznG8C40hGckr418b83mgmt5oJeox4dqAX/d87ZXFjrZ7ims4mkDH4SNqULc9ifllXE90cxmDV4qFFFWkombqJB6fOdSmMeszwOES1rAfQq7efq+1rANP2ImjujizA0tZxD/8FsNB/myTR9wYVXeamKNavB0HdOr6ZD4fqr4wc8S28a8a09z+fO/Wpnx+H3sBJaxAfO9ycyLWdxnu/CXKjAedr5+W0GfUpJ87psNLD4FZDlkDm8KNQwJ5kM7NeudB7xW5fdXLMDn6fojpENWv3QLmqpuOnf5b+o7Xs6eLZxc4/GtyEV4yrjhQgRtDTuH9iPwN+Ci1E+mIfy3GzA==; From: Peter Wu To: qemu-devel@nongnu.org Date: Wed, 8 Aug 2018 00:18:30 +0200 Message-Id: <20180807221830.3844-1-peter@lekensteyn.nl> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a02:2308::360:1:25 Subject: [Qemu-devel] [PATCH] vnc: fix memleak of the "vnc-worker-output" name X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fixes repeated memory leaks of 18 bytes when using VNC: Direct leak of 831024 byte(s) in 46168 object(s) allocated from: ... #4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514 #5 0x56085cdcf660 in buffer_init util/buffer.c:59 #6 0x56085ca6a7ec in vnc_async_encoding_start ui/vnc-jobs.c:177 #7 0x56085ca6b815 in vnc_worker_thread_loop ui/vnc-jobs.c:240 Fixes: 543b95801f98 ("vnc: attach names to buffers") Cc: Gerd Hoffmann CC: qemu-stable@nongnu.org Signed-off-by: Peter Wu Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/vnc-jobs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index b0b15d42a8..929391f85d 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -193,6 +193,7 @@ static void vnc_async_encoding_start(VncState *orig, Vn= cState *local) =20 static void vnc_async_encoding_end(VncState *orig, VncState *local) { + buffer_free(&local->output); orig->tight =3D local->tight; orig->zlib =3D local->zlib; orig->hextile =3D local->hextile; @@ -278,7 +279,7 @@ static int vnc_worker_thread_loop(VncJobQueue *queue) /* Copy persistent encoding data */ vnc_async_encoding_end(job->vs, &vs); =20 - qemu_bh_schedule(job->vs->bh); + qemu_bh_schedule(job->vs->bh); } else { buffer_reset(&vs.output); /* Copy persistent encoding data */ --=20 2.18.0