From nobody Wed Nov 5 02:32:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532973890820858.9843478258279; Mon, 30 Jul 2018 11:04:50 -0700 (PDT) Received: from localhost ([::1]:55157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkCXF-00041c-Ce for importer@patchew.org; Mon, 30 Jul 2018 14:04:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkC8q-0006OO-5K for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkC8m-0002wJ-LR for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:39:32 -0400 Received: from os.inf.tu-dresden.de ([141.76.48.99]:50662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkC8m-0002uQ-Dj for qemu-devel@nongnu.org; Mon, 30 Jul 2018 13:39:28 -0400 Received: from erwin.inf.tu-dresden.de ([141.76.48.80] helo=os.inf.tu-dresden.de) by os.inf.tu-dresden.de with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) id 1fkC6d-0004Bz-Hg for qemu-devel@nongnu.org; Mon, 30 Jul 2018 19:37:15 +0200 Date: Mon, 30 Jul 2018 19:37:12 +0200 From: Adam Lackorzynski To: qemu-devel@nongnu.org Message-ID: <20180730173712.GG4987@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 141.76.48.99 X-Mailman-Approved-At: Mon, 30 Jul 2018 14:03:38 -0400 Subject: [Qemu-devel] [PATCH] arm: Fix return code of arm_load_elf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use an int64_t as a return type to restore the negative check for arm_load_as. Signed-off-by: Adam Lackorzynski --- hw/arm/boot.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index e09201cc97..ca9467e583 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -818,9 +818,9 @@ static int do_arm_linux_init(Object *obj, void *opaque) return 0; } =20 -static uint64_t arm_load_elf(struct arm_boot_info *info, uint64_t *pentry, - uint64_t *lowaddr, uint64_t *highaddr, - int elf_machine, AddressSpace *as) +static int64_t arm_load_elf(struct arm_boot_info *info, uint64_t *pentry, + uint64_t *lowaddr, uint64_t *highaddr, + int elf_machine, AddressSpace *as) { bool elf_is64; union { @@ -829,7 +829,7 @@ static uint64_t arm_load_elf(struct arm_boot_info *info= , uint64_t *pentry, } elf_header; int data_swab =3D 0; bool big_endian; - uint64_t ret =3D -1; + int64_t ret =3D -1; Error *err =3D NULL; =20 =20 --=20 2.18.0