From nobody Wed Nov 5 02:34:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532925644157257.30072594358285; Sun, 29 Jul 2018 21:40:44 -0700 (PDT) Received: from localhost ([::1]:50529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjzz3-0007yd-5O for importer@patchew.org; Mon, 30 Jul 2018 00:40:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjzy5-0007F3-Fs for qemu-devel@nongnu.org; Mon, 30 Jul 2018 00:39:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjzy2-0000VG-6P for qemu-devel@nongnu.org; Mon, 30 Jul 2018 00:39:37 -0400 Received: from relay4.mail.vrmd.de ([81.28.224.58]:53996) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjzy1-0000UZ-Vi; Mon, 30 Jul 2018 00:39:34 -0400 Received: from [88.75.177.198] (helo=murray.fritz.box) by relay2.mail.vrmd.de with esmtpa (Exim 4.86_2) (envelope-from ) id 1fjzxp-0001sO-F5; Mon, 30 Jul 2018 06:39:21 +0200 From: Sebastian Bauer To: mail@sebastianbauer.info Date: Mon, 30 Jul 2018 06:39:04 +0200 Message-Id: <20180730043904.17023-1-mail@sebastianbauer.info> X-Mailer: git-send-email 2.18.0 X-Relay-User: mail@sebastianbauer.info X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 81.28.224.58 Subject: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: agraf@suse.de, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The four interrupts of the PCI bus are connected to the same UIC pin on the real Sam460ex. Evidence for this can be found in the UBoot source for the Sam460ex in the Sam460ex.c file where PCI_INTERRUPT_LINE in written. This change brings the connection in line with this. This fixes the problem that can be observed when adding further PCI cards that get their interrupt rotated to other interrupts than PCI INT A. In particular, the bug was observed and verified to be fixed (after this change) with an additional OHCI PCI card. Signed-off-by: Sebastian Bauer --- hw/ppc/sam460ex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 0999efcc1e..b2b22f280d 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -515,9 +515,9 @@ static void sam460ex_init(MachineState *machine) =20 /* PCI bus */ ppc460ex_pcie_init(env); - /* FIXME: is this correct? */ + /* All PCI ints are connected to the same UIC pin (cf. UBoot source) */ dev =3D sysbus_create_varargs("ppc440-pcix-host", 0xc0ec00000, - uic[1][0], uic[1][20], uic[1][21], uic[1][= 22], + uic[1][0], uic[1][0], uic[1][0], uic[1][0], NULL); pci_bus =3D (PCIBus *)qdev_get_child_bus(dev, "pci.0"); if (!pci_bus) { --=20 2.18.0