From nobody Wed Nov 5 05:07:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532762429476641.0262308417406; Sat, 28 Jul 2018 00:20:29 -0700 (PDT) Received: from localhost ([::1]:44162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjJWe-0000Wz-FM for importer@patchew.org; Sat, 28 Jul 2018 03:20:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjJT2-0006HK-AK for qemu-devel@nongnu.org; Sat, 28 Jul 2018 03:16:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjJSz-0007mE-73 for qemu-devel@nongnu.org; Sat, 28 Jul 2018 03:16:44 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39396 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjJSz-0007ky-2w for qemu-devel@nongnu.org; Sat, 28 Jul 2018 03:16:41 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24BFF7DAC3 for ; Sat, 28 Jul 2018 07:16:40 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-135.ams2.redhat.com [10.36.116.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC8EC2156701 for ; Sat, 28 Jul 2018 07:16:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AED5A11385E4; Sat, 28 Jul 2018 09:16:38 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Sat, 28 Jul 2018 09:16:37 +0200 Message-Id: <20180728071638.17077-3-armbru@redhat.com> In-Reply-To: <20180728071638.17077-1-armbru@redhat.com> References: <20180728071638.17077-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 28 Jul 2018 07:16:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 28 Jul 2018 07:16:40 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL v2 2/3] qstring: Assert size calculations don't overflow X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Message-Id: <20180727062204.10401-2-armbru@redhat.com> Reviewed-by: Eric Blake --- qobject/qstring.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qobject/qstring.c b/qobject/qstring.c index 18b8eb82f8..1bb7784a88 100644 --- a/qobject/qstring.c +++ b/qobject/qstring.c @@ -41,17 +41,19 @@ QString *qstring_from_substr(const char *str, size_t st= art, size_t end) { QString *qstring; =20 + assert(start <=3D end + 1); + qstring =3D g_malloc(sizeof(*qstring)); qobject_init(QOBJECT(qstring), QTYPE_QSTRING); =20 qstring->length =3D end - start + 1; qstring->capacity =3D qstring->length; =20 + assert(qstring->capacity < SIZE_MAX); qstring->string =3D g_malloc(qstring->capacity + 1); memcpy(qstring->string, str + start, qstring->length); qstring->string[qstring->length] =3D 0; =20 - return qstring; } =20 @@ -68,7 +70,9 @@ QString *qstring_from_str(const char *str) static void capacity_increase(QString *qstring, size_t len) { if (qstring->capacity < (qstring->length + len)) { + assert(len <=3D SIZE_MAX - qstring->capacity); qstring->capacity +=3D len; + assert(qstring->capacity <=3D SIZE_MAX / 2); qstring->capacity *=3D 2; /* use exponential growth */ =20 qstring->string =3D g_realloc(qstring->string, qstring->capacity += 1); --=20 2.17.1