From nobody Wed Nov 5 05:06:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15324296095781009.3666772251584; Tue, 24 Jul 2018 03:53:29 -0700 (PDT) Received: from localhost ([::1]:39448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhuwX-00026Z-CH for importer@patchew.org; Tue, 24 Jul 2018 06:53:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhuuV-0000s7-Gu for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhuuU-0006RY-62 for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:19 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:40457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhuuT-0006Qx-Ta for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:18 -0400 Received: by mail-wr1-x441.google.com with SMTP id t6-v6so3653925wrn.7 for ; Tue, 24 Jul 2018 03:51:17 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r12-v6sm1767411wmc.27.2018.07.24.03.51.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 03:51:11 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 5B8503E0641; Tue, 24 Jul 2018 11:51:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+pe6j9bzOj5I4gXcwzbYdbHIcfj1wXvLg53uu7KEQGE=; b=fZQaD/wXtEOvePzWAJMyFqH3qTDmoDensstXUc74wsr+zB+97GQSERtFA1EWSRuz9y Jv3A2LFWZHzw7N8qChLMpyHso0IJ47moGmjqd0utin8DsdD0IUn1eISC6HhFW+cNXFOv +sKbfXmp4biZcK9ZD6pTULxdnOen7VIsdo0B8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+pe6j9bzOj5I4gXcwzbYdbHIcfj1wXvLg53uu7KEQGE=; b=TxzPzZoLVl3rT9GnNVEUszvsAi6hpp/fDSV2lanI+5iPnQMzNsK+Q/mNSdTfXJgdsT 0DypwJWFFNZ/yCeK5B8uk0Lvfx119QybVmbFd5e/+kYNDXsYWTY3IVOLto/8opHsG6rP UAaGHQxTlGcksdR7NV7Kq2nragpVMeZGU9zj5G7vwqvR6QM8+owQGVFE4Fk+DqUtJoK5 ygm+4BmFOxgGpVGlhm5aF1zzQG/ynd1KTlGHCXAOsCJxl3o/7J0yBFg0l2Sjnoy+zp83 9LIUSd6LosSdkS7UtFW3pSzScWka6q3aIZ8qxL+40iT5wFPrWGyVX5Pfqezi3pSlRvC+ bT+w== X-Gm-Message-State: AOUpUlHJ367CoPMLTnTKPCwD7eocgBIaie3EGNchYN17DV81ZFBgweLa R8WSg6ss7i5ZSHOOcVEh9f8PIQ== X-Google-Smtp-Source: AAOMgpesT7wcnOjLap79ErVV6WpfC+/1TZ4ZabHQR5f+gBAqQeeQFJw4ux1N395pVL0JiRSnLYqiog== X-Received: by 2002:adf:dbc3:: with SMTP id e3-v6mr10786666wrj.217.1532429476811; Tue, 24 Jul 2018 03:51:16 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 24 Jul 2018 11:50:58 +0100 Message-Id: <20180724105109.8392-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180724105109.8392-1-alex.bennee@linaro.org> References: <20180724105109.8392-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PULL 06/17] docker: move make check into check_qemu helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Not all docker images can run the check step. Let's move everything into a common helper so we don't need to replicate checks in the future. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 diff --git a/tests/docker/common.rc b/tests/docker/common.rc index ba1f942328..4ff5974016 100755 --- a/tests/docker/common.rc +++ b/tests/docker/common.rc @@ -40,6 +40,17 @@ build_qemu() make $MAKEFLAGS } =20 +check_qemu() +{ + # default to make check unless the caller specifies + if test -z "$@"; then + INVOCATION=3D"check" + else + INVOCATION=3D"$@" + fi + make $MAKEFLAGS $INVOCATION +} + test_fail() { echo "$@" diff --git a/tests/docker/test-clang b/tests/docker/test-clang index e90a793178..324e341cea 100755 --- a/tests/docker/test-clang +++ b/tests/docker/test-clang @@ -23,5 +23,5 @@ OPTS=3D"--cxx=3Dclang++ --cc=3Dclang --host-cc=3Dclang" #OPTS=3D"$OPTS --extra-cflags=3D-fsanitize=3Dundefined \ #--extra-cflags=3D-fno-sanitize=3Dfloat-divide-by-zero" build_qemu $OPTS -make $MAKEFLAGS check +check_qemu install_qemu diff --git a/tests/docker/test-debug b/tests/docker/test-debug index d3f9f70d01..137f4f2ddc 100755 --- a/tests/docker/test-debug +++ b/tests/docker/test-debug @@ -22,5 +22,5 @@ OPTS=3D"--cxx=3Dclang++ --cc=3Dclang --host-cc=3Dclang" OPTS=3D"--enable-debug --enable-sanitizers $OPTS" =20 build_qemu $OPTS -make $MAKEFLAGS V=3D1 check +check_qemu check V=3D1 install_qemu diff --git a/tests/docker/test-full b/tests/docker/test-full index b4e42d25d7..aadc0f00a2 100755 --- a/tests/docker/test-full +++ b/tests/docker/test-full @@ -15,4 +15,4 @@ =20 cd "$BUILD_DIR" =20 -build_qemu && make check $MAKEFLAGS && install_qemu +build_qemu && check_qemu && install_qemu diff --git a/tests/docker/test-quick b/tests/docker/test-quick index 3b7bce6105..eee59c55fb 100755 --- a/tests/docker/test-quick +++ b/tests/docker/test-quick @@ -18,5 +18,5 @@ cd "$BUILD_DIR" DEF_TARGET_LIST=3D"x86_64-softmmu,aarch64-softmmu" TARGET_LIST=3D${TARGET_LIST:-$DEF_TARGET_LIST} \ build_qemu -make check $MAKEFLAGS +check_qemu install_qemu --=20 2.17.1