From nobody Sun Feb 8 18:30:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532382038844926.5968423475184; Mon, 23 Jul 2018 14:40:38 -0700 (PDT) Received: from localhost ([::1]:36863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiZJ-0001cg-Ps for importer@patchew.org; Mon, 23 Jul 2018 17:40:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhLP-0004ah-Gu for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:22:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhLO-0005ku-EB for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:22:11 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:46072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhLO-0005kg-7d; Mon, 23 Jul 2018 16:22:10 -0400 Received: by mail-oi0-x242.google.com with SMTP id q11-v6so3459262oic.12; Mon, 23 Jul 2018 13:22:10 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id s142-v6sm8878382oie.48.2018.07.23.13.22.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=MyIGE6LzMk2vXNjZpmHXXX4cDfH+h6iDmYr4BXEzbKs=; b=VN7GerCBYDduANiRmu7chP54FD+zuIU+05ZAxUyAv5vwXxXdugVzkboLWfvn1BN6C7 31oZFDwyhUqI1iVEp7dlbJ7iZnqOsHQvMjWyolP1scnbe6nkW3MrE9OcTTKxbSfXH/Pr WVrZPrBz7NXM3cMZho71jFGeaJtFLlbCt02ytiyfPxajqnLrrT5hFQqDE7xw5JJUo9p9 CbmjW3vHufa6bsucNqs0d5OwqjqHWrineB9hE7x0seFCimh2JMvUoptM0/qb8FiOoFqT aXSJooUFW8bxl/vWpl6ByoY5G4Ygl4zqvpB3UWZhlaqaqKONi27gAccCUNn9rpraRN/6 VeqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=MyIGE6LzMk2vXNjZpmHXXX4cDfH+h6iDmYr4BXEzbKs=; b=J4ZXlOkpu+d9vVgI/nrUWvX6A8gmMCRKDBZUzMnQlMrnZyidvRIODKLE0tYAeHtdqW xRB1OlHAykAvnuUDY0+jAeDBOglr8SM3Qoti6djfqsoPHLcJwHPnQdn3JDmnNgOzitLF DRxZTEnhca/Blm4fQr6jGJXV+DIA207e4uoXFQJ0RfhgG7n1Sn17sNwteQuumVGfOvhF /nPKMJBYZ31L0EvL4M6BAJUsFVVdeuOlNXwlVpiBIdgUGXtBcIf0Mi7QkLo0ZfRofxSg K38z5v5Hny14c3yKn1v8cAHLfGSqWPlK4B2bQVOIYaHoP8nTS/xeZRHP9VhuLk5Yfa36 GXkw== X-Gm-Message-State: AOUpUlFWPnssZZoWXeZfJiW5Ej1YJGCPAneVdF7MARMi/aB5+HYrdRyk M3Mdgv63FAeXOE8F6ZrMQjxJfJQBCyTFRg== X-Google-Smtp-Source: AAOMgpfiEs6BJf0UKK3e7Gt3SS1pxVkfWg/Aan3NGl8Jb9nIncZY8ALcu4CHmFuXPNVHXg0R2Hpxgw== X-Received: by 2002:aca:bf88:: with SMTP id p130-v6mr292648oif.344.1532377329075; Mon, 23 Jul 2018 13:22:09 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:45 -0500 Message-Id: <20180723201748.25573-97-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::242 Subject: [Qemu-devel] [PATCH 96/99] target/ppc: set is_jmp on ppc_tr_breakpoint_check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , qemu-stable@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert to TranslatorOps", 2018-02-16). Fix it by setting is_jmp, so that we break from the translation loop as originally intended. Tested-by: Mark Cave-Ayland Reported-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: David Gibson (cherry picked from commit 2a8ceefca23bc2aaafe711f8afd7585be3c27064) Signed-off-by: Michael Roth --- target/ppc/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3457d29f8e..c535cd76f2 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7296,6 +7296,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase = *dcbase, CPUState *cs, DisasContext *ctx =3D container_of(dcbase, DisasContext, base); =20 gen_debug_exception(ctx); + dcbase->is_jmp =3D DISAS_NORETURN; /* The address covered by the breakpoint must be included in [tb->pc, tb->pc + tb->size) in order to for it to be properly cleared -- thus we increment the PC here so that --=20 2.17.1