From nobody Sun Feb 8 18:30:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532381241418681.0214611766229; Mon, 23 Jul 2018 14:27:21 -0700 (PDT) Received: from localhost ([::1]:36771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiMS-0004Nx-DB for importer@patchew.org; Mon, 23 Jul 2018 17:27:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhL3-0004Fa-Hz for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhL0-0005XH-Gl for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:49 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:41193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhL0-0005Wu-A0; Mon, 23 Jul 2018 16:21:46 -0400 Received: by mail-oi0-x242.google.com with SMTP id k12-v6so3471708oiw.8; Mon, 23 Jul 2018 13:21:46 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id r133-v6sm7512020oia.33.2018.07.23.13.21.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XsX1EfwzxLyNCkb8W94bPS3FZCOVUqOQnXVP2BsHDx8=; b=GW5/hb0LmMkNUZc8PghYqRxPkQnDpr2G8Vlccw0gWfZycebFdIfIK/8UhIWpkozGil EIGxQuoxxnwXpiQmZ6eDY+T34JYZydtsyHCa3J9uLwZXR0tS+QXYOveIAvRjuIvg35gj V7M+m4CZF1hkw/J08wXRkf3Q+/7f5x0cMQWua/zmJkG/kYeR30rO0TFKWJkYor52sqBr VsXXb8+VP7A9m7GOaGJFhMnSX2cVLYuFNnvpC2D/e0g3qEVkolHWRaNGB0d7xqxRwpQU vYHgTynzk6vzvjbFsjt58H+1ZeyMmoStGM202+YLWBBUJuKvASfs/WY3so3j97LS/UHI KaPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XsX1EfwzxLyNCkb8W94bPS3FZCOVUqOQnXVP2BsHDx8=; b=Ku5dvInUzezEJilBQuJDJDv/SrrwdKHsckKqbHWs5ZKqSuMMvJeEzaZ7ekJ552tXcA x2Dj8GMthGojs9I3jB1meZNI5ElDak7RmmMjJICwkFeyyyUCG7r6ZXn2mYUHztIxe/OZ W/WZ4oEOHYrn8dD/pNbx85jSJ8J796ONt1OZywpxDw2A2tjXtsVEZa/nVLVwpS1NldAo xGRXB4S7pzUYfrRXiZljSsPI45Y2kgc22cHtD0vVkUrGhFjnXUdg7i3tBnS+fsXpEJ2C ncGYSFIvTc9gXpdniIe+gfqtYSPSXCZgR1LBQwtm2542UNKdtgrTI7FEh0lBUIrm9M77 2vRg== X-Gm-Message-State: AOUpUlGfqixTZzNJ8+cjgeTvPOuvRksGiFYHbSqznLNXLUAttG2HO7MA 4St5nRhQBZ4FKt+DUjgfbdLq8WQHvk1vBg== X-Google-Smtp-Source: AAOMgpfeGgXdgR4OUlZ27XVbshysPOlK2KDSxas1Bn+d8CcQb8VMIO2/EAh4RyDVYkAnuR96PSBxUQ== X-Received: by 2002:aca:4886:: with SMTP id v128-v6mr319298oia.69.1532377305143; Mon, 23 Jul 2018 13:21:45 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:35 -0500 Message-Id: <20180723201748.25573-87-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::242 Subject: [Qemu-devel] [PATCH 86/99] hw/isa/superio: Fix inconsistent use of Chardev->be X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-stable@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Philippe Mathieu-Daud=C3=A9 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent use of Chardev->be. Also, this CharBackend member is private and is not supposed to be accessible. Fix it by removing the inconsistent check. Cc: qemu-stable@nongnu.org Reported-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20180515152500.19460-2-f4bug@amsat.org> Signed-off-by: Paolo Bonzini Reviewed-by: Marc-Andr=C3=A9 Lureau (cherry picked from commit d4c8fcd91abba584f2788dfe5fba5245cea380f0) Conflicts: hw/isa/isa-superio.c * avoid context dep on 9bca0edb28 Signed-off-by: Michael Roth --- hw/isa/isa-superio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c index b95608a003..8ae6ea6f7b 100644 --- a/hw/isa/isa-superio.c +++ b/hw/isa/isa-superio.c @@ -43,7 +43,7 @@ static void isa_superio_realize(DeviceState *dev, Error *= *errp) if (!k->parallel.is_enabled || k->parallel.is_enabled(sio, i)) { /* FIXME use a qdev chardev prop instead of parallel_hds[] */ chr =3D parallel_hds[i]; - if (chr =3D=3D NULL || chr->be) { + if (chr =3D=3D NULL) { name =3D g_strdup_printf("discarding-parallel%d", i); chr =3D qemu_chr_new(name, "null"); } else { @@ -81,9 +81,9 @@ static void isa_superio_realize(DeviceState *dev, Error *= *errp) break; } if (!k->serial.is_enabled || k->serial.is_enabled(sio, i)) { - /* FIXME use a qdev chardev prop instead of serial_hds[] */ + /* FIXME use a qdev chardev prop instead of serial_hd() */ chr =3D serial_hds[i]; - if (chr =3D=3D NULL || chr->be) { + if (chr =3D=3D NULL) { name =3D g_strdup_printf("discarding-serial%d", i); chr =3D qemu_chr_new(name, "null"); } else { --=20 2.17.1