From nobody Sun Feb 8 10:17:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532381333338701.974449842395; Mon, 23 Jul 2018 14:28:53 -0700 (PDT) Received: from localhost ([::1]:36778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiNw-0005gN-5M for importer@patchew.org; Mon, 23 Jul 2018 17:28:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhKc-0003oS-EU for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhKZ-0005JV-CW for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:22 -0400 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:41190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhKZ-0005JE-7E; Mon, 23 Jul 2018 16:21:19 -0400 Received: by mail-oi0-x244.google.com with SMTP id k12-v6so3469388oiw.8; Mon, 23 Jul 2018 13:21:19 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id f75-v6sm17900876oig.53.2018.07.23.13.21.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0eWGZUjdYHS8DbjInkKruRTzzxqxsVA0NX9o2ecCaEQ=; b=qeAzSBy343dbAF41NVVWms+hlQB7yjrZSj6eP1iFFL+9vfoddfxDJFHdVQuNXclgQH btJ9L4fgYGfus8Hng6ehX/f0YBMinWIjAy4zCP+XVWD0kwe8G2C4QlUAJVOtmv7RWeIO 1XBDSwodbjhw4kK5J1HTZ8RAKbHQYZbpQRYKXVvq5p3VhsjU38O94dsv9KmNlV8o2Rv/ gM0MASjWUswTgxoEbvZyLmj4yTfYRyjwJY0c3ou8deHC8E+Uskib39zkOLD+yFtByihw uf6cJPd1pd8JeoW+b4+o10qPW0ZzDcNMKpv6XexVzGbCG6+L/Xpd7oNfSNMev/Kqhz2n LJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0eWGZUjdYHS8DbjInkKruRTzzxqxsVA0NX9o2ecCaEQ=; b=AQ7OQIKu9qjymJ/UyKUrJqf/D46qQ5PSGf7s/KsLMN3DSozpJS6KMfgfAd+p5T8z6W F0OMYNZau77Fk1WGAQlwZ+rRb6ziCTxBp8RM7Yrd7pu0wBcJAFHQ4MLpg9vFKRCkKnlK Aj/yPaLGkHcv8tnsoWBZ3+U16+ToDjEMUIkumdthhssvlQyd1The4iLASH4EwFA8lnoE pYWy7zTtyzMEVAHhEg8ImIAD99QhXw+d7qzRqNbOrIoUTHvPYZZObzMzH2+Ur/NwXcdD PlVBFXzAAIgRDDv8QVqC0Nq0riDV546d8S5aVB/4yHV5CDP4WcXa+rPAIB+qj5U4TDWb Jutg== X-Gm-Message-State: AOUpUlElbj7I9oQA6ii2FNYDq53h1AiMB6TliQGRYJT8BV0DB9nVBwnI ce6LKu2FD78y3QfeX5eANaRMWLA3eM63BA== X-Google-Smtp-Source: AAOMgpc/7HXWqTYH9yDth6i2tleYGGOJ2JvBIWnJrC8VcsxmjBcJhZPFooKkrCyPRT5j7VZlebzq8Q== X-Received: by 2002:aca:560d:: with SMTP id k13-v6mr312577oib.190.1532377278061; Mon, 23 Jul 2018 13:21:18 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:24 -0500 Message-Id: <20180723201748.25573-76-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::244 Subject: [Qemu-devel] [PATCH 75/99] fpu/softfloat: Fix conversion from uint64 to float128 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-stable@nongnu.org, Petr Tesarik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Petr Tesarik The significand is passed to normalizeRoundAndPackFloat128() as high first, low second. The current code passes the integer first, so the result is incorrectly shifted left by 64 bits. This bug affects the emulation of s390x instruction CXLGBR (convert from logical 64-bit binary-integer operand to extended BFP result). Cc: qemu-stable@nongnu.org Tested-by: Alex Benn=C3=A9e Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Signed-off-by: Petr Tesarik Message-Id: <20180511071052.1443-1-ptesarik@suse.com> Signed-off-by: Richard Henderson (cherry picked from commit 6603d50648901e8b9e6d66ec1142accf0b1df1e6) Signed-off-by: Michael Roth --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9bcaaebe4f..a926b91864 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -3147,7 +3147,7 @@ float128 uint64_to_float128(uint64_t a, float_status = *status) if (a =3D=3D 0) { return float128_zero; } - return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status); + return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status); } =20 =20 --=20 2.17.1