From nobody Sun Feb 8 12:37:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532377509055340.66075970741895; Mon, 23 Jul 2018 13:25:09 -0700 (PDT) Received: from localhost ([::1]:36354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhOG-0006rO-21 for importer@patchew.org; Mon, 23 Jul 2018 16:25:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhIF-0001QU-Ot for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhIE-0002Sp-R2 for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:18:55 -0400 Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:33562) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhIE-0002R8-M4; Mon, 23 Jul 2018 16:18:54 -0400 Received: by mail-oi0-x229.google.com with SMTP id l10-v6so3493865oii.0; Mon, 23 Jul 2018 13:18:54 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id e125-v6sm9832771oig.4.2018.07.23.13.18.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=pgeIXs/uHoRVfNlBGmWIXBh9ayrWzXkSCAujd7RNfMM=; b=uVxWp5e5zW+RhGjzovSPNffqXWviFkPiQ8KjkrRUsKtCvFtxBr8uSmscj2Jus79Hpu 8wnDPkrAXdDknRsVerSLBZXZYOAqBnLobuymDlQc8KixCmtgnXN9qcmARlU85HVQ6zMG cr1ehZLoii7N7lixs7E3uaQktadTpyhu6x1uFgn66a0omdBdAqWoxRRnZd+9gUai+nfR qU6pi+Mzpb2xT2VyUrv1/HHZ4bNKWaeofcuzPVEBYMX8GykGvthS1+2XEcE9jCqJMEXE z6Drwk/KJMqlNJGWvl3YDtpgNJaeJ4WJznP+BzRD63A//eM34vKyHxNV0pS8dYi0h44y UBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=pgeIXs/uHoRVfNlBGmWIXBh9ayrWzXkSCAujd7RNfMM=; b=hPY20bpqiAdmpZGusrXXAESpE6oqTVntDp0uY8eZ8CaskPv/L6G+ctdmguFeiiHZXV QUPuX0GvOtEgh5EU9HdPIIy7oEC8ObaX1YGuwvwazAGAauHOjB+JZAVzMll72IppvGj6 3QItolzTGLdOAL2Emtlb1j3AyIZScpfgJ28JPvbM0GkYbJt/jekWjjqPv1MFi+MXJ02R B7T1ZG3Snu80F9E8nhUrrFmsXVn78/dbWKpRehdNKPYnpXM3EGQ/PWgKK2hsrTZ/XfzV tK/0PvMn22xm0alBblyc4OLyCdewPwQFpkuAJbJNXeD8azP1ShMAbG3gvqRPmcAlWAGo rNqA== X-Gm-Message-State: AOUpUlFXoeE5npxu+dA5CqRLS+asBTtYO2WuS26tRMYLEkN81tOcP5BU pbyOMrRxnixCff0cxz+NCAASUsU1FvA= X-Google-Smtp-Source: AAOMgpfg8g9nlc4WGCjQSC1V5LjT9cwg5si7vOnDGhD44YDaWw024reLiOQA3X3LKltVB4NXMcAmMw== X-Received: by 2002:aca:4c7:: with SMTP id 190-v6mr292099oie.107.1532377133498; Mon, 23 Jul 2018 13:18:53 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:16:24 -0500 Message-Id: <20180723201748.25573-16-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::229 Subject: [Qemu-devel] [PATCH 15/99] qemu-img: Use only string options in img_open_opts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-stable@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Max Reitz img_open_opts() takes a QemuOpts and converts them to a QDict, so all values therein are strings. Then it may try to call qdict_get_bool(), however, which will fail with a segmentation fault every time: $ ./qemu-img info -U --image-opts \ driver=3Dfile,filename=3D/dev/null,force-share=3Doff [1] 27869 segmentation fault (core dumped) ./qemu-img info -U --image-opts driver=3Dfile,filename=3D/dev/null,force-share=3Doff Fix this by using qdict_get_str() and comparing the value as a string. Also, when adding a force-share value to the QDict, add it as a string so it fits the rest of the dict. Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz Message-id: 20180502202051.15493-3-mreitz@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz (cherry picked from commit 4615f87832d2fcb7a544bedeece2741bf8c21f94) Signed-off-by: Michael Roth --- qemu-img.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 15d457d6b8..b422fda6f3 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -277,12 +277,12 @@ static BlockBackend *img_open_opts(const char *optstr, options =3D qemu_opts_to_qdict(opts, NULL); if (force_share) { if (qdict_haskey(options, BDRV_OPT_FORCE_SHARE) - && !qdict_get_bool(options, BDRV_OPT_FORCE_SHARE)) { + && strcmp(qdict_get_str(options, BDRV_OPT_FORCE_SHARE), "on"))= { error_report("--force-share/-U conflicts with image options"); QDECREF(options); return NULL; } - qdict_put_bool(options, BDRV_OPT_FORCE_SHARE, true); + qdict_put_str(options, BDRV_OPT_FORCE_SHARE, "on"); } blk =3D blk_new_open(NULL, NULL, options, flags, &local_err); if (!blk) { --=20 2.17.1