From nobody Thu May 2 21:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1532074843040877.3434223865095; Fri, 20 Jul 2018 01:20:43 -0700 (PDT) Received: from localhost ([::1]:46904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgQeX-0005S8-Su for importer@patchew.org; Fri, 20 Jul 2018 04:20:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgQdf-00058j-5p for qemu-devel@nongnu.org; Fri, 20 Jul 2018 04:19:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgQda-0001D0-57 for qemu-devel@nongnu.org; Fri, 20 Jul 2018 04:19:47 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:42942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgQdZ-0001Cw-Qy for qemu-devel@nongnu.org; Fri, 20 Jul 2018 04:19:42 -0400 Received: by mail-wr1-x442.google.com with SMTP id e7-v6so10441887wrs.9 for ; Fri, 20 Jul 2018 01:19:41 -0700 (PDT) Received: from mocramis-ultrabook.localdomain ([178.208.16.32]) by smtp.gmail.com with ESMTPSA id x14-v6sm1001416wrv.21.2018.07.20.01.19.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jul 2018 01:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blade-group.com; s=google; h=from:to:cc:subject:date:message-id; bh=l/lMO+BHLQSKd+cbqhbNcEtF69FYdz0PZ07gmgCjtMs=; b=ZgBABP4XBHec0xiKz/kodZ4eXSLOrOaQ97Jl7mvCRyC+uE6rcSZP8QHwTuvvoKXQpr 70k5Ir9aorq8MTxWHjlUBfestrNj9FdaFW6I4osdVyfb+0ty5YmdKGjdiKDGzWscieuT 0HgnGUtgbb+Aou1uCBixcJAyzPtIMCuLv/EvhQyLZcMWBiwNAy1wqciDqAQkpifo61JD FIQdfQPBoA+RaapUWPUyXtTJlvYhZPuB5lFROYs2lP3DsABSsQQ1RkqLzq+Rg2htLTSL /kckwASdW4sFep+HxT6iN0kVW4fsB3kGCwmxh/FW8ZaZ9zrcWTQwqpIWDJN2/wOCCVSF DH4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l/lMO+BHLQSKd+cbqhbNcEtF69FYdz0PZ07gmgCjtMs=; b=SmER21r27xaIBujMwgaEmVYjnTifybvBvBd9A48PpIeYvpXseArNgOcAglGjtHa7ZJ bTu1oPSv0GFBZD+YGLnko4B0eOyX7M8jBEnJsvyq131eCtLkjCpnUs+fPIKrCJLChGLd nCK5d2mgtK4f8DK/eMC4Z8G1YHFkf6mUoswsjGGfL/8X0CK+vrxwaYyV6WCeTOO65QzF O3bUYv/jA53v1zlVEppFsv+g/fJMm3cHRtqH9iTTpaoHsFHLF2GkAJoO3x4Tyy2nvkE1 pDr/2HHnlmWpw1wBJTOp8TsQ6R+lCdTW3HTM6rhKechqoVurM7267SV5szGbYkxx90/1 8MxQ== X-Gm-Message-State: AOUpUlF3WNm1ZEA3lDR7VErXOIcLZs8QORAm6r8CVpB7ThrLsGVWKTQD oTHuWvu5L/P9D6BEvDU/abN7lqwaKCY= X-Google-Smtp-Source: AAOMgpe5Qj4/9XUNIZ9khfEuzD0YG67lX/Nqk33l0vl30fFT2QqpzNstBj/iWxAs/Aj/EmFgiZ4mqw== X-Received: by 2002:adf:c4a7:: with SMTP id m36-v6mr743352wrf.103.1532074780340; Fri, 20 Jul 2018 01:19:40 -0700 (PDT) From: remy.noel@blade-group.com To: qemu-devel@nongnu.org Date: Fri, 20 Jul 2018 10:19:48 +0200 Message-Id: <20180720081948.23644-1-remy.noel@blade-group.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Remy Noel , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Remy Noel" When removing a secondary-vga device and then adding it back (or adding an other one), qemu aborts with: "RAMBlock "0000:00:02.0/vga.vram" already registered, abort!". It is caused by the vram staying registered, preventing vga replugging. Signed-off-by: Remy Noel --- hw/display/vga-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index e9e62eac70..1c89571e46 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -288,6 +288,7 @@ static void pci_secondary_vga_exit(PCIDevice *dev) VGACommonState *s =3D &d->vga; =20 graphic_console_close(s->con); + vmstate_unregister_ram(&s->vram, DEVICE(dev)); } =20 static void pci_secondary_vga_init(Object *obj) --=20 2.18.0